[BUG] ServerSideSessionCleanupHost is not immune to multiple calls of StopAsync

[aomader]

As of now, the ServerSideSessionCleanupHost implementation throws an exception in case StopAsync is called multiple times.

This is bad for multiple reasons. First, the intended effect of this method is to stop this process. If it was already stopped, everything is well and it should handle this case gracefully. Second, using the standard ASP.NET Core test tooling, it is very much possible that this (multiple calls of StopAsync) happens. See this ASP.NET core issue for more information.

Additionally, it seems a but outdated to directly inherit from the IHostedService and implementing the boilerplate code manually, which is already provided by the standard BackgroundService class.

Thus, I propose to change this behavior by inheriting from BackgroundService and removing the boilerplate code. This solves the initial problem and also simplifies the code base.

I already prepared a PR for this.

[maartenba]

Thanks for this, @aomader ! The team is looking into your suggestion and may consider for a future release.

[damianh]

@aomader PR for fix is merged. DuendeSoftware/products#2345 . Planned for 7.4.6 release.

[aomader]

Nice, thank you. 👍

[damianh]

Package is published.