Merge pull request #689

Remove .md from links using ReMark plugin

Author: maartenba

.idea/compiler.xml

@@ -7,7 +7,7 @@ You will need Node 22+ installed on your operating system and in the PATH.
 * Run `npm install` to restore all dependencies.
 * Use `npm run dev` to run the documentation site locally.
 
-Alternatively in VS Code, GitHub Codespaces or WebStorm, you can use the devcontainer to get a development environment set up.
+Alternatively in VS Code, GitHub Codespaces, or WebStorm, you can use the devcontainer to get a development environment set up.
 
 ## Project Structure
 
@@ -39,6 +39,55 @@ Content can be authored in Markdown, in a `.md` or `.mdx` file. The Starlight do
 * [Authoring Content in Markdown](https://starlight.astro.build/guides/authoring-content/)
 * [Using Components](https://starlight.astro.build/components/using-components/) (only in `.mdx`)
 
+Use a spell checker like [Grazie](https://www.jetbrains.com/grazie/) or [Grammarly](https://www.grammarly.com/) to check your content for spelling and grammar errors.
+WebStorm has Grazie as a built-in spell checker and grammar checker, and supports a good default writing style.
+
+### Writing Style
+
+* Use the active voice. For example, use "Enable" instead of "Enabled" or "Enabling".
+* Use the second person ("you" not "I" or "we"). "You" is the reader of the documentation. "We" is Duende Software.
+* Use sentence case in text. Titles use Title Case.
+* Use the Oxford comma.
+* Avoid words like "very", "simple", "easy", ...
+* "As well as" can be written as "and".
+* Avoid flowery language.
+* When using acronyms, use the full form with parentheses the first time you use it. For example, use "Multi-Factor Authentication (MFA)" instead of "MFA".
+
+### Linking Rules
+
+* Always prefer linking internally over linking externally. For example, when you talk about data protection, prefer an internal link over a link to external sites.
+* When linking to external content, consider writing one or two sentences about the context and what the reader will learn on the linked page.
+* When linking other pages, use a path that starts at the content root, like `/identityserver/troubleshooting.md`. Use the `.md(x)` file extension - Starlight will update the link to the correct format on build.
+* When linking to external resources, use the full URL using HTTPS.
+* You can link to header anchors using the `#` symbol, for example `[multiple authentication methods](/identityserver/ui/federation.md#multiple-authentication-methods-for-users)`.
+* Link relevant text. Prefer `learn more about [improving the sign-in experience]` over `click [here] to learn more`.
+* Run `npm run linkchecker` to validate all links (note this will ignore links to GitHub because of rate limits in place).
+
+### Code Block Style
+
+* Use triple backticks to enclose code blocks.
+* Use a language identifier to specify the language (e.g. `csharp`, `bash`, `json`, `html`, `javascript`, `typescript`, `css`, `json`)
+* Add a title to the code block. You can do this adding the title as a comment in the first line of the code block (e.g. `// Program.cs`).
+* Use [expressive code features](https://starlight.astro.build/guides/authoring-content/#expressive-code-features).
+* Readers should not need to scroll horizontally to read a code example. Simplify and condense the code as much as possible.
+* If writing C#, use the latest syntax — including top-level statements, collection expressions, ...
+* Make sure examples are runnable and complete. The goal is "Copy-paste from docs". Include namespaces, a result, and other prerequisites that are not obvious to someone new to the code.
+* Inline comments can be used to explain essential parts of the code. Expressive code can highlight line numbers, show diffs, and more.
+* Mention NuGet packages as a `bash` code block showing how to install it (`dotnet add package ...`). Link to the NuGet Gallery.
+
+### Frontmatter Rules
+
+* Always have a `title` property to set the page title.
+* Always have a `description` property to set the page description.
+* Always have a `date` property to set the creation/significant update date for a page. Use the `YYYY-MM-DD` format.
+* Add the `sidebar` property and include the `label`. The `label` is used in the menu, and should typically be shorter than the more descriptive `title`. For example:
+    ```yaml
+    title: "Using IdentityServer As A Federation Gateway"
+    sidebar:
+      label: "Federation"
+    ```
+* In the `sidebar` property, use `order` to re-order entries in the navigation bar.
+
 ## 🧞 Commands
 
 All commands are run from the root of the project, from a terminal:

.idea/webResources.xml

@@ -1,4 +1,3 @@
-// @ts-check
 import { defineConfig, fontProviders } from "astro/config";
 import starlight from "@astrojs/starlight";
 import starlightLinksValidator from "starlight-links-validator";
@@ -10,10 +9,14 @@ import starlightHeadingBadges from "starlight-heading-badges";
 import starlightLlmsTxt from "starlight-llms-txt";
 import rehypeAstroRelativeMarkdownLinks from "astro-rehype-relative-markdown-links";
 import opengraphImages from "astro-opengraph-images";
-import { duendeOpenGraphImage } from "./src/components/duende-og-image.js";
 import rehypeExternalLinks from "rehype-external-links";
 import * as fs from "node:fs";
 
+// don't convert to path aliases, it doesn't work here
+// https://github.com/withastro/astro/issues/9782
+import { duendeOpenGraphImage } from "./src/plugins/duende-og-image.js";
+import removeMarkdownExtensions from "./src/plugins/remove-markdown-extensions.js";
+
 // https://astro.build/config
 export default defineConfig({
   site: "https://docs.duendesoftware.com",
@@ -180,6 +183,7 @@ export default defineConfig({
     }),
   ],
   markdown: {
+    remarkPlugins: [[removeMarkdownExtensions, { ignoreRelativeLinks: true }]],
     rehypePlugins: [
       [
         rehypeAstroRelativeMarkdownLinks,

README.md

@@ -25,6 +25,7 @@
   "dependencies": {
     "@astrojs/markdown-remark": "^6.3.1",
     "@astrojs/starlight": "^0.34.0",
+    "@astrojs/ts-plugin": "^1.10.4",
     "@fontsource/roboto": "^5.2.5",
     "@pasqal-io/starlight-client-mermaid": "^0.1.0",
     "@resvg/resvg-js": "^2.6.2",

astro.config.mjs

@@ -10,7 +10,7 @@ redirect_from:
 
 OpenID Connect is a protocol that allows you to authenticate users
 using a browser and involves browser-based interactions. When using this
-library you can choose between two modes: [automatic](./automatic.md) and manual.
+library you can choose between two modes: [automatic](/identitymodel-oidcclient/automatic.md) and manual.
 
 We recommend using automatic mode when possible, but sometimes you need
 to use manual mode when you want to handle browser interactions yourself.

package-lock.json

@@ -10,7 +10,7 @@ redirect_from:
   - /identityserver/v7/apis/aspnetcore/confirmation/
 ---
 
-IdentityServer can [bind tokens to clients](/identityserver/tokens/pop#proof-of-possession-styles) using either mTLS or
+IdentityServer can [bind tokens to clients](/identityserver/tokens/pop.md#proof-of-possession-styles) using either mTLS or
 DPoP, creating a `Proof-of-Possession` (PoP) access token. When one of these mechanisms is used, APIs that use those
 access tokens for authorization need to validate the binding between the client and token. This document describes how
 to perform such validation, depending on which mechanism was used to produce a PoP token.

package.json

@@ -9,7 +9,7 @@ redirect_from:
   - /identityserver/v7/ui/login/mfa/
 ---
 
-Duende IdentityServer itself doesn't implement multi-factor authentication (MFA). MFA is part of the login process in the user interface which is the [responsibility of the hosting application](../index.md). Microsoft provides some [general guidelines](https://learn.microsoft.com/en-us/aspnet/core/security/authentication/mfa) on how to enable MFA in ASP.NET Core.
+Duende IdentityServer itself doesn't implement multi-factor authentication (MFA). MFA is part of the login process in the user interface which is the [responsibility of the hosting application](/identityserver/ui/index.md). Microsoft provides some [general guidelines](https://learn.microsoft.com/en-us/aspnet/core/security/authentication/mfa) on how to enable MFA in ASP.NET Core.
 
 ## MFA Hosted In IdentityServer