feat(UI): add toggle to disable confirmation dialogs [closes #81]

Author: AndyEveritt

assets/i18n/en-GB.json

@@ -271,6 +271,7 @@
       "screen": "Screen",
       "screen_header": "Screen Settings",
       "screensaver_timeout": "Screensaver Timeout (s):",
+      "show_confirmation_dialogs": "Show Confirmation Dialogs:",
       "system_logging": "Log system messages to console (might cause lag)",
       "theme": "Theme",
       "wifi": "WiFi",

src/Storage.cpp

@@ -45,6 +45,7 @@ constexpr StorageKey<Comm::CommunicationType> ID_DUET_COMMUNICATION_TYPE = {
 constexpr StorageKey<std::chrono::milliseconds> ID_DUET_POLL_INTERVAL = {"duet:poll_interval",
 																		 DEFAULT_PRINTER_POLL_INTERVAL};
 constexpr StorageKey<speed_t> ID_DUET_BAUD_RATE = {"duet:baud_rate", DEFAULT_BAUD_RATE};
+
 /* UI */
 constexpr StorageKey<size_t> ID_THEME = {"ui:theme", std::numeric_limits<size_t>::max()};
 constexpr StorageKey<std::string_view> ID_FONT = {"ui:font", "OpenSans"};

src/Storage.h

@@ -86,6 +86,7 @@ extern const StorageKey<std::string_view> ID_DUET_PASSWORD;
 extern const StorageKey<Comm::CommunicationType> ID_DUET_COMMUNICATION_TYPE;
 extern const StorageKey<std::chrono::milliseconds> ID_DUET_POLL_INTERVAL;
 extern const StorageKey<speed_t> ID_DUET_BAUD_RATE;
+
 /* UI */
 extern const StorageKey<size_t> ID_THEME;
 extern const StorageKey<std::string_view> ID_FONT;

src/UI/Screens/Move/MoveView.cpp

@@ -70,6 +70,11 @@ namespace UI
 		m_xyControl.setDisableMotorsCallback(
 			[this]()
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->disableMotors();
+					return;
+				}
 				m_messageBox.setTitle(_("move.disable_motors_confirm.title"));
 				m_messageBox.setText(_("move.disable_motors_confirm.text"));
 				m_messageBox.setOkCallback([this]() { m_presenter->disableMotors(); });
@@ -84,6 +89,11 @@ namespace UI
 		m_xyControl.setHomeAllCallback(
 			[this]()
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->homeAll();
+					return;
+				}
 				m_messageBox.setTitle(_("move.home_all_confirm.title"));
 				m_messageBox.setText(_("move.home_all_confirm.text"));
 				m_messageBox.setOkCallback([this]() { m_presenter->homeAll(); });
@@ -92,6 +102,12 @@ namespace UI
 		m_xyControl.setHomeXYCallback(
 			[this]()
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->homeAxis('X');
+					m_presenter->homeAxis('Y');
+					return;
+				}
 				m_messageBox.setTitle(_("move.home_xy_confirm.title"));
 				m_messageBox.setText(_("move.home_xy_confirm.text"));
 				m_messageBox.setOkCallback(
@@ -105,6 +121,11 @@ namespace UI
 		m_xyControl.setHomeXCallback(
 			[this]()
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->homeAxis('X');
+					return;
+				}
 				m_messageBox.setTitle(_("move.home_generic_confirm.title", 'X'));
 				m_messageBox.setText(_("move.home_generic_confirm.text", 'X'));
 				m_messageBox.setOkCallback([this]() { m_presenter->homeAxis('X'); });
@@ -113,6 +134,11 @@ namespace UI
 		m_xyControl.setHomeYCallback(
 			[this]()
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->homeAxis('Y');
+					return;
+				}
 				m_messageBox.setTitle(_("move.home_generic_confirm.title", 'Y'));
 				m_messageBox.setText(_("move.home_generic_confirm.text", 'Y'));
 				m_messageBox.setOkCallback([this]() { m_presenter->homeAxis('Y'); });
@@ -133,6 +159,11 @@ namespace UI
 		m_zControl.setHomeCallback(
 			[this](char axis_letter)
 			{
+				if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+				{
+					m_presenter->homeAxis(axis_letter);
+					return;
+				}
 				m_messageBox.setTitle(_("move.home_generic_confirm.title", axis_letter));
 				m_messageBox.setText(_("move.home_generic_confirm.text", axis_letter));
 				m_messageBox.setOkCallback([this, axis_letter]() { m_presenter->homeAxis(axis_letter); });
@@ -415,6 +446,11 @@ namespace UI
 				control->setHomeCallback(
 					[this](char axis_letter)
 					{
+						if (!StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS))
+						{
+							m_presenter->homeAxis(axis_letter);
+							return;
+						}
 						m_messageBox.setTitle(_("move.home_generic_confirm.title", axis_letter));
 						m_messageBox.setText(_("move.home_generic_confirm.text", axis_letter));
 						m_messageBox.setOkCallback([this, axis_letter]() { m_presenter->homeAxis(axis_letter); });

src/UI/Screens/Settings/SettingsView.cpp

@@ -197,6 +197,12 @@ namespace UI
 			{ StorageHelper::setData(ID_SCREENSAVER_TIMEOUT, std::chrono::seconds(static_cast<int32_t>(value))); });
 		m_screensaverTimeout.setOutOfRangeMode(Slider::OutOfRange::UPPER);
 
+		/* Show Confirmation Dialogs */
+		createRow(_("settings.show_confirmation_dialogs"), m_showConfirmationDialogs);
+		m_showConfirmationDialogs.setCheckedCallback(
+			[](bool checked) { StorageHelper::setData(ID_SHOW_CONFIRMATION_DIALOGS, checked); });
+		m_showConfirmationDialogs.setChecked(StorageHelper::getData(ID_SHOW_CONFIRMATION_DIALOGS));
+
 		/* Notifications */
 		createHeader(_("settings.headers.notifications"));
 

src/UI/Screens/Settings/SettingsView.h

@@ -54,6 +54,7 @@ namespace UI
 		DropdownMenu m_language{"language", getRoot()};
 		Slider m_brightness{"brightness", getRoot()};
 		Slider m_screensaverTimeout{"screensaver_timeout", getRoot()};
+		LvSettingsToggle m_showConfirmationDialogs{"show_confirmation_dialogs", getRoot()};
 
 		/* Notifications */
 		LvSettingsToggle m_displayConnectedMessage{"display_connected_message", getRoot()};