Skip to content

Commit 62fa9af

Browse files
committed
Don't hardcode psql connection string
1 parent 14e96ac commit 62fa9af

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

build.gradle.kts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,11 @@ kotlinter {
264264
reporters = arrayOf("checkstyle", "plain")
265265
experimentalRules = true
266266
disabledRules = arrayOf(
267-
"no-wildcard-imports", "experimental:indent",
268-
"experimental:argument-list-wrapping",
267+
"filename", "no-wildcard-imports", "experimental:indent",
268+
"argument-list-wrapping",
269269
"experimental:spacing-between-declarations-with-annotations",
270-
"experimental:spacing-between-declarations-with-comments"
270+
"experimental:spacing-between-declarations-with-comments",
271+
"experimental:comment-wrapping"
271272
)
272273
}
273274

src/main/java/ml/duncte123/skybot/Variables.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public DuncteApis getApis() {
178178
public AbstractDatabase getDatabase() {
179179
if (this.database == null) {
180180
if ("psql".equals(this.config.useDatabase)) {
181-
this.database = new PostgreDatabase();
181+
this.database = new PostgreDatabase(this.config.jdbcURI);
182182
} else if ("web".equals(this.config.useDatabase)) {
183183
this.database = new WebDatabase(this.getApis(), this.getJackson());
184184
} else {

src/main/java/ml/duncte123/skybot/objects/config/DunctebotConfig.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,16 @@ public class DunctebotConfig {
2929
public final Sentry sentry;
3030
public final Websocket websocket;
3131
public final String useDatabase;
32+
public final String jdbcURI;
3233

33-
public DunctebotConfig(Discord discord, Apis apis, Lavalink lavalink, Sentry sentry, Websocket websocket, String useDatabase) {
34+
public DunctebotConfig(Discord discord, Apis apis, Lavalink lavalink, Sentry sentry, Websocket websocket, String useDatabase, String jdbcURI) {
3435
this.discord = discord;
3536
this.apis = apis;
3637
this.lavalink = lavalink;
3738
this.sentry = sentry;
3839
this.websocket = websocket;
3940
this.useDatabase = useDatabase;
41+
this.jdbcURI = jdbcURI;
4042
}
4143

4244
public static class Discord {
@@ -223,7 +225,8 @@ public static DunctebotConfig fromEnv() {
223225
lavalink,
224226
sentry,
225227
websocket,
226-
System.getenv("USE_DATABASE")
228+
System.getenv("USE_DATABASE"),
229+
System.getenv("JDBC_URI")
227230
);
228231
}
229232
}

src/main/kotlin/ml/duncte123/skybot/database/PostgreDatabase.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import java.sql.SQLException
4141
import java.sql.Types
4242
import java.time.OffsetDateTime
4343

44-
class PostgreDatabase : AbstractDatabase() {
44+
class PostgreDatabase(jdbcURI: String) : AbstractDatabase() {
4545
private val ds: HikariDataSource
4646
private val connection: Connection
4747
get() {
@@ -50,11 +50,10 @@ class PostgreDatabase : AbstractDatabase() {
5050

5151
init {
5252
val config = HikariConfig()
53-
// TODO: unhardcode
54-
config.jdbcUrl = "jdbc:pgsql://localhost:5432/skybot?user=skybot&password=password" // &ssl=true
5553

56-
this.ds = HikariDataSource(config)
54+
config.jdbcUrl = jdbcURI // &ssl=true
5755

56+
this.ds = HikariDataSource(config)
5857
this.connection.use { con ->
5958
Liquibase(
6059
"/dbchangelog.xml",

0 commit comments

Comments
 (0)