Skip to content

Commit 92fe677

Browse files
committed
Remove youtube cache
1 parent 820dd33 commit 92fe677

File tree

7 files changed

+5
-88
lines changed

7 files changed

+5
-88
lines changed

build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ repositories {
5858
maven("https://m2.duncte123.dev/releases")
5959
maven("https://m2.duncte123.dev/snapshots")
6060
maven("https://m2.dv8tion.net/releases")
61-
maven("https://maven.notfab.net/Hosted")
6261
maven("https://jitpack.io")
6362
}
6463

@@ -95,9 +94,6 @@ dependencies {
9594
//Spotify API
9695
implementation(group = "se.michaelthelin.spotify", name = "spotify-web-api-java", version = "7.2.0")
9796

98-
// Youtube Cache
99-
implementation(group = "net.notfab.cache", name = "cache-client", version = "2.2.1")
100-
10197
// Youtube api
10298
implementation(group = "com.google.apis", name = "google-api-services-youtube", version = "v3-rev222-1.25.0")
10399

src/main/java/ml/duncte123/skybot/Variables.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
import net.jodah.expiringmap.EntryLoader;
4343
import net.jodah.expiringmap.ExpirationPolicy;
4444
import net.jodah.expiringmap.ExpiringMap;
45-
import net.notfab.caching.client.CacheClient;
4645

4746
import java.util.concurrent.ExecutionException;
4847
import java.util.concurrent.Executors;
@@ -67,7 +66,6 @@ public final class Variables {
6766
private final Alexflipnote alexflipnote;
6867
private final WeebApi weebApi;
6968
private final DunctebotConfig config;
70-
private final CacheClient youtubeCache;
7169
private AbstractDatabase database;
7270
@SuppressWarnings("PMD.UseConcurrentHashMap")
7371
private final DBMap<Long, GuildSetting> guildSettingsCache = new DBMap<>(ExpiringMap.builder()
@@ -90,16 +88,6 @@ public final class Variables {
9088
this.apis = new DuncteApis("Bot " + this.config.discord.token, this.mapper);
9189
this.commandManager = new CommandManager(this);
9290
this.blargBot = new BlargBot(this.config.apis.blargbot, this.mapper);
93-
94-
// Audio Utils needs the client
95-
final var ytcfg = this.config.apis.youtubeCache;
96-
this.youtubeCache = new CacheClient(ytcfg.endpoint, ytcfg.token, Executors.newCachedThreadPool((r) -> {
97-
final Thread thread = new Thread(r, "Cache-Thread");
98-
thread.setDaemon(true);
99-
100-
return thread;
101-
}));
102-
10391
this.audioUtils = new AudioUtils(this.config.apis, this);
10492
this.alexflipnote = new Alexflipnote(this.mapper, this.config.apis.alexflipnote);
10593
this.weebApi = new WeebApiBuilder(TokenType.WOLKETOKENS)
@@ -151,10 +139,6 @@ public String getGoogleBaseUrl() {
151139
return this.googleBaseUrl;
152140
}
153141

154-
public CacheClient getYoutubeCache() {
155-
return this.youtubeCache;
156-
}
157-
158142
public WeebApi getWeebApi() {
159143
return this.weebApi;
160144
}

src/main/java/ml/duncte123/skybot/audio/AudioLoader.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.sedmelluq.discord.lavaplayer.track.AudioTrack;
2626
import com.sedmelluq.discord.lavaplayer.track.AudioTrackInfo;
2727
import ml.duncte123.skybot.CommandManager;
28-
import ml.duncte123.skybot.audio.sourcemanagers.youtube.YoutubeAudioSourceManagerOverride;
2928
import ml.duncte123.skybot.commands.music.RadioCommand;
3029
import ml.duncte123.skybot.exceptions.LimitReachedException;
3130
import ml.duncte123.skybot.extensions.AudioTrackKt;
@@ -64,8 +63,6 @@ public AudioLoader(CommandContext ctx, GuildMusicManager mng, boolean announce,
6463

6564
@Override
6665
public void trackLoaded(AudioTrack track) {
67-
addToIndex(track);
68-
6966
track.setUserData(new TrackUserData(this.requester));
7067

7168
final TrackScheduler scheduler = this.mng.getScheduler();
@@ -125,7 +122,6 @@ public void playlistLoaded(AudioPlaylist playlist) {
125122
}
126123

127124
final List<AudioTrack> tracks = tracksRaw.stream().peek((track) -> {
128-
addToIndex(track);
129125
// don't store this externally since it will cause issues
130126
track.setUserData(new TrackUserData(this.requester));
131127
}).toList();
@@ -196,12 +192,6 @@ public void loadFailed(FriendlyException exception) {
196192

197193
}
198194

199-
private void addToIndex(AudioTrack track) {
200-
if (!(track instanceof YoutubeAudioSourceManagerOverride.DoNotCache)) {
201-
this.ctx.getYoutubeCache().addToIndex(track);
202-
}
203-
}
204-
205195
private static String getSteamTitle(AudioTrack track, String rawTitle, CommandManager commandManager) {
206196
String title = rawTitle;
207197

src/main/java/ml/duncte123/skybot/audio/sourcemanagers/youtube/YoutubeApiSearchProvider.java

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@
2525
import com.sedmelluq.discord.lavaplayer.track.AudioItem;
2626
import com.sedmelluq.discord.lavaplayer.track.AudioTrack;
2727
import com.sedmelluq.discord.lavaplayer.track.AudioTrackInfo;
28-
import com.sedmelluq.discord.lavaplayer.track.info.AudioTrackInfoBuilder;
29-
import ml.duncte123.skybot.audio.sourcemanagers.youtube.YoutubeAudioSourceManagerOverride.DoNotCache;
30-
import net.notfab.caching.client.CacheClient;
31-
import net.notfab.caching.shared.CacheResponse;
32-
import net.notfab.caching.shared.Track;
33-
3428
import java.io.IOException;
3529
import java.util.List;
3630
import java.util.function.Function;
@@ -39,11 +33,9 @@
3933

4034
public class YoutubeApiSearchProvider implements YoutubeSearchResultLoader {
4135
private final String apiKey;
42-
private final CacheClient cacheClient;
4336

44-
public YoutubeApiSearchProvider(String apiKey, CacheClient cacheClient) {
37+
public YoutubeApiSearchProvider(String apiKey) {
4538
this.apiKey = apiKey;
46-
this.cacheClient = cacheClient;
4739
}
4840

4941
@Override
@@ -65,23 +57,8 @@ private AudioItem searchYoutubeAPI(String query, Function<AudioTrackInfo, AudioT
6557
}
6658

6759
final String videoId = searchResults.get(0).getId().getVideoId();
68-
final Track fromCache = this.getTrackFromCache(videoId);
69-
70-
if (fromCache != null) {
71-
final AudioTrackInfo info = AudioTrackInfoBuilder.empty()
72-
.setTitle(fromCache.getTitle())
73-
.setAuthor(fromCache.getAuthor())
74-
.setLength(fromCache.getLength())
75-
.setIdentifier(fromCache.getId())
76-
.setIsStream(fromCache.isStream())
77-
.setUri(fromCache.toURL())
78-
.build();
79-
80-
return new DoNotCache(trackFactory.apply(info));
81-
}
82-
8360
final AudioTrackInfo info = videoToTrackInfo(
84-
getVideoById(searchResults.get(0).getId().getVideoId(), this.apiKey)
61+
getVideoById(videoId, this.apiKey)
8562
);
8663

8764
return trackFactory.apply(info);
@@ -90,14 +67,4 @@ private AudioItem searchYoutubeAPI(String query, Function<AudioTrackInfo, AudioT
9067
throw ExceptionTools.wrapUnfriendlyExceptions(e);
9168
}
9269
}
93-
94-
private Track getTrackFromCache(String videoId) {
95-
final CacheResponse found = this.cacheClient.get(videoId);
96-
97-
if (found.isFailure()) {
98-
return null;
99-
}
100-
101-
return found.getTrack();
102-
}
10370
}

src/main/java/ml/duncte123/skybot/audio/sourcemanagers/youtube/YoutubeAudioSourceManagerOverride.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,44 +22,32 @@
2222
import com.sedmelluq.discord.lavaplayer.tools.FriendlyException;
2323
import com.sedmelluq.discord.lavaplayer.track.AudioItem;
2424
import com.sedmelluq.discord.lavaplayer.track.AudioTrack;
25-
import net.notfab.caching.client.CacheClient;
26-
import net.notfab.caching.shared.CacheResponse;
2725

2826
import java.io.IOException;
2927

3028
import static ml.duncte123.skybot.utils.YoutubeUtils.getVideoById;
3129
import static ml.duncte123.skybot.utils.YoutubeUtils.videoToTrack;
3230

3331
public class YoutubeAudioSourceManagerOverride extends YoutubeAudioSourceManager {
34-
35-
private final CacheClient cacheClient;
3632
private final String ytApiKey;
3733

38-
public YoutubeAudioSourceManagerOverride(CacheClient cacheClient, String ytApiKey) {
34+
public YoutubeAudioSourceManagerOverride(String ytApiKey) {
3935
super(
4036
true,
4137
new DefaultYoutubeTrackDetailsLoader(),
42-
new YoutubeApiSearchProvider(ytApiKey, cacheClient),
38+
new YoutubeApiSearchProvider(ytApiKey),
4339
new YoutubeSearchMusicProvider(),
4440
new YoutubeSignatureCipherManager(),
4541
new YoutubeApiPlaylistLoader(ytApiKey),
4642
new DefaultYoutubeLinkRouter(),
4743
new YoutubeMixProvider()
4844
);
4945

50-
this.cacheClient = cacheClient;
5146
this.ytApiKey = ytApiKey;
5247
}
5348

5449
@Override
5550
public AudioItem loadTrackWithVideoId(String videoId, boolean mustExist) {
56-
final CacheResponse cacheResponse = this.cacheClient.get(videoId);
57-
58-
if (!cacheResponse.failure && cacheResponse.getTrack() != null) {
59-
final AudioTrack track = cacheResponse.getTrack().toAudioTrack(this);
60-
return new DoNotCache(track);
61-
}
62-
6351
if (mustExist) {
6452
return getFromYoutubeApi(videoId);
6553
}

src/main/java/ml/duncte123/skybot/objects/command/CommandContext.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import net.dv8tion.jda.api.entities.Member;
3636
import net.dv8tion.jda.api.events.interaction.SelectionMenuEvent;
3737
import net.dv8tion.jda.api.events.message.guild.GuildMessageReceivedEvent;
38-
import net.notfab.caching.client.CacheClient;
3938

4039
import java.util.Collections;
4140
import java.util.List;
@@ -69,10 +68,6 @@ public Variables getVariables() {
6968
return this.variables;
7069
}
7170

72-
public CacheClient getYoutubeCache() {
73-
return this.variables.getYoutubeCache();
74-
}
75-
7671
public CommandManager getCommandManager() {
7772
return this.variables.getCommandManager();
7873
}

src/main/java/ml/duncte123/skybot/utils/AudioUtils.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ public AudioUtils(DunctebotConfig.Apis config, Variables variables) {
5454
playerManager = new DefaultAudioPlayerManager();
5555
//playerManager.enableGcMonitoring();
5656

57-
final YoutubeAudioSourceManagerOverride sourceManager = new YoutubeAudioSourceManagerOverride(
58-
variables.getYoutubeCache(),
59-
config.googl
60-
);
57+
final YoutubeAudioSourceManagerOverride sourceManager = new YoutubeAudioSourceManagerOverride(config.googl);
6158

6259
playerManager.registerSourceManager(new SpotifyAudioSourceManager(sourceManager, config));
6360
playerManager.registerSourceManager(sourceManager);

0 commit comments

Comments
 (0)