Process feedback

Author: bramr94

src/FilamentDeveloperLoginsServiceProvider.php

@@ -30,7 +30,7 @@ public function configurePackage(Package $package): void
     public function packageRegistered(): void
     {
         $this->app->singleton(FilamentDevelopersLogin::class);
-        $this->app->alias(FilamentDevelopersLogin::class, 'filament-developers-login');
+        $this->app->bind('filament-developers-login', FilamentDevelopersLogin::class);
     }
 
     public function packageBooted(): void

src/Http/Controllers/DeveloperLoginsController.php

@@ -7,7 +7,6 @@
 use DutchCodingCompany\FilamentDeveloperLogins\FilamentDeveloperLoginsPlugin;
 use DutchCodingCompany\FilamentDeveloperLogins\Http\Requests\LoginAsRequest;
 use Filament\Facades\Filament;
-use Filament\Panel;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Routing\Controller;
 use Livewire\Features\SupportRedirects\Redirector;
@@ -19,23 +18,10 @@ class DeveloperLoginsController extends Controller
      */
     public function loginAs(LoginAsRequest $request): RedirectResponse | Redirector
     {
-        [$panel, $plugin] = $this->initiate($request);
-
+        $panel = Filament::getPanel($request->validated('panel_id'));
+        $plugin = FilamentDeveloperLoginsPlugin::getById($request->validated('panel_id'));
         $credentials = $request->validated('credentials');
 
         return FilamentDevelopersLogin::login($panel, $plugin, $credentials);
     }
-
-    /**
-     * @return array{Panel, FilamentDeveloperLoginsPlugin}
-     *
-     * @throws ImplementationException
-     */
-    protected function initiate(LoginAsRequest $request): array
-    {
-        return [
-            Filament::getPanel($request->validated('panel_id')),
-            FilamentDeveloperLoginsPlugin::getById($request->validated('panel_id')),
-        ];
-    }
 }

src/Http/Requests/LoginAsRequest.php

@@ -2,16 +2,11 @@
 
 namespace DutchCodingCompany\FilamentDeveloperLogins\Http\Requests;
 
-use DutchCodingCompany\FilamentDeveloperLogins\Facades\FilamentDevelopersLogin;
 use DutchCodingCompany\FilamentDeveloperLogins\FilamentDeveloperLoginsPlugin;
-use Filament\Facades\Filament;
 use Illuminate\Foundation\Http\FormRequest;
-use Illuminate\Validation\Rule;
 
 class LoginAsRequest extends FormRequest
 {
-    protected ?FilamentDeveloperLoginsPlugin $plugin = null;
-
     /**
      * @return array<string, mixed>
      */