fixed an issue where menu item was attempting to render in panels where the plugin was not enabled

Author: ainesophaur

src/FilamentDeveloperLoginsServiceProvider.php

@@ -4,6 +4,7 @@
 
 use DutchCodingCompany\FilamentDeveloperLogins\Livewire\MenuLogins;
 use DutchCodingCompany\FilamentDeveloperLogins\View\Components\DeveloperLogins;
+use Filament\Panel;
 use Filament\Facades\Filament;
 use Filament\Support\Concerns\EvaluatesClosures;
 use Filament\Support\Facades\FilamentView;
@@ -45,7 +46,8 @@ public function packageBooted(): void
     protected static function registerRenderHooks(): void
     {
         $panel = Filament::getCurrentPanel();
-        if (is_null($panel) || ! $panel->hasPlugin('filament-developer-logins')) {
+
+        if(! self::enabledForPanel($panel)) {
             return;
         }
 
@@ -55,7 +57,8 @@ protected static function registerRenderHooks(): void
         FilamentView::registerRenderHook(
             PanelsRenderHook::AUTH_LOGIN_FORM_AFTER,
             static function () use ($plugin) : ?string {
-                if (! $plugin->getEnabled()) {
+
+                if (! $plugin->getEnabled() || ! self::enabledForPanel(Filament::getCurrentPanel())) {
                     return null;
                 }
 
@@ -66,12 +69,17 @@ static function () use ($plugin) : ?string {
         FilamentView::registerRenderHook(
             PanelsRenderHook::GLOBAL_SEARCH_AFTER,
             static function () use ($plugin) : ?string {
-                if (! $plugin->getEnabled() || ! $plugin->getSwitchable()) {
+                if (! $plugin->getEnabled() || ! $plugin->getSwitchable() || ! self::enabledForPanel(Filament::getCurrentPanel())) {
                     return null;
                 }
 
                 return Blade::render('@livewire(\'menu-logins\')');
             },
         );
     }
+
+    protected static function enabledForPanel(?Panel $panel)
+    {
+        return ! is_null($panel) && $panel->hasPlugin('filament-developer-logins');
+    }
 }

tests/Feature/MenuLoginsTest.php

@@ -8,6 +8,7 @@
 use DutchCodingCompany\FilamentDeveloperLogins\Tests\TestCase;
 use Filament\Facades\Filament;
 use Filament\Pages\Dashboard;
+use Filament\Panel;
 use Livewire\Livewire;
 
 final class MenuLoginsTest extends TestCase
@@ -80,4 +81,39 @@ public function test_forbidden_is_returned_when_enabled_or_switchable_is_false()
             ->call('loginAs', '[email protected]')
             ->assertForbidden();
     }
+
+    public function test_component_is_only_rendered_in_panel_with_plugin(): void
+    {
+
+        $user = TestUser::factory()->create();
+
+        $this->actingAs($user)
+            ->get(Dashboard::getUrl(panel: $this->panelName))
+            ->assertSuccessful()
+            ->assertSeeLivewire(MenuLogins::class);
+
+
+        $this->actingAs($user)
+            ->get(Dashboard::getUrl(panel: $this->panelName . '-other' ))
+            ->assertSuccessful()
+            ->assertDontSeeLivewire(MenuLogins::class);
+    }
+
+    protected function registerTestPanel(): void
+    {
+        parent::registerTestPanel();
+        Filament::registerPanel(fn() => Panel::make()
+            ->darkMode(false)
+            ->id($this->panelName . '-other')
+            ->path($this->panelName  . '-other')
+            ->login()
+            ->pages([
+                Dashboard::class,
+            ])
+            ->plugins([
+            ]),
+        );
+    }
+
+
 }