Update Overflow and negative check

Author: xiaojun

core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

@@ -3227,18 +3227,30 @@ public static ByteString bitNot(ByteString b) {
     return new ByteString(result);
   }
   public static int leftShift(int a, int b) {
+    if (b < 0) {
+      throw new IllegalArgumentException("Shift count must be non-negative");
+    }
     return a << b;
   }
 
   public static long leftShift(long a, int b) {
+    if (b < 0) {
+      throw new IllegalArgumentException("Shift count must be non-negative");
+    }
     return a << b;
   }
 
   public static long leftShift(int a, long b) {
+    if (b < 0) {
+      throw new IllegalArgumentException("Shift count must be non-negative");
+    }
     return (long) a << b;
   }
 
   public static long leftShift(Long a, Long b) {
+    if (b < 0) {
+      throw new IllegalArgumentException("Shift count must be non-negative");
+    }
     return a << b;
   }
 

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

@@ -16313,6 +16313,7 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) {
     assertEquals(2, call.getOperandList().size());
   }
 
+
   @Test void testLeftShiftScalarFunc() {
     final SqlOperatorFixture f = fixture();
     f.setFor(SqlStdOperatorTable.LEFTSHIFT_OPERATOR, VmName.EXPAND);
@@ -16328,7 +16329,6 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) {
     f.checkScalar("-5 << 2", "-20", "INTEGER NOT NULL");
     f.checkScalar("-5 << 3", "-40", "INTEGER NOT NULL");
     f.checkScalar("CAST(-5 AS TINYINT) << CAST(2 AS TINYINT)", "-20", "TINYINT NOT NULL");
-
     // Verify return types
     f.checkType("CAST(2 AS TINYINT) << CAST(3 AS TINYINT)", "TINYINT NOT NULL");
     f.checkType("CAST(2 AS SMALLINT) << CAST(3 AS SMALLINT)", "SMALLINT NOT NULL");
@@ -16342,6 +16342,11 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) {
     f.checkNull("CAST(NULL AS INTEGER) << 5");
     f.checkNull("10 << CAST(NULL AS INTEGER)");
     f.checkNull("CAST(NULL AS INTEGER) << CAST(NULL AS INTEGER)");
+    f.checkScalar("1 << 64", "1", "INTEGER NOT NULL"); // INTEGER << shift: effective shift is shift % 32. 64 % 32 = 0.
+    f.checkScalar("CAST(1 AS BIGINT) << 64", "1", "BIGINT NOT NULL"); // BIGINT << shift: effective shift is shift % 64. 64 % 64 = 0.
+    f.checkScalar("CAST(1 AS BIGINT) << 65", "2", "BIGINT NOT NULL"); // BIGINT << shift: effective shift is shift % 64. 65 % 64 = 1.
+    f.checkFails("1 << -2 ",
+        "Shift count must be non-negative", true);
   }
 
   @Test void testBitAndScalarFunc() {