Skip to content

Commit 1b83355

Browse files
committed
Respond to review comments
1 parent 47270d1 commit 1b83355

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,9 @@ def _get_logger(self, extension: _AwsSdkExtension):
199199
"""This is a multiplexer in order to have a logger per extension"""
200200

201201
instrumentation_name = self._get_instrumentation_name(extension)
202-
if self._loggers.get(instrumentation_name):
203-
return self._loggers.get(instrumentation_name)
202+
instrumentation_logger = self._loggers.get(instrumentation_name)
203+
if instrumentation_logger:
204+
return instrumentation_logger
204205

205206
schema_version = extension.event_logger_schema_version()
206207
self._loggers[instrumentation_name] = get_logger(

instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2943,7 +2943,6 @@ def test_invoke_model_with_response_stream_handles_stream_error(
29432943
logs = log_exporter.get_finished_logs()
29442944
assert len(logs) == 1
29452945
user_content = {"content": [{"text": "Say this is a test"}]}
2946-
print(logs[0].log_record)
29472946
assert_message_in_logs(logs[0], "gen_ai.user.message", user_content, span)
29482947

29492948

0 commit comments

Comments
 (0)