Skip to content

Commit 89b01b3

Browse files
committed
initial commit removing events from genai stuff
1 parent c4347e0 commit 89b01b3

File tree

4 files changed

+16
-23
lines changed

4 files changed

+16
-23
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/instrumentor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
from typing import Any, Collection, Optional
1616

17-
from opentelemetry._events import get_event_logger_provider
17+
from opentelemetry._logs import get_logger_provider
1818
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
1919
from opentelemetry.metrics import get_meter_provider
2020
from opentelemetry.trace import get_tracer_provider
@@ -49,13 +49,13 @@ def _instrument(self, **kwargs: Any):
4949
tracer_provider = (
5050
kwargs.get("tracer_provider") or get_tracer_provider()
5151
)
52-
event_logger_provider = (
53-
kwargs.get("event_logger_provider") or get_event_logger_provider()
52+
logger_provider = (
53+
kwargs.get("logger_provider") or get_logger_provider()
5454
)
5555
meter_provider = kwargs.get("meter_provider") or get_meter_provider()
5656
otel_wrapper = OTelWrapper.from_providers(
5757
tracer_provider=tracer_provider,
58-
event_logger_provider=event_logger_provider,
58+
logger_provider=logger_provider,
5959
meter_provider=meter_provider,
6060
)
6161
self._generate_content_snapshot = instrument_generate_content(

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/otel_wrapper.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import google.genai
1818

19-
from opentelemetry._events import Event
19+
from opentelemetry._logs import LogRecord
2020
from opentelemetry.semconv._incubating.metrics import gen_ai_metrics
2121
from opentelemetry.semconv.schemas import Schemas
2222

@@ -36,9 +36,9 @@
3636

3737

3838
class OTelWrapper:
39-
def __init__(self, tracer, event_logger, meter):
39+
def __init__(self, tracer, logger_provider, meter):
4040
self._tracer = tracer
41-
self._event_logger = event_logger
41+
self._logger_provider = logger_provider
4242
self._meter = meter
4343
self._operation_duration_metric = (
4444
gen_ai_metrics.create_gen_ai_client_operation_duration(meter)
@@ -48,12 +48,12 @@ def __init__(self, tracer, event_logger, meter):
4848
)
4949

5050
@staticmethod
51-
def from_providers(tracer_provider, event_logger_provider, meter_provider):
51+
def from_providers(tracer_provider, logger_provider, meter_provider):
5252
return OTelWrapper(
5353
tracer_provider.get_tracer(
5454
_SCOPE_NAME, _LIBRARY_VERSION, _SCHEMA_URL, _SCOPE_ATTRIBUTES
5555
),
56-
event_logger_provider.get_event_logger(
56+
logger_provider.get_logger(
5757
_SCOPE_NAME, _LIBRARY_VERSION, _SCHEMA_URL, _SCOPE_ATTRIBUTES
5858
),
5959
meter=meter_provider.get_meter(
@@ -88,5 +88,5 @@ def log_response_content(self, attributes, body):
8888
self._log_event(event_name, attributes, body)
8989

9090
def _log_event(self, event_name, attributes, body):
91-
event = Event(event_name, body=body, attributes=attributes)
92-
self._event_logger.emit(event)
91+
event = LogRecord(event_name=event_name, body=body, attributes=attributes)
92+
self._logger_provider.emit(event)

instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/common/otel_mocker.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,15 @@
1313
# limitations under the License.
1414

1515

16-
import opentelemetry._events
1716
import opentelemetry._logs._internal
1817
import opentelemetry.metrics._internal
1918
import opentelemetry.trace
20-
from opentelemetry._events import (
21-
get_event_logger_provider,
22-
set_event_logger_provider,
19+
from opentelemetry._logs import (
20+
get_logger_provider,
21+
set_logger_provider,
2322
)
2423
from opentelemetry._logs import get_logger_provider, set_logger_provider
2524
from opentelemetry.metrics import get_meter_provider, set_meter_provider
26-
from opentelemetry.sdk._events import EventLoggerProvider
2725
from opentelemetry.sdk._logs import LoggerProvider
2826
from opentelemetry.sdk._logs.export import (
2927
InMemoryLogExporter,
@@ -43,22 +41,19 @@
4341
def _bypass_otel_once():
4442
opentelemetry.trace._TRACER_PROVIDER_SET_ONCE = Once()
4543
opentelemetry._logs._internal._LOGGER_PROVIDER_SET_ONCE = Once()
46-
opentelemetry._events._EVENT_LOGGER_PROVIDER_SET_ONCE = Once()
4744
opentelemetry.metrics._internal._METER_PROVIDER_SET_ONCE = Once()
4845

4946

5047
class OTelProviderSnapshot:
5148
def __init__(self):
5249
self._tracer_provider = get_tracer_provider()
5350
self._logger_provider = get_logger_provider()
54-
self._event_logger_provider = get_event_logger_provider()
5551
self._meter_provider = get_meter_provider()
5652

5753
def restore(self):
5854
_bypass_otel_once()
5955
set_tracer_provider(self._tracer_provider)
6056
set_logger_provider(self._logger_provider)
61-
set_event_logger_provider(self._event_logger_provider)
6257
set_meter_provider(self._meter_provider)
6358

6459

@@ -219,8 +214,6 @@ def _install_logs(self):
219214
provider = LoggerProvider()
220215
provider.add_log_record_processor(SimpleLogRecordProcessor(self._logs))
221216
set_logger_provider(provider)
222-
event_provider = EventLoggerProvider(logger_provider=provider)
223-
set_event_logger_provider(event_provider)
224217

225218
def _install_metrics(self):
226219
provider = MeterProvider(metric_readers=[self._metrics])

instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/utils/test_tool_call_wrapper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
from google.genai import types as genai_types
2020

21-
from opentelemetry._events import get_event_logger_provider
21+
from opentelemetry._logs import get_logger_provider
2222
from opentelemetry.instrumentation.google_genai import (
2323
otel_wrapper,
2424
tool_call_wrapper,
@@ -35,7 +35,7 @@ def setUp(self):
3535
self._otel.install()
3636
self._otel_wrapper = otel_wrapper.OTelWrapper.from_providers(
3737
get_tracer_provider(),
38-
get_event_logger_provider(),
38+
get_logger_provider(),
3939
get_meter_provider(),
4040
)
4141

0 commit comments

Comments
 (0)