Skip to content

Commit 948053d

Browse files
committed
Use LogRecord from APi instead of Events
1 parent 0008618 commit 948053d

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock_utils.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121

2222
from botocore.eventstream import EventStream, EventStreamError
2323
from wrapt import ObjectProxy
24+
from opentelemetry.context import get_current
25+
from opentelemetry._logs import LogRecord
2426

25-
from opentelemetry.sdk._logs import LogRecord
2627
from opentelemetry.instrumentation.botocore.environment_variables import (
2728
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT,
2829
)
@@ -511,12 +512,14 @@ def message_to_event(
511512
event_name="gen_ai.tool.message",
512513
attributes=attributes,
513514
body=tool_body,
515+
context = get_current(),
514516
)
515517

516518
yield LogRecord(
517519
event_name=f"gen_ai.{role}.message",
518520
attributes=attributes,
519521
body=body if body else None,
522+
context = get_current(),
520523
)
521524

522525

@@ -620,8 +623,9 @@ def _to_body_dict(self) -> dict[str, Any]:
620623
def to_choice_event(self, **event_kwargs) -> LogRecord:
621624
attributes = {GEN_AI_SYSTEM: GenAiSystemValues.AWS_BEDROCK.value}
622625
return LogRecord(
623-
name="gen_ai.choice",
626+
event_name="gen_ai.choice",
624627
attributes=attributes,
625628
body=self._to_body_dict(),
626629
**event_kwargs,
630+
context = get_current(),
627631
)

instrumentation/opentelemetry-instrumentation-botocore/tests/bedrock_utils.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,17 +282,15 @@ def remove_none_values(body):
282282

283283
def assert_log_parent(log, span):
284284
if span:
285-
assert log.log_record.trace_id == span.get_span_context().trace_id
285+
assert log.log_record.trace_id == span.get_span_context().trace_id, "{} does not equal {}".format(span.get_span_context().trace_id, log.log_record.trace_id)
286286
assert log.log_record.span_id == span.get_span_context().span_id
287287
assert (
288288
log.log_record.trace_flags == span.get_span_context().trace_flags
289289
)
290290

291291

292292
def assert_message_in_logs(log, event_name, expected_content, parent_span):
293-
assert (
294-
log.log_record.attributes[EventAttributes.EVENT_NAME] == event_name
295-
)
293+
assert log.log_record.event_name == event_name, log.log_record.event_name
296294
assert (
297295
log.log_record.attributes[GenAIAttributes.GEN_AI_SYSTEM]
298296
== GenAIAttributes.GenAiSystemValues.AWS_BEDROCK.value

instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ def fixture_tracer_provider(span_exporter):
5858
def fixture_logger_provider(log_exporter):
5959
provider = LoggerProvider()
6060
provider.add_log_record_processor(SimpleLogRecordProcessor(log_exporter))
61-
6261
return provider
6362

6463

0 commit comments

Comments
 (0)