DYN-9829: Avoid backup-on-backup creation and disable migration tooltip when inactive (#16755)

Co-authored-by: Ashish Aggarwal <[email protected]>

Author: ivaylo-matov

src/Libraries/PythonNodeModels/Properties/Resources.Designer.cs

@@ -226,7 +226,4 @@
   <data name="PythonScriptEditorEngineRequestToUpdatedBarText" xml:space="preserve">
     <value>Please update Python Engine to PythonNet3</value>
   </data>
-  <data name="PythonScriptEditorMigrationAssistantButtonDisabledTooltip" xml:space="preserve">
-    <value>Python engine has been updated to {0}. No conversion should be necessary. If the script shows errors from old IronPython2 syntax, switch the engine back to IronPython2 to re-enable the converter.</value>
-  </data>
-</root>
+</root>

src/Libraries/PythonNodeModels/Properties/Resources.en-US.resx

@@ -227,7 +227,4 @@
   <data name="PythonScriptEditorEngineRequestToUpdatedBarText" xml:space="preserve">
     <value>Please update Python Engine to PythonNet3</value>
   </data>
-  <data name="PythonScriptEditorMigrationAssistantButtonDisabledTooltip" xml:space="preserve">
-    <value>Python engine has been updated to {0}. No conversion should be necessary. If the script shows errors from old IronPython2 syntax, switch the engine back to IronPython2 to re-enable the converter.</value>
-  </data>
 </root>

src/Libraries/PythonNodeModels/Properties/Resources.resx

@@ -301,9 +301,7 @@
                     </ComboBox>
                     <Button Style="{StaticResource IconButton}"
                             Name="MigrationAssistantButton"
-                            Click="OnMigrationAssistantClicked"
-                            ToolTipService.ShowOnDisabled="True"
-                            ToolTipService.IsEnabled="True">
+                            Click="OnMigrationAssistantClicked">
                         <Button.ToolTip>
                             <ToolTip Style="{StaticResource GenericToolTipLight}"/>
                         </Button.ToolTip>

src/Libraries/PythonNodeModelsWpf/ScriptEditorWindow.xaml

@@ -159,6 +159,15 @@ internal void Initialize(Guid workspaceGuid, Guid nodeGuid, string propName, str
             editText.SyntaxHighlighting = HighlightingLoader.Load(
                 new XmlTextReader(elem), HighlightingManager.Instance);
 
+            // Set migrator tooltip
+            var tooltip = MigrationAssistantButton.ToolTip as System.Windows.Controls.ToolTip;
+            if (tooltip != null)
+            {
+                tooltip.Content = string.Format(
+                PythonNodeModels.Properties.Resources.PythonScriptEditorMigrationAssistantButtonTooltip,
+                PythonEngineManager.PythonNet3EngineName);
+            }            
+
             // Add custom highlighting rules consistent with DesignScript
             CodeHighlightingRuleFactory.AddCommonHighlighingRules(editText, dynamoViewModel.EngineController);
 
@@ -322,18 +331,8 @@ private bool ShouldUpdate()
         private void UpdateMigrationAssistantButtonEnabled()
         {
             var enable = CachedEngine == PythonEngineManager.IronPython2EngineName;
-
             MigrationAssistantButton.IsEnabled = enable;
-
-            var tooltip = MigrationAssistantButton.ToolTip as System.Windows.Controls.ToolTip;
-            var message = enable
-                ? String.Format(
-                    PythonNodeModels.Properties.Resources.PythonScriptEditorMigrationAssistantButtonTooltip,
-                    PythonEngineManager.PythonNet3EngineName)
-                : String.Format(
-                    PythonNodeModels.Properties.Resources.PythonScriptEditorMigrationAssistantButtonDisabledTooltip,
-                    PythonEngineManager.PythonNet3EngineName);
-            tooltip.Content = message;
+            System.Windows.Controls.ToolTipService.SetIsEnabled(MigrationAssistantButton, enable);
         }
 
         #region Text Zoom in Python Editor

src/Libraries/PythonNodeModelsWpf/ScriptEditorWindow.xaml.cs

@@ -272,13 +272,13 @@ private void OnCurrentWorkspaceChanged(IWorkspaceModel workspace)
                 return;
             }
 
-            if (!string.IsNullOrEmpty(CurrentWorkspace.FileName))
+            if (IsWorkspaceEligibleForBackup(CurrentWorkspace))
             {
                 upgradeService.SaveMigrationBackup(
                     CurrentWorkspace,
                     CurrentWorkspace.FileName,
                     PythonEngineManager.CPython3EngineName);
-            }            
+            }
 
             if (CurrentWorkspace is HomeWorkspaceModel hws)
             {
@@ -602,5 +602,21 @@ private void RecomputeEngineFlags()
             hasCPython3Engine = PythonEngineManager.Instance.AvailableEngines
                 .Any(e => e.Name == PythonEngineManager.CPython3EngineName);
         }
+
+        private bool IsWorkspaceEligibleForBackup(WorkspaceModel workspace)
+        {
+            if ( workspace == null) return false;
+
+            var filePath = workspace.FileName;
+            if (string.IsNullOrWhiteSpace(filePath)) return false;
+
+            var backupDir = LoadedParams?.StartupParams?.PathManager?.BackupDirectory;
+            if (backupDir == null) return false;
+
+            var workspaceDir = System.IO.Path.GetDirectoryName(filePath);
+            if (workspaceDir == null) return false;
+
+            return !backupDir.Equals(workspaceDir, StringComparison.OrdinalIgnoreCase);
+        }
     }
 }