Skip to content

Commit 6e7e9e7

Browse files
committed
merged 2 tests
1 parent 561d5af commit 6e7e9e7

File tree

3 files changed

+12
-38
lines changed

3 files changed

+12
-38
lines changed

.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.7.43
1+
0.7.44

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 0.7.44
2+
* Merged some D4R tests in one
3+
14
## 0.7.43
25
* Add new validations to D4R tests and add new tests for existing scripts
36
* Revert D4R version to match Dynamo Core version - temporarily

test/Libraries/RevitIntegrationTests/TagTests.cs

Lines changed: 8 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class TagTests : RevitSystemTestBase
1818
{
1919
[Test]
2020
[TestModel(@".\emptyAnnotativeView.rvt")]
21-
public void PlaceTag()
21+
public void PlaceTagWithOffset()
2222
{
2323
var model = ViewModel.Model;
2424

@@ -30,30 +30,14 @@ public void PlaceTag()
3030
RunCurrentModel();
3131

3232
var tagelement = GetPreviewValue("73d7876d-c04a-418c-8f86-2e36c44d9833");
33-
3433
Assert.AreEqual(typeof(Revit.Elements.Tag), tagelement.GetType());
3534

36-
}
37-
38-
[Test]
39-
[TestModel(@".\emptyAnnotativeView.rvt")]
40-
public void PlaceTagWithOffset()
41-
{
42-
var model = ViewModel.Model;
35+
var tagelementOffset = GetPreviewValue("022d664d-b236-4a20-a55d-72a3beba04d5");
4336

44-
string samplePath = Path.Combine(workingDirectory, @".\Annotations\Tag.dyn");
45-
string testPath = Path.GetFullPath(samplePath);
46-
47-
ViewModel.OpenCommand.Execute(testPath);
48-
49-
RunCurrentModel();
50-
var tagelement = GetPreviewValue("022d664d-b236-4a20-a55d-72a3beba04d5");
51-
52-
Assert.AreEqual(typeof(Revit.Elements.Tag), tagelement.GetType());
53-
Assert.IsTrue(((tagelement as Revit.Elements.Tag)
37+
Assert.AreEqual(typeof(Revit.Elements.Tag), tagelementOffset.GetType());
38+
Assert.IsTrue(((tagelementOffset as Revit.Elements.Tag)
5439
.InternalElement as IndependentTag)
5540
.TagHeadPosition.IsAlmostEqualTo(new XYZ(10, 25, 0)));
56-
5741
}
5842

5943
private const double Tolerance = 0.001;
@@ -100,23 +84,6 @@ public void LeaderElbow()
10084
Assert.AreEqual(headlocation.Z, leaderElbow.Z, Tolerance);
10185
}
10286

103-
[Test]
104-
[TestModel(@".\emptyAnnotativeView.rvt")]
105-
public void LeaderEndCondition()
106-
{
107-
var model = ViewModel.Model;
108-
109-
string samplePath = Path.Combine(workingDirectory, @".\Tag\CanGetSetConditionAndLocationOfLeaderEnd.dyn");
110-
string testPath = Path.GetFullPath(samplePath);
111-
112-
ViewModel.OpenCommand.Execute(testPath);
113-
114-
RunCurrentModel();
115-
var leaderEndCondition = GetPreviewValue("316f8fd5b05441cda070c36a1e122c81");
116-
117-
Assert.AreEqual("Free", leaderEndCondition);
118-
}
119-
12087
[Test]
12188
[TestModel(@".\emptyAnnotativeView.rvt")]
12289
public void LeaderEnd()
@@ -135,6 +102,10 @@ public void LeaderEnd()
135102
Assert.IsNotNull(leaderEnd1);
136103
Assert.IsNotNull(leaderEnd2);
137104
Assert.AreEqual(2, (leaderEnd2.Y - leaderEnd1.Y), Tolerance);
105+
106+
var leaderEndCondition = GetPreviewValue("316f8fd5b05441cda070c36a1e122c81");
107+
108+
Assert.AreEqual("Free", leaderEndCondition);
138109
}
139110
}
140111
}

0 commit comments

Comments
 (0)