Skip to content

Commit 52952e4

Browse files
authored
Add release notes property to response (#112)
* add release notes and compatibility matrix properties * Update GregClientTests.cs * update test * add rn to response * Update GregClientTests.cs
1 parent 33d27aa commit 52952e4

File tree

4 files changed

+37
-4
lines changed

4 files changed

+37
-4
lines changed

src/GregClient/Requests/PackageUploadRequestBody.cs

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,38 @@ public PackageUploadRequestBody()
1010
{
1111
}
1212

13+
public PackageUploadRequestBody(string name, string version, string description,
14+
IEnumerable<string> keywords, string license,
15+
string contents, string engine, string engineVersion,
16+
string metadata, string group, IEnumerable<PackageDependency> dependencies,
17+
string siteUrl, string repositoryUrl, bool containsBinaries,
18+
IEnumerable<string> nodeLibraryNames, IEnumerable<string> hostDependencies,
19+
string copyright_holder, string copyright_year, string releaseNotesUrl)
20+
{
21+
this.host_dependencies = hostDependencies;
22+
this.copyright_holder = copyright_holder;
23+
this.copyright_year = copyright_year;
24+
this.release_notes_url = releaseNotesUrl;
25+
26+
this.name = name;
27+
this.version = version;
28+
this.description = description;
29+
this.keywords = keywords;
30+
this.dependencies = dependencies;
31+
this.contents = contents;
32+
this.engine = engine;
33+
this.group = group;
34+
this.engine_version = engineVersion;
35+
this.engine_metadata = metadata;
36+
this.site_url = siteUrl;
37+
this.repository_url = repositoryUrl;
38+
this.contains_binaries = containsBinaries;
39+
this.node_libraries = nodeLibraryNames;
40+
41+
this.license = license;
42+
}
43+
44+
[Obsolete("This constructor may not initiate all the properties and will be removed in a future release of PackageManagerClient.")]
1345
public PackageUploadRequestBody(string name, string version, string description,
1446
IEnumerable<string> keywords, string license,
1547
string contents, string engine, string engineVersion,

src/GregClient/Requests/PackageVersionUploadRequestBody.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public PackageVersionUploadRequestBody(string name, string version, string descr
5959
this.contains_binaries = containsBinaries;
6060
this.node_libraries = nodeLibraryNames;
6161
this.compatibility_matrix = compatibility_matrix;
62-
this.releaseNotesUrl = releaseNotesUrl;
62+
this.release_notes_url = releaseNotesUrl;
6363
}
6464

6565
/// <summary>
@@ -133,6 +133,6 @@ public PackageVersionUploadRequestBody(string name, string version, string descr
133133
public string copyright_holder { get; set; }
134134
public string copyright_year { get; set; }
135135
public string compatibility_matrix { get; set; }
136-
public string releaseNotesUrl { get; set; }
136+
public string release_notes_url { get; set; }
137137
}
138138
}

src/GregClient/Responses/Responses.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ public class PackageVersion
124124
public string latest_version_update { get; set; }
125125

126126
public string size { get; set; }
127+
public string release_notes_url { get; set; }
127128
}
128129

129130
public class User

src/GregClientTests/GregClientTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void UploadDynamoPackageVersionTest()
6060

6161
var files = new List<string>() { "../test/pedro.dyf", "../test/RootNode.dyf" };
6262
var request = new PackageVersionUpload(nv, files);
63-
Assert.That(request.RequestBody.AsJson().Equals("{\"file_hash\":null,\"name\":\"Third .NET Package\",\"version\":\"2.1.0\",\"description\":\"\",\"group\":\"group\",\"keywords\":[\"neat\",\"ok\"],\"dependencies\":[{\"name\":\"peter\",\"version\":\"0.1.0\"},{\"name\":\"stephen\",\"version\":\"0.1.0\"}],\"host_dependencies\":[],\"contents\":\"contents\",\"engine_version\":\"0.1.0\",\"engine\":\"dynamo\",\"engine_metadata\":\"metadata\",\"site_url\":\"\",\"repository_url\":\"\",\"contains_binaries\":false,\"node_libraries\":[],\"copyright_holder\":\"Dynamo Team\",\"copyright_year\":\"2021\",\"compatibility_matrix\":\"\",\"releaseNotesUrl\":\"\"}"));
63+
Assert.That(request.RequestBody.AsJson().Equals("{\"file_hash\":null,\"name\":\"Third .NET Package\",\"version\":\"2.1.0\",\"description\":\"\",\"group\":\"group\",\"keywords\":[\"neat\",\"ok\"],\"dependencies\":[{\"name\":\"peter\",\"version\":\"0.1.0\"},{\"name\":\"stephen\",\"version\":\"0.1.0\"}],\"host_dependencies\":[],\"contents\":\"contents\",\"engine_version\":\"0.1.0\",\"engine\":\"dynamo\",\"engine_metadata\":\"metadata\",\"site_url\":\"\",\"repository_url\":\"\",\"contains_binaries\":false,\"node_libraries\":[],\"copyright_holder\":\"Dynamo Team\",\"copyright_year\":\"2021\",\"compatibility_matrix\":\"\",\"release_notes_url\":\"\"}"));
6464
Console.WriteLine(request.RequestBody.AsJson());
6565
}
6666

@@ -74,7 +74,7 @@ public void UploadDynamoPackageWithHostDependencyTest()
7474

7575
var files = new List<string>() { "../test/pedro.dyf", "../test/RootNode.dyf" };
7676
var request = new PackageVersionUpload(nv, files);
77-
Assert.That(request.RequestBody.AsJson().Equals("{\"file_hash\":null,\"name\":\"Third .NET Package\",\"version\":\"2.1.0\",\"description\":\"\",\"group\":\"group\",\"keywords\":[\"Civil\"],\"dependencies\":[{\"name\":\"Ram\",\"version\":\"0.1.0\"},{\"name\":\"Ian\",\"version\":\"0.1.0\"}],\"host_dependencies\":[\"Civil3D\"],\"contents\":\"contents\",\"engine_version\":\"0.1.0\",\"engine\":\"dynamo\",\"engine_metadata\":\"metadata\",\"site_url\":\"\",\"repository_url\":\"\",\"contains_binaries\":false,\"node_libraries\":[],\"copyright_holder\":\"Dynamo Team\",\"copyright_year\":\"2021\",\"compatibility_matrix\":\"\",\"releaseNotesUrl\":\"\"}"));
77+
Assert.That(request.RequestBody.AsJson().Equals("{\"file_hash\":null,\"name\":\"Third .NET Package\",\"version\":\"2.1.0\",\"description\":\"\",\"group\":\"group\",\"keywords\":[\"Civil\"],\"dependencies\":[{\"name\":\"Ram\",\"version\":\"0.1.0\"},{\"name\":\"Ian\",\"version\":\"0.1.0\"}],\"host_dependencies\":[\"Civil3D\"],\"contents\":\"contents\",\"engine_version\":\"0.1.0\",\"engine\":\"dynamo\",\"engine_metadata\":\"metadata\",\"site_url\":\"\",\"repository_url\":\"\",\"contains_binaries\":false,\"node_libraries\":[],\"copyright_holder\":\"Dynamo Team\",\"copyright_year\":\"2021\",\"compatibility_matrix\":\"\",\"release_notes_url\":\"\"}"));
7878
Console.WriteLine(request.RequestBody.AsJson());
7979
}
8080

0 commit comments

Comments
 (0)