Merge pull request #5 from Dynamo/DYN-7448-line-number

twastvedt · GitHub Enterprise · commit 13e9457b8068 · 2024-10-09T13:55:07.000-05:00
DYN-7448: Surface line number for .net exceptions
diff --git a/DSPythonNet3/DSPythonNet3Evaluator.cs b/DSPythonNet3/DSPythonNet3Evaluator.cs
@@ -440,7 +440,7 @@ private static void InitializeEncoders()
         /// <returns>Trace back message</returns>
         private static string GetTraceBack(Exception e)
         {
-            if (e is not PythonException pythonExc)
+            if (e is not PythonException pythonExc || pythonExc.Traceback == null)
             {
                 return null;
             }

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,7 @@ private static void InitializeEncoders()`
`440`	`440`	`/// <returns>Trace back message</returns>`
`441`	`441`	`private static string GetTraceBack(Exception e)`
`442`	`442`	`{`
`443`		`- if (e is not PythonException pythonExc)`
	`443`	`+ if (e is not PythonException pythonExc \|\| pythonExc.Traceback == null)`
`444`	`444`	`{`
`445`	`445`	`return null;`
`446`	`446`	`}`