Skip to content

Commit 1e88d58

Browse files
committed
Fix wording and typos in titles for recently added specs
1 parent bf054a9 commit 1e88d58

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

spec/dynamoid/finders_spec.rb

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
end
1515
end
1616

17-
context 'one primary key provided' do
17+
context 'a single primary key provided' do
1818
context 'simple primary key' do
1919
it 'finds' do
2020
obj = klass.create
@@ -103,21 +103,21 @@
103103
end
104104
end
105105

106-
context 'when true' do
106+
context 'when false' do
107107
it 'leads to not raising exception if model not found' do
108108
expect(klass.find('blah-blah', raise_error: false)).to eq nil
109109
end
110110
end
111111
end
112112

113-
it 'uses dumped value of partition key to update item' do
113+
it 'uses dumped value of partition key' do
114114
klass = new_class(partition_key: { name: :published_on, type: :date })
115115

116116
obj = klass.create!(published_on: '2018-10-07'.to_date)
117117
expect(klass.find(obj.published_on)).to eql(obj)
118118
end
119119

120-
it 'uses dumped value of sort key to update item' do
120+
it 'uses dumped value of sort key' do
121121
klass = new_class do
122122
range :published_on, :date
123123
end
@@ -274,25 +274,23 @@
274274
end
275275
end
276276

277-
context 'when true' do
277+
context 'when false' do
278278
it 'leads to not raising exception if model not found' do
279-
obj = klass.create
280-
281-
# expect(klass.find([obj.id, 'blah-blah'], raise_error: false)).to eq [obj]
282-
expect(klass.find_all([obj.id, 'blah-blah'])).to eq [obj]
279+
obj = klass.create!
280+
expect(klass.find([obj.id, 'blah-blah'], raise_error: false)).to eq [obj]
283281
end
284282
end
285283
end
286284

287-
it 'uses dumped value of partition key to update item' do
285+
it 'uses dumped value of partition key' do
288286
klass = new_class(partition_key: { name: :published_on, type: :date })
289287
objects = (1..2).map { |i| klass.create(published_on: '2018-10-07'.to_date + i) }
290288
obj1, obj2 = objects
291289

292290
expect(klass.find([obj1.published_on, obj2.published_on])).to match_array(objects)
293291
end
294292

295-
it 'uses dumped value of sort key to update item' do
293+
it 'uses dumped value of sort key' do
296294
klass = new_class do
297295
range :published_on, :date
298296
end

spec/dynamoid/persistence_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2651,7 +2651,7 @@ def around_update_callback
26512651

26522652
context 'primary key dumping' do
26532653
context 'new model' do
2654-
it 'uses dumped value of partition key to update item' do
2654+
it 'uses dumped value of partition key to save item' do
26552655
klass = new_class(partition_key: { name: :published_on, type: :date }) do
26562656
field :title
26572657
end
@@ -2663,7 +2663,7 @@ def around_update_callback
26632663
expect(obj_loaded.title).to eq 'Some title'
26642664
end
26652665

2666-
it 'uses dumped value of sort key to update item' do
2666+
it 'uses dumped value of sort key to save item' do
26672667
klass = new_class do
26682668
range :published_on, :date
26692669
field :title
@@ -2678,7 +2678,7 @@ def around_update_callback
26782678
end
26792679

26802680
context 'persised model' do
2681-
it 'uses dumped value of partition key to update item' do
2681+
it 'uses dumped value of partition key to save item' do
26822682
klass = new_class(partition_key: { name: :published_on, type: :date }) do
26832683
field :title
26842684
end
@@ -2691,7 +2691,7 @@ def around_update_callback
26912691
expect(obj_loaded.title).to eq 'New'
26922692
end
26932693

2694-
it 'uses dumped value of sort key to update item' do
2694+
it 'uses dumped value of sort key to save item' do
26952695
klass = new_class do
26962696
range :published_on, :date
26972697
field :title

spec/dynamoid/transaction_write/save_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ def around_save_callback
690690
expect(obj_to_create).not_to be_changed
691691
end
692692

693-
it 'is marked as not persusted and is marked as changed at creation when the transaction rolled back' do
693+
it 'is marked as not persisted and is marked as changed at creation when the transaction rolled back' do
694694
obj = klass.new(name: 'Alex')
695695

696696
expect {

0 commit comments

Comments
 (0)