Raise UnknownAttribute error on non-bang variants following Rails convention

Author: AlexGascon

lib/dynamoid/persistence.rb

@@ -277,6 +277,9 @@ def update!(hash_key, range_key_value = nil, attrs)
       # +update_fields+ uses the +UpdateItem+ operation so it saves changes and
       # loads an updated document back with one HTTP request.
       #
+      # Raises a +Dynamoid::Errors::UnknownAttribute+ exception if any of the
+      # attributes is not on the model
+      #
       # @param hash_key_value [Scalar value] hash key
       # @param range_key_value [Scalar value] range key (optional)
       # @param attrs [Hash]
@@ -325,6 +328,9 @@ def update_fields(hash_key_value, range_key_value = nil, attrs = {}, conditions
       # +upsert+ uses the +UpdateItem+ operation so it saves changes and loads
       # an updated document back with one HTTP request.
       #
+      # Raises a +Dynamoid::Errors::UnknownAttribute+ exception if any of the
+      # attributes is not on the model
+      #
       # @param hash_key_value [Scalar value] hash key
       # @param range_key_value [Scalar value] range key (optional)
       # @param attrs [Hash]
@@ -492,14 +498,15 @@ def save(options = {})
     #
     #   user.update_attributes(age: 27, last_name: 'Tylor')
     #
+    # Raises a +Dynamoid::Errors::UnknownAttribute+ exception if any of the
+    # attributes is not on the model
+    #
     # @param attributes [Hash] a hash of attributes to update
     # @return [true|false] Whether updating successful or not
     # @since 0.2.0
     def update_attributes(attributes)
       attributes.each { |attribute, value| write_attribute(attribute, value) }
       save
-    rescue Dynamoid::Errors::UnknownAttribute
-      false
     end
 
     # Update multiple attributes at once, saving the object once the updates
@@ -525,15 +532,16 @@ def update_attributes!(attributes)
     #
     #   user.update_attribute(:last_name, 'Tylor')
     #
+    # Raises a +Dynamoid::Errors::UnknownAttribute+ exception if any of the
+    # attributes is not on the model
+    #
     # @param attribute [Symbol] attribute name to update
     # @param value [Object] the value to assign it
     # @return [Dynamoid::Document] self
     # @since 0.2.0
     def update_attribute(attribute, value)
       write_attribute(attribute, value)
       save
-    rescue Dynamoid::Errors::UnknownAttribute
-      false
     end
 
     # Update a model.

lib/dynamoid/persistence/update_fields.rb

@@ -25,7 +25,7 @@ def call
 
         raw_attributes = update_item
         @model_class.new(undump_attributes(raw_attributes))
-      rescue Dynamoid::Errors::ConditionalCheckFailedException, Dynamoid::Errors::UnknownAttribute
+      rescue Dynamoid::Errors::ConditionalCheckFailedException
       end
 
       private

lib/dynamoid/persistence/upsert.rb

@@ -25,7 +25,7 @@ def call
 
         raw_attributes = update_item
         @model_class.new(undump_attributes(raw_attributes))
-      rescue Dynamoid::Errors::ConditionalCheckFailedException, Dynamoid::Errors::UnknownAttribute
+      rescue Dynamoid::Errors::ConditionalCheckFailedException
       end
 
       private

spec/dynamoid/persistence_spec.rb

@@ -1058,7 +1058,7 @@ def log_message
       end.to change { d.reload.name }.to('[Updated]')
     end
 
-    it 'does not save when adding an attribute that is not on the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       klass = new_class do
         field :name
       end
@@ -1067,7 +1067,7 @@ def log_message
 
       expect do
         klass.update(obj.id, name: 'New name', age: 26)
-      end.not_to change { obj.reload.name }
+      end.to raise_error Dynamoid::Errors::UnknownAttribute
     end
 
     describe 'timestamps' do
@@ -1302,11 +1302,12 @@ def log_message
       end
     end
 
-    it 'returns nil if an attribute does not exist in the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       obj = document_class.create(title: 'New Document')
 
-      result = document_class.update_fields(obj.id, { title: 'New title', publisher: 'New publisher' } )
-      expect(result).to be_nil
+      expect {
+        document_class.update_fields(obj.id, { title: 'New title', publisher: 'New publisher' } )
+      }.to raise_error Dynamoid::Errors::UnknownAttribute
     end
   end
 
@@ -1486,11 +1487,12 @@ def log_message
       end
     end
 
-    it 'returns nil if an attribute does not exist in the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       obj = document_class.create(title: 'New Document')
 
-      result = document_class.upsert(obj.id, { title: 'New title', publisher: 'New publisher' } )
-      expect(result).to be_nil
+      expect {
+        document_class.upsert(obj.id, { title: 'New title', publisher: 'New publisher' } )
+      }.to raise_error Dynamoid::Errors::UnknownAttribute
     end
   end
 
@@ -2015,16 +2017,17 @@ def log_message
       end
     end
 
-    it 'does not save the document if the attribute is not on the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       klass = new_class do
         field :age, :integer
         field :name, :string
       end
 
       obj = klass.create!(name: 'Alex', age: 26)
 
-      expect(obj.update_attribute(:city, 'Dublin')).to eq false
-      expect(klass.find(obj.id)[:city]).to be_nil
+      expect {
+        obj.update_attribute(:city, 'Dublin')
+      }.to raise_error(Dynamoid::Errors::UnknownAttribute)
     end
   end
 
@@ -2118,13 +2121,12 @@ def log_message
       end
     end
 
-    it 'does not save the document if an attribute is not on the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       obj = klass.create!(name: 'Alex', age: 26)
 
-      expect(obj.update_attributes(city: 'Dublin', age: 27)).to eq false
-      saved_object = klass.find(obj.id)
-      expect(saved_object[:city]).to be_nil
-      expect(saved_object[:age]).to eq 26
+      expect {
+        obj.update_attributes!(city: 'Dublin', age: 27)
+      }.to raise_error(Dynamoid::Errors::UnknownAttribute)
     end
   end
 
@@ -2168,7 +2170,7 @@ def log_message
       expect(klass.find(obj.id).age).to eql 26
     end
 
-    it 'raises UnknownAttributeError if any attribute is not on the model' do
+    it 'raises an UnknownAttribute error when adding an attribute that is not on the model' do
       obj = klass.create!(name: 'Alex', age: 26)
 
       expect {