Sync specs for transactional save/save! and update_attributes/update_attributes!

Author: andrykonchin

spec/dynamoid/transaction_write/save_spec.rb

@@ -1211,6 +1211,9 @@ def around_update_callback
 end
 
 describe Dynamoid::TransactionWrite, '.save!' do
+  # The only difference in specs structure between #save and #save! is missing
+  # a section for callbacks here
+
   let(:klass) do
     new_class do
       field :name
@@ -1469,6 +1472,51 @@ def around_update_callback
     expect(obj_to_create).to be_changed
   end
 
+  it 'does not roll back the transaction when a model to update does not exist' do
+    obj_deleted = klass.create!(name: 'one')
+    klass.find(obj_deleted.id).delete
+    obj_deleted.name = 'one [updated]'
+    obj_to_create = nil
+
+    expect {
+      described_class.execute do |txn|
+        txn.save! obj_deleted
+        obj_to_create = txn.create klass, name: 'two'
+      end
+    }.to change(klass, :count).by(2)
+
+    expect(obj_to_create).to be_persisted
+    expect(obj_to_create).not_to be_changed
+  end
+
+  it 'is marked as not persisted and is marked as changed at creation when the transaction rolled back' do
+    obj = klass.new(name: 'Alex')
+
+    expect {
+      described_class.execute do |txn|
+        txn.save! obj
+        raise 'trigger rollback'
+      end
+    }.to raise_error('trigger rollback')
+
+    expect(obj).not_to be_persisted
+    expect(obj).to be_changed
+  end
+
+  it 'is marked as changed at updating when the transaction rolled back' do
+    obj = klass.create!(name: 'Alex')
+    obj.name = 'Alex [Updated]'
+
+    expect {
+      described_class.execute do |txn|
+        txn.save! obj
+        raise 'trigger rollback'
+      end
+    }.to raise_error('trigger rollback')
+
+    expect(obj).to be_changed
+  end
+
   context 'primary key is of non-native DynamoDB type' do
     context 'a new model' do
       it 'uses dumped value of partition key to update item' do

spec/dynamoid/transaction_write/update_attributes_spec.rb

@@ -52,7 +52,7 @@ def around_save_callback
     end
   end
 
-  it 'persists changes' do
+  it 'persists changes in already presisted model' do
     obj = klass.create!(name: 'Alex')
 
     described_class.execute do |txn|
@@ -316,7 +316,7 @@ def around_save_callback
     expect(klass.find(obj_deleted.id).name).to eql 'Alex [Updated]'
   end
 
-  it 'is marked as changed when the transaction rolled back' do
+  it 'keeps a model as changed when the transaction rolled back' do
     obj = klass.create!(name: 'Alex')
 
     expect {
@@ -545,6 +545,10 @@ def around_update_callback
 end
 
 describe Dynamoid::TransactionWrite, '#update_attributes!' do
+  # The only difference in specs structure between
+  # #update_attributes and #update_attributes! is missing a section
+  # for callbacks here
+
   let(:klass) do
     new_class do
       field :name
@@ -603,6 +607,98 @@ def around_update_callback
     end
   end
 
+  describe 'primary key validation' do
+    context 'simple primary key' do
+      it 'requires partition key to be specified' do
+        obj = klass.create!(name: 'Alex')
+        obj.id = nil
+
+        expect {
+          described_class.execute do |txn|
+            txn.update_attributes! obj, name: 'Alex [Updated]'
+          end
+        }.to raise_exception(Dynamoid::Errors::MissingHashKey)
+      end
+    end
+
+    context 'composite key' do
+      it 'requires partition key to be specified' do
+        obj = klass_with_composite_key.create!(name: 'Alex', age: 3)
+        obj.id = nil
+
+        expect {
+          described_class.execute do |txn|
+            txn.update_attributes! obj, name: 'Alex [Updated]'
+          end
+        }.to raise_exception(Dynamoid::Errors::MissingHashKey)
+      end
+
+      it 'requires sort key to be specified' do
+        obj = klass_with_composite_key.create!(name: 'Alex', age: 3)
+        obj.age = nil
+
+        expect {
+          described_class.execute do |txn|
+            txn.update_attributes! obj, name: 'Alex [Updated]'
+          end
+        }.to raise_exception(Dynamoid::Errors::MissingRangeKey)
+      end
+    end
+  end
+
+  describe 'timestamps' do
+    it 'sets updated_at if Config.timestamps=true', config: { timestamps: true } do
+      obj = klass.create!
+
+      travel 1.hour do
+        time_now = Time.now
+
+        described_class.execute do |txn|
+          txn.update_attributes! obj, name: 'Alex [Updated]'
+        end
+
+        obj.reload
+        expect(obj.updated_at.to_i).to eql time_now.to_i
+      end
+    end
+
+    it 'uses provided values of created_at and updated_at if Config.timestamps=true', config: { timestamps: true } do
+      obj = klass.create!
+
+      travel 1.hour do
+        created_at = updated_at = Time.now
+
+        described_class.execute do |txn|
+          txn.update_attributes! obj, created_at: created_at, updated_at: updated_at
+        end
+
+        obj.reload
+        expect(obj.created_at.to_i).to eql created_at.to_i
+        expect(obj.updated_at.to_i).to eql updated_at.to_i
+      end
+    end
+
+    it 'does not raise error if Config.timestamps=false', config: { timestamps: false } do
+      obj = klass.create!
+
+      expect {
+        described_class.execute do |txn|
+          txn.update_attributes! obj, name: 'Alex [Updated]'
+        end
+      }.not_to raise_error
+    end
+
+    it 'does not raise error if no changes and Config.timestamps=false', config: { timestamps: false } do
+      obj = klass.create!
+
+      expect {
+        described_class.execute do |txn|
+          txn.update_attributes! obj, {}
+        end
+      }.not_to raise_error
+    end
+  end
+
   describe 'validation' do
     before do
       klass_with_validation.create_table
@@ -710,6 +806,19 @@ def around_update_callback
     expect(klass.find(obj_deleted.id).name).to eql 'Alex [Updated]'
   end
 
+  it 'keeps a model as changed when the transaction rolled back' do
+    obj = klass.create!(name: 'Alex')
+
+    expect {
+      described_class.execute do |txn|
+        txn.update_attributes! obj, name: 'Alex [Updated]'
+        raise 'trigger rollback'
+      end
+    }.to raise_error('trigger rollback')
+
+    expect(obj).to be_changed
+  end
+
   it 'uses dumped value of partition key to update item' do
     klass = new_class(partition_key: { name: :published_on, type: :date }) do
       field :name