Fix multiple dependencies not being stored properly

Author: adamruzicka

lib/dynflow/persistence_adapters/sequel.rb

@@ -196,7 +196,7 @@ def save_delayed_plan(execution_plan_id, value)
       end
 
       def chain_execution_plan(first, second)
-        save :execution_plan_dependency, { execution_plan_uuid: second }, { execution_plan_uuid: second, blocked_by_uuid: first }, with_data: false
+        save :execution_plan_dependency, {}, { execution_plan_uuid: second, blocked_by_uuid: first }, with_data: false
       end
 
       def load_step(execution_plan_id, step_id)

test/future_execution_test.rb

@@ -218,7 +218,7 @@ module FutureExecutionTest
         it 'chains onto multiple execution plans and waits for all to finish' do
           plan1 = world.plan(Support::DummyExample::Dummy)
           plan2 = world.plan(Support::DummyExample::Dummy)
-          plan3 = world.chain([plan1.id, plan2.id], Support::DummyExample::Dummy)
+          plan3 = world.chain([plan2.id, plan1.id], Support::DummyExample::Dummy)
 
           # Execute and complete plan1
           Concurrent::Promises.resolvable_future.tap do |promise|

test/persistence_test.rb

@@ -382,6 +382,17 @@ def self.it_acts_as_persistence_adapter
             _(plans.first[:execution_plan_uuid]).must_equal 'plan1'
           end
 
+          it 'properly stored execution plan dependencies' do
+            start_time = Time.now.utc
+            prepare_and_save_plans
+
+            adapter.save_delayed_plan('plan1', :execution_plan_uuid => 'plan1', :frozen => false)
+            adapter.chain_execution_plan('plan2', 'plan1')
+            adapter.chain_execution_plan('plan3', 'plan1')
+            dependencies = adapter.find_execution_plan_dependencies('plan1')
+            _(dependencies.to_set).must_equal ['plan2', 'plan3'].to_set
+          end
+
           it 'does not find blocked plans' do
             start_time = Time.now.utc
             prepare_and_save_plans