WIP: some new warnings

Author: tcclevenger

components/homme/src/share/compose/cedr_kokkos.hpp

@@ -76,7 +76,7 @@ using Unmanaged =
                  MemoryTraitsMask<View>::value |
                  // ... |ed with the one we want, whether or not it's
                  // already there.
-                 Kokkos::Unmanaged> >;
+                 unsigned(Kokkos::Unmanaged)> >;
 
 template <typename View>
 using Const = typename View::const_type;

components/homme/src/share/compose/compose_slmm_islmpi_pack.cpp

@@ -19,7 +19,7 @@ struct Accum {
   Int mos, sendcount, xos, qos;
   SLMM_KIF Accum () : mos(0), sendcount(0), xos(0), qos(0) {}
   SLMM_KIF void operator+= (const volatile Accum& o) volatile {
-    mos += o.mos; sendcount += o.sendcount; xos += o.xos; qos += o.qos;
+    mos = mos + o.mos; sendcount = sendcount + o.sendcount; xos = xos + o.xos; qos = qos + o.qos;
   }
 };
 

components/homme/src/share/compose/compose_slmm_islmpi_q.cpp

@@ -276,7 +276,7 @@ struct Accum {
   Int cnt, qcnt, qos, xos;
   SLMM_KIF  Accum () : cnt(0), qcnt(0), qos(0), xos(0) {}
   SLMM_KIF void operator+= (const volatile Accum& o) volatile {
-    cnt += o.cnt; qcnt += o.qcnt; qos += o.qos; xos += o.xos;
+    cnt = cnt + o.cnt; qcnt = qcnt + o.qcnt; qos = qos + o.qos; xos = xos + o.xos;
   }
 };