Removes return or error codes from TimeMgr

Removes return or error codes from TimeMgr

    removes the return codes from most time manager routines
    adds use of Error handler in TimeMgr and TimeMgrTest
    updates unit tests and dependent routines
    fixes some unused variables in TimeMgr and TimeStepper
    updates docs

Author: philipwjones

components/omega/doc/devGuide/TimeMgr.md

@@ -231,7 +231,7 @@ monthly Alarm:
 OMEGA::TimeInterval IntervalMonthly(1, OMEGA::TimeUnits::Months);
 OMEGA::Alarm AlarmMonthly("Every Month", IntervalMontly, StartTime);
 
-Err = ModelClock.attachAlarm(AlarmMonthly);
+ModelClock.attachAlarm(AlarmMonthly);
 ```
 The Clock can be used to control the duration of a simulation by using a
 TimeInstant that represents the stop time:
@@ -241,7 +241,7 @@ OMEGA::TimeInstant CurrentTime = StartTime;
 
 while (CurrentTime < StopTime) {
 
-   Err = ModelClock.advance();
+   ModelClock.advance();
    CurrentTime = ModelClock.getCurrentTime();
 
   ...

components/omega/src/infra/IOStream.cpp

@@ -493,13 +493,8 @@ Error IOStream::create(const std::string &StreamName, //< [in] name of stream
 
    } // end if IOFreqUnits
    // If an alarm is set, attach it to the model clock
-   if (HasAlarm) {
-      int AlarmErr = ModelClock->attachAlarm(&(NewStream->MyAlarm));
-      if (AlarmErr != 0) {
-         ABORT_ERROR("Error attaching alarm to model clock for stream {}",
-                     StreamName);
-      }
-   }
+   if (HasAlarm)
+      ModelClock->attachAlarm(&(NewStream->MyAlarm));
 
    // Check the file frequency to see if there will be multiple records or
    // time slices per file
@@ -559,11 +554,7 @@ Error IOStream::create(const std::string &StreamName, //< [in] name of stream
       // create and attach alarm
       std::string FileAlarmName = StreamName + "File";
       NewStream->FileAlarm      = Alarm(FileAlarmName, FileInt, ClockStart);
-      int AlarmErr = ModelClock->attachAlarm(&(NewStream->FileAlarm));
-      if (AlarmErr != 0) {
-         ABORT_ERROR("Error attaching file alarm to model clock for stream {}",
-                     StreamName);
-      }
+      ModelClock->attachAlarm(&(NewStream->FileAlarm));
 
       // Check for
    } // end multiframe
@@ -594,14 +585,8 @@ Error IOStream::create(const std::string &StreamName, //< [in] name of stream
       std::string EndName   = StreamName + "End";
       NewStream->StartAlarm = Alarm(StartName, Start);
       NewStream->EndAlarm   = Alarm(EndName, End);
-      int AlarmErr          = ModelClock->attachAlarm(&(NewStream->StartAlarm));
-      if (AlarmErr != 0)
-         ABORT_ERROR("Error attaching start alarm to model clock for stream {}",
-                     StreamName);
-      AlarmErr = ModelClock->attachAlarm(&(NewStream->EndAlarm));
-      if (AlarmErr != 0)
-         ABORT_ERROR("Error attaching end alarm to model clock for stream {}",
-                     StreamName);
+      ModelClock->attachAlarm(&(NewStream->StartAlarm));
+      ModelClock->attachAlarm(&(NewStream->EndAlarm));
    } // endif UseStartEnd
 
    // Now we add the list of field names to the stream
@@ -2293,7 +2278,6 @@ int IOStream::readFieldData(
       LOG_ERROR("Invalid data type while reading field {} for stream {}",
                 FieldName, Name);
       return Fail;
-      break;
 
    } // end switch data type
 
@@ -2513,7 +2497,7 @@ int IOStream::writeStream(
    // Update the time field with elapsed time since simulation start
    TimeInterval ElapsedTime = SimTime - StartTime;
    R8 ElapsedTimeR8;
-   Err = ElapsedTime.get(ElapsedTimeR8, TimeUnits::Seconds);
+   ElapsedTime.get(ElapsedTimeR8, TimeUnits::Seconds);
    HostArray1DR8 OutTime("OutTime", 1);
    OutTime(0) = ElapsedTimeR8;
    Err        = Field::attachFieldData("time", OutTime);
@@ -2846,11 +2830,7 @@ std::string IOStream::buildFilename(
    I8 ISecW;
    I8 ISecN;
    I8 ISecD;
-   int Err =
-       FileTime.get(IYear, IMonth, IDay, IHour, IMin, ISecW, ISecN, ISecD);
-   if (Err != 0) {
-      LOG_ERROR("Error getting components of simulation time for filename");
-   }
+   FileTime.get(IYear, IMonth, IDay, IHour, IMin, ISecW, ISecN, ISecD);
 
    // Convert these to strings (will pad with zeros if needed later)
    std::string SYear  = std::to_string(IYear);