Use config options for hostname re in machine discovery #344
Conversation
Instead of hard-coding the regular expressions used to discover machines from their host names, make these config options. This makes it much easier to add new machines. This merge also takes an optional package or path where it will search for additional config files that may define machines and the regular expressions used to identify their hotnames.
xylar
added
the
clean-up
TestingIt will be tedious to test this on each machine, so I will follow up with fixes in later PRs if problems arise. I tested on my laptop, |
|
@andrewdnolan, would you be willing to test this out on Chrysalis whenever you are back from vacation? It should be as trivial as setting up the dev environment and running the same expression as I did above. Note that I switched to # one-time pixi install on each machine
curl -fsSL https://pixi.sh/install.sh | sh
# set up the dev environment
pixi install
pixi shell
python -m pip install --no-deps --no-build-isolation -e .
# the actual test
python -c "import mache; print(mache.discover.discover_machine())"
# leave the pixi shell
exit |
TestingI've confirmed that this works for me on chrysalis. After setting up the $ python -c "import mache; print(mache.discover.discover_machine())"
# chrysalis |
andrewdnolan
left a comment
andrewdnolan
left a comment
There was a problem hiding this comment.
This all looks good to me. I've only taken a quick look, but feel confident with this based on the testing.
|
Thanks so much @andrewdnolan! |
2 participants
Instead of hard-coding the regular expressions used to discover machines from their host names, make these config options. This makes it much easier to add new machines.
This merge also takes an optional package or path where it will search for additional config files that may define machines and the regular expressions used to identify their hostnames.
Checklist
Testingcomment, if appropriate, in the PR documents testing used to verify the changes