Skip to content

Commit 2a6f5d7

Browse files
committed
Refactor variable names
1 parent 6ff0a79 commit 2a6f5d7

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tools/imatrix/imatrix.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ struct tensor_statistics {
5656
float entropy = 0.0f;
5757
float zd_score = 0.0f;
5858
float cossim = 0.0f;
59-
float l2_norm = 0.0f;
59+
float l2_dist = 0.0f;
6060
};
6161

6262
class IMatrixCollector {
@@ -381,8 +381,8 @@ static void compute_layer_statistics(const std::vector<tensor_statistics> & tsta
381381
}
382382
layer_cossim[kv.first] = cossim;
383383

384-
// Compute aggregated L2 Norm (Euclidean Distance)
385-
layer_l2_norm[kv.first] = (float)std::sqrt(l2_dist_sq);
384+
// Compute aggregated L2 Distance (Euclidean Distance)
385+
layer_l2_dist[kv.first] = (float)std::sqrt(agg.sum_l2_dist_sq);
386386
}
387387
}
388388

@@ -1327,7 +1327,7 @@ static bool show_statistics(const common_params & params) {
13271327
LOG_INF("\n%6s\t%18s\t%13s\t%8s\t%8s\t%7s\t%15s\t%13s\t%11s\t%8s\t%5s\t%10s\n",
13281328
"Layer",
13291329
"Tensor",
1330-
legacy_mode ? "Σ E[Act²]" : "L₂ Norm",
1330+
legacy_mode ? "Σ E[Act²]" : "L₂ Dist",
13311331
"Min",
13321332
"Max",
13331333
"μ",
@@ -1354,12 +1354,12 @@ static bool show_statistics(const common_params & params) {
13541354
}
13551355

13561356
const float h_norm = tstat.elements > 1 ? 100.0f * (tstat.entropy / std::log2((float) tstat.elements)) : 0.0f;
1357-
const float ecs = 100.0f * std::exp(-0.01f * tstat.l2_norm) * std::pow(std::fabs(tstat.cossim), 10.0f);
1357+
const float ecs = 100.0f * std::exp(-0.01f * tstat.l2_dist) * std::pow(std::fabs(tstat.cossim), 10.0f); // Euclidean-Cosine score
13581358

13591359
LOG_INF("%5s\t%-20s\t%11.4f\t%10.4f\t%10.4f\t%8.4f\t%8.4f\t%7d\t%10.2f%%\t%10.4f\t%6.2f%%\t%10.4f\n",
13601360
layer.c_str(),
13611361
name.c_str(),
1362-
legacy_mode ? tstat.sum_values : tstat.l2_norm,
1362+
legacy_mode ? tstat.sum_values : tstat.l2_dist,
13631363
tstat.min_values,
13641364
tstat.max_values,
13651365
tstat.mean_values,
@@ -1385,14 +1385,14 @@ static bool show_statistics(const common_params & params) {
13851385
}
13861386

13871387
std::map<int, float> layer_cossim;
1388-
std::map<int, float> layer_l2_norm;
1389-
compute_layer_statistics(ts, layer_cossim, layer_l2_norm, g_collector.get_mstats());
1388+
std::map<int, float> layer_l2_dist;
1389+
compute_layer_statistics(ts, layer_cossim, layer_l2_dist, g_collector.get_mstats());
13901390

13911391
const size_t layers = std::count_if(ls.begin(), ls.end(), [](const auto & kv) { return kv.first >= 0; });
13921392
LOG_INF("\nComputing layer statistics (%zu layers)\n", layers);
13931393
LOG_INF("\n%6s\t%13s\t%6s\t%11s\t%6s\n",
13941394
"Layer",
1395-
legacy_mode ? "Σ E[Act²]" : "L₂ Norm",
1395+
legacy_mode ? "Σ E[Act²]" : "L₂ Dist",
13961396
"ZD",
13971397
"CosSim",
13981398
legacy_mode ? "" : "ECS");
@@ -1405,8 +1405,8 @@ static bool show_statistics(const common_params & params) {
14051405
if (layer < 0 || stats.n == 0) { continue; }
14061406
const auto lcs = layer_cossim.find(layer);
14071407
const float layer_cs = lcs != layer_cossim.end() ? lcs->second : 0.0f;
1408-
const auto ll2n = layer_l2_norm.find(layer);
1409-
const float layer_l2n = ll2n != layer_l2_norm.end() ? ll2n->second : 0.0f;
1408+
const auto ll2n = layer_l2_dist.find(layer);
1409+
const float layer_l2n = ll2n != layer_l2_dist.end() ? ll2n->second : 0.0f;
14101410
if (legacy_mode) {
14111411
LOG_INF("%5d\t%11.4f\t%6.2f%%\t%11.4f\n",
14121412
layer,

0 commit comments

Comments
 (0)