v3.2.5

Author: ws-garcia

src/LO Basic/VBAExpressionsLib/TestVBAExpr.xba

@@ -337,6 +337,11 @@ Sub RunAllTests
 			"ROUND(IBETA((2-1)/(3-1);8;10);4)", _
 			"0.6855" _
 		)
+	Run( _
+			"Excel T.INV function test", _
+			"ROUND(TINV(0.75;2;1);8)", _
+			"0.81649658" _
+		)
 	SF_Exception.debugprint("Passed tests:",sAcum)	
 	SF_Exception.debugprint("Failed tests:",tTotal - sAcum)	
 	SF_Exception.debugprint("Passed tests Ratio:",Round(100*sAcum/tTotal,2) &"%")

src/LO Basic/VBAExpressionsLib/VBAexpressions.xba

@@ -3995,9 +3995,11 @@ Private Function GetFunctionName(ByRef expression As String) As String
     For EFjCounter = LBound(FunctionsId) To UBound(FunctionsId)
         tmpPos = strVBA.InStrB(1, ExpCopy, FunctionsId(EFjCounter))
         If tmpPos Then
-            GFNbool = ValidFuntionName(ExpCopy, FunctionsId(EFjCounter), tmpPos)
-            If GFNbool Then
-                Exit For
+            If ExpCopy = FunctionsId(EFjCounter) Then
+                GFNbool = ValidFuntionName(ExpCopy, FunctionsId(EFjCounter), tmpPos)
+                If GFNbool Then
+                    Exit For
+                End If
             End If
         End If
     Next EFjCounter
@@ -4009,9 +4011,11 @@ Private Function GetFunctionName(ByRef expression As String) As String
         For i = 0 To UserDefFunctions.aindex
             tmpPos = strVBA.InStrB(1, ExpCopy, UserDefFunctions.Storage(i).aName)
             If tmpPos Then
-                GFNbool = ValidFuntionName(ExpCopy, UserDefFunctions.Storage(i).aName, tmpPos)
-                If GFNbool Then
-                    Exit For
+                If ExpCopy = UserDefFunctions.Storage(I).name Then
+                    GFNbool = ValidFuntionName(ExpCopy, UserDefFunctions.Storage(I).name, tmpPos)
+                    If GFNbool Then
+                        Exit For
+                    End If
                 End If
             End If
         Next i
@@ -4951,7 +4955,7 @@ Private Function iBETAINV(p As Double, A As Double, B As Double) As Double
         err = iBETA_(x, A, B) - p
         t = Exp(a1 * Log(x) + b1 * Log(1 - x) + afac)
         u = err / t
-        t = u / (1 - 0.5 * Min(1, u * (a1 / x - b1 / (1 - x))))
+        t = u / (1 - 0.5 * MIN_(1, u * (a1 / x - b1 / (1 - x))))
         x = x - t
         If x <= 0 Then x = 0.5 * (x + t)
         If x >= 1 Then x = 0.5 * (x + t + 1)
@@ -8452,97 +8456,6 @@ Private Function STUDT_(ByVal t As Double, n As Double) As Double
     End If
 End Function
 
-Private Function subTINV_(x1 As Double, x2 As Double) As Variant
-    If ((0 >= x1 Or Abs(x1) - Abs(Fix(x1)) <> 0) Or (0 >= x2 Or x2 >= 1)) Then
-        subTINV_ = False
-    Else
-        subTINV_ = GetPrecisionResult(subt_(x1, x2))
-    End If
-End Function
-
-Private Function subtprob_(y1 As Double, y2 As Double) As Double
-    Dim e As Double, rt1 As Double
-    Dim L As Double, n As Double
-    Dim s As Double, rt2 As Double
-    
-    L = Atn((y2 / Sqr(y1)) / 1)
-    n = Cos(L) ^ 2: s = 1
-    For rt2 = y1 - 2 To 2 Step -2
-        s = 1 + (rt2 - 1) / rt2 * n * s
-    Next rt2
-    If REM_(y1, 2) = 0 Then
-        e = 0.5
-        rt1 = Sin(L) / 2
-        subtprob_ = rt1
-    Else
-        e = 0.5 + L / pi
-        If 1 = y1 Then
-            rt1 = 0
-        Else
-            rt1 = Cos(L) * Sin(L) / pi
-        End If
-        subtprob_ = MAX_(0, 1 - e - rt1 * s)
-    End If
-End Function
-
-Private Function subt_(t As Double, r As Double) As Double
-    Dim e As Double, h As Double
-    Dim f As Double, i As Double
-    Dim inp1 As Double, inp2 As Double
-    Dim inp3 As Double, inp4 As Double
-    Dim inp5 As Double, inp6 As Double
-    Dim inp7 As Double, inp9 As Double
-    
-    If (0 >= r Or r >= 1) Then
-        subt_ = 0: Exit Function
-    End If
-    If (0.5 > r) Then
-        subt_ = -subt_(t, 1 - r): Exit Function
-    End If
-    e = subu_(r)
-    inp1 = e ^ 2
-    inp2 = (27 * inp1 + 339) * inp1 + 930
-    inp2 = inp2 * inp1 - 1782
-    inp2 = ((inp2 * inp1 - 765) * inp1 + 17955) / 368640
-    inp3 = (79 * inp1 + 776) * inp1 + 1482
-    inp3 = inp3 * inp1 - 1920
-    inp3 = (inp3 * inp1 - 945) / 92160
-    inp4 = (((3 * inp1 + 19) * inp1 + 17) * inp1 - 15) / 384
-    inp6 = ((5 * inp1 + 16) * inp1 + 3) / 96
-    inp5 = (inp1 + 1) / 4
-    inp7 = inp3 + inp2 / t
-    inp7 = (inp6 + (inp4 + inp7 / t) / t)
-    inp7 = e * (1 + (inp5 + inp7 / t) / t)
-    If (t <= (Log10(r) ^ 2) + 3) Then
-        Do
-            f = subtprob_(t, inp7)
-            inp9 = t + 1
-            i = Log(inp9 / (t + inp7 * inp7))
-            i = i + Log(t / inp9 / 2 / pi) - 1 + (1 / inp9 - 1 / t)
-            i = (f - r) / Exp((inp9 * i / 6) / 2)
-            inp7 = inp7 + i
-            h = RoundToPrecision(i, Abs(Fix(Log10(Abs(inp7)) - 6)))
-        Loop While (inp7 And 0 <> h)
-    End If
-    subt_ = inp7
-End Function
-
-Private Function subu_(p3 As Double) As Double
-    Dim p4 As Double
-    Dim e As Double
-    
-    p4 = -Log(4 * p3 * (1 - p3))
-    e = -3.231081277E-09 + p4 * (3.657763036E-11 + 6.936233982E-13 * p4)
-    e = -0.00000104527497 + p4 * (8.360937017E-08 + p4 * e)
-    e = 0.000006841218299 + p4 * (0.000005824238515 + p4 * e)
-    e = -0.0008364353589 + p4 * (-0.0002250947176 + p4 * e)
-    e = Sqr(p4 * (1.570796288 + p4 * (0.03706987906 + p4 * e)))
-    If p3 > 0.5 Then
-        e = -e
-    End If
-    subu_ = e
-End Function
-
 Private Function SUM(ByRef expression As String, ByRef fName As String) As String
     Dim g As Long
     Dim tmpData() As String
@@ -8713,15 +8626,17 @@ err_Handler:
 End Function
 
 ''' <summary>
-'''     Receives the degrees of freedom and the confidence level to
-'''     compute the one-tailed or two-tailed t-value (Student t-value)
-'''     with up to 6 significant digits accuracy. Use the tOption
-'''     parameter to select from two and right one-tailed computation.
-'''     [(c) iCalculator™](https://www.icalculator.com/)
+'''     receives the degrees of freedom and the confidence level to
+'''     compute the one-tailed or two-tailed t-value (student t-value)
+'''     with full accuracy. use the toption parameter to select from
+'''     two and right one-tailed computation.
+'''
+'''     (c) david m. lane
+'''     https://onlinestatbook.com/2/calculators/inverse_t_dist.html
 ''' </summary>
-''' <param name="confidence">Confidence level.</param>
-''' <param name="dof">Shape parameter alpha.</param>
-''' <param name="tOption">Select from two and right one-tailed computation.</param>
+''' <param name="confidence">confidence level.</param>
+''' <param name="dof">shape parameter alpha.</param>
+''' <param name="toption">select from two and right one-tailed computation.</param>
 Private Function TINV(ByRef expression As String, ByRef fName As String) As String
     Dim argsCount As Long
     Dim tmpData() As String
@@ -8752,28 +8667,37 @@ err_Handler:
                                     d_lParenthesis & err.Description & d_rParenthesis
 End Function
 
-Private Function TINV_(confidence As Double, dof As Double, _
+Private Function TINV_(ByRef confidence As Double, dof As Double, _
                             Optional tOption As Single = 2) As Double
+    Dim x As Double
     Dim p As Double 'Probability
 
     If confidence > 1 And confidence < 100 Then 'Percentage entry
         confidence = confidence / 100
     End If
-    p = (1 - confidence)
+    p = 1 - confidence
     If tOption = 1 Then
-        TINV_ = subTINV_(dof, p)
+        x = iBETAINV(2 * p, 0.5 * dof, 0.5)
     Else
         If tOption = 2 Then
-            TINV_ = subTINV_(dof, p / 2)
+            x = iBETAINV(p, 0.5 * dof, 0.5)
         End If
     End If
+    x = Round(Sqr(dof * (1 - x) / x), 8)
+    If confidence > 0 Then
+        TINV_ = x
+    Else
+        TINV_ = -x
+    End If
 End Function
 
 ''' <summary>
 '''     Receives the degrees of freedom and the Probability to
-'''     compute the one-tailed t-value (Student t-value) with up
-'''     to 6 significant digits accuracy. Parameter p can be passed
-'''     as 0 < p < 1, or 1 < p < 100
+'''     compute the one-tailed t-value (Student t-value) with full
+'''     accuracy. Parameter p can be passed as 0 < p < 1, or 1 < p < 100
+'''
+'''     (c) David M. Lane
+'''     https://onlinestatbook.com/2/calculators/inverse_t_dist.html
 ''' </summary>
 ''' <param name="p">Probability.</param>
 ''' <param name="dof">Degrees of freedom.</param>
@@ -8807,21 +8731,14 @@ err_Handler:
                                     d_lParenthesis & err.Description & d_rParenthesis
 End Function
 
-Private Function TINV_1T_(p As Double, dof As Double) As Double
-    Dim confidence As Double
-    
-    If p > 1 Then  'Percentage entry
-        p = p / 100
-    End If
-    confidence = 1 - p
-    TINV_1T_ = TINV_(confidence, dof, 1)
-End Function
-
 ''' <summary>
 '''     Receives the degrees of freedom and the Probability to
 '''     compute the two-tailed t-value (Student t-value) with full
 '''     significant digits accuracy. Parameter p can be passed
 '''     as 0 < p < 1, or 1 < p < 100
+'''
+'''     (c) David M. Lane
+'''     https://onlinestatbook.com/2/calculators/inverse_t_dist.html
 ''' </summary>
 ''' <param name="p">Probability.</param>
 ''' <param name="dof">Degrees of freedom.</param>
@@ -8838,7 +8755,7 @@ Private Function TINV_2T(ByRef expression As String, ByRef fName As String) As S
     argsCount = UB - LB + 1
     Select Case argsCount
         Case 2
-            tmpEval = TINV_2T_( _
+            tmpEval = TINV_( _
                             CDbl(tmpData(LB)), _
                             CDbl(tmpData(UB)) _
                             )
@@ -8854,21 +8771,6 @@ err_Handler:
                                     d_lParenthesis & err.Description & d_rParenthesis
 End Function
 
-Private Function TINV_2T_(ByVal p As Double, dof As Long) As Double
-    Dim x As Double
-    
-    If p > 1 Then 'Percentage entry
-        p = p / 100
-    End If
-    x = iBETAINV(p, 0.5 * dof, 0.5)
-    x = Sqr(dof * (1 - x) / x)
-    If p > 0 Then
-        TINV_2T_ = x
-    Else
-        TINV_2T_ = -x
-    End If
-End Function
-
 Public Function ToDblArray(ByRef aArray As Variant) As Variant
     Dim i As Long, LB As Long, UB As Long
     Dim j As Long, LB2 As Long, UB2 As Long

src/LO Basic/VBAExpressionsLib/script.xlb

@@ -7,5 +7,4 @@
  <library:element library:name="VBAexpressions"/>
  <library:element library:name="VBAcallBack"/>
  <library:element library:name="UDFunctions"/>
- <library:element library:name="clsSimpleMath"/>
 </library:library>

src/VBAexpressions.cls

@@ -8549,7 +8549,7 @@ Private Function TINV_(ByRef confidence As Double, dof As Double, _
             x = iBETAINV(p, 0.5 * dof, 0.5)
         End If
     End If
-    x = Sqr(dof * (1 - x) / x)
+    x = Round(Sqr(dof * (1 - x) / x), 8)
     If confidence > 0 Then
         TINV_ = x
     Else