Merge pull request #4 from EES-TUe/remove-irrelevant-groupings

leovsch · web-flow · commit 140e84ac42de · 2025-06-11T15:39:07.000+02:00
remove irrelevant cable type grouping columns
diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "electricity_network_file_parser"
-version = "0.0.2"
+version = "0.0.3"
 authors = [
   { name="Leo van Schooten", email="l.g.t.v.schooten@tue.nl" },
 ]
diff --git a/src/electricity_network_file_parser/FileParser.py b/src/electricity_network_file_parser/FileParser.py
@@ -121,7 +121,6 @@ def parse_cable_types(self, cables_df : pd.DataFrame) -> pd.DataFrame:
         pass
 
     def write_all_data_frames(self, file_name : str = "data.xlsx"):
-        self.data_frames["CABLETYPE"] = self.get_cable_type_data_as_dataframe()
         with pd.ExcelWriter(file_name) as writer:
             for name, dataframe in self.data_frames.items():
                 dataframe.to_excel(writer, sheet_name=name, index=False)
diff --git a/src/electricity_network_file_parser/GnfParser.py b/src/electricity_network_file_parser/GnfParser.py
@@ -20,7 +20,7 @@ def __init__(self, file_path):
         }
 
     def parse_cable_types(self, cables_df : pd.DataFrame) -> pd.DataFrame:
-        columns_to_group_by = ["Unom", "Price", "C", "C0", 
+        columns_to_group_by = ["C", "C0", 
                                "Inom0", "G1", "Inom1", "G2", 
                                "Inom2", "G3", "Inom3", "Ik1s", 
                                "Tr", "TInom", "TIk1s", "Frequency", 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ build-backend = "hatchling.build"`
`4`	`4`
`5`	`5`	`[project]`
`6`	`6`	`name = "electricity_network_file_parser"`
`7`		`-version = "0.0.2"`
	`7`	`+version = "0.0.3"`
`8`	`8`	`authors = [`
`9`	`9`	`{ name="Leo van Schooten", email="l.g.t.v.schooten@tue.nl" },`
`10`	`10`	`]`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ def __init__(self, file_path):`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`def parse_cable_types(self, cables_df : pd.DataFrame) -> pd.DataFrame:`
`23`		`- columns_to_group_by = ["Unom", "Price", "C", "C0",`
	`23`	`+ columns_to_group_by = ["C", "C0",`
`24`	`24`	`"Inom0", "G1", "Inom1", "G2",`
`25`	`25`	`"Inom2", "G3", "Inom3", "Ik1s",`
`26`	`26`	`"Tr", "TInom", "TIk1s", "Frequency",`