Skip to content

Newest version of PyGithub is not compatible with the bot #223

@laraPPr

Description

@laraPPr

PyGithub recently realease PyGithub 2.1.1 which is no longer compatible with the bot. The last version that of PyGithub that is compatible with the bot is v1.59.1. link

With PyGithub 2.1.1 the bot has the following error when trying to submit more than one comment to a pr (It can respond to one bot command but when a seccond command is submitted in the pr the bot cannot respond to it).

The error:

Traceback (most recent call last):
  File "/kyukon/scratch/gent/461/vsc46128/EESSI/venv_eessi_bot_login_p38/lib/python3.8/site-packages/pyghee/lib.py", line 170, in process_event
    self.handle_event(event_info, log_file=log_file)
  File "/kyukon/scratch/gent/461/vsc46128/EESSI/venv_eessi_bot_login_p38/lib/python3.8/site-packages/pyghee/lib.py", line 102, in handle_event
    handler(event_info, log_file=log_file)
  File "/kyukon/scratch/gent/461/vsc46128/EESSI/eessi-bot-software-layer/eessi_bot_event_handler.py", line 208, in handle_issue_comment_event
    issue_comment = create_comment(repo_name, pr_number, comment_body)
  File "/kyukon/scratch/gent/461/vsc46128/EESSI/eessi-bot-software-layer/tools/pr_comments.py", line 45, in create_comment
    gh = github.get_instance()
  File "/kyukon/scratch/gent/461/vsc46128/EESSI/eessi-bot-software-layer/connections/github.py", line 104, in get_instance
    if not _gh or (_token and datetime.datetime.utcnow() > _token.expires_at):
TypeError: can't compare offset-naive and offset-aware datetimes

We should try to resolve this error so that the bot uses the latest version of PyGitlab.

If we implement the fix we should also update requirements.txt so that we at least require PyGithub version 2.1.1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions