Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Commit 7740094

Browse files
authored
Hotfix Alexa Labeller (#19379)
* Fix Docker Process for Alexa labeller - Update Docker image - Also rename main function utility module for index.js - Accidently overwrote global variable "process" * Fix typo in index.js
1 parent b05eeeb commit 7740094

File tree

6 files changed

+22
-20
lines changed

6 files changed

+22
-20
lines changed

utils/labeller/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ WORKDIR /opt
66
COPY package.json .
77
RUN npm install
88
COPY index.js .
9+
COPY utils.js .
10+
COPY test.js .
911
COPY config.json.example .
1012
RUN mv config.json.example config.json
1113

utils/labeller/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Enter your GitHub token info into `config.json`.
3131

3232
Set your `$GITHUB_TOKEN` with "repo, write:discussion" permissions, and run
3333

34-
docker run -it -v $(pwd)/state_dir:/opt/state_dir -e GITHUB_TOKEN=$GITHUB_TOKEN labeller
34+
docker run -it -e GITHUB_TOKEN=$GITHUB_TOKEN labeller
3535

3636
### Without Docker
3737

utils/labeller/index.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
"use strict";
22

33
const { Octokit } = require('@octokit/rest');
4-
const process = require('./process');
4+
const utils = require('./utils');
55
const axios = require('axios');
66
const unzip = require('unzipper');
77
const config = require('./config');
8+
const token = config.github_token || process.env.GITHUB_TOKEN;
89

910
const octokit = new Octokit({
10-
auth: config.github_token,
11+
auth: token,
1112
userAgent: 'Labeller v2'
1213
});
1314
const httpse = {
@@ -18,7 +19,7 @@ const httpse = {
1819
let ProgressBar = require('progress');
1920

2021
// Background process functions for logic flow below
21-
let Process = new process.Process(octokit, httpse);
22+
let Utils = new utils.Utils(octokit, httpse);
2223

2324
/**
2425
* @description Fetch the Alexa top 1M sites and push it to an array `alexa` via streams
@@ -95,7 +96,7 @@ function get_prs(alexa) {
9596
* @description Labels Pull Requests
9697
*/
9798
function process_prs(alexa, prs) {
98-
let filtered_prs = prs.filter(Process.labelled);
99+
let filtered_prs = prs.filter(Utils.labelled);
99100

100101
prs.forEach(pr => {
101102

@@ -105,11 +106,11 @@ function process_prs(alexa, prs) {
105106
...httpse,
106107
pull_number: pr.number,
107108
}).then(files => {
108-
let rank_number = Process.files(files, alexa);
109+
let rank_number = Utils.files(files, alexa);
109110
if(rank_number !== null) {
110-
let determined_label = Process.return_label(rank_number);
111+
let determined_label = Utils.return_label(rank_number);
111112
// pr is interchangeable with issue in API ¯\_(ツ)_/¯
112-
Process.add_label(determined_label, pr.number);
113+
Utils.add_label(determined_label, pr.number);
113114
}
114115
})
115116
});

utils/labeller/state_dir/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

utils/labeller/test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
'use strict';
22

33
const assert = require('chai').assert;
4-
const process = require('./process.js');
4+
const utils = require('./utils.js');
55

66
describe('index.js', () => {
7-
describe('Process.return_label', () => {
7+
describe('Utils.return_label', () => {
88
it('returns proper rank label', () => {
9-
let testProcess = new process.Process();
10-
assert.equal(testProcess.return_label(89), 'top-100', "doesn't match label");
11-
assert.equal(testProcess.return_label(899), 'top-1k', "doesn't match label");
12-
assert.equal(testProcess.return_label(8999), 'top-10k', "doesn't match label");
13-
assert.equal(testProcess.return_label(89999), 'top-100k', "doesn't match label");
14-
assert.equal(testProcess.return_label(899999), 'top-1m', "doesn't match label");
9+
let testUtils = new utils.Utils();
10+
assert.equal(testUtils.return_label(89), 'top-100', "doesn't match label");
11+
assert.equal(testUtils.return_label(899), 'top-1k', "doesn't match label");
12+
assert.equal(testUtils.return_label(8999), 'top-10k', "doesn't match label");
13+
assert.equal(testUtils.return_label(89999), 'top-100k', "doesn't match label");
14+
assert.equal(testUtils.return_label(899999), 'top-1m', "doesn't match label");
1515
});
1616
});
1717
});
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
'use strict';
2-
// Process Functions for Labeller
32

3+
// Process Functions for Labeller
44
const alexa_labels = ['top-1m', 'top-100k', 'top-10k', 'top-1k', 'top-100'];
55

6-
class Process {
6+
class Utils {
77
constructor(octokit, httpse) {
88
this.octokit = octokit;
99
this.httpse = httpse;
@@ -77,5 +77,5 @@ class Process {
7777
}
7878

7979
module.exports = {
80-
Process: Process
80+
Utils: Utils
8181
}

0 commit comments

Comments
 (0)