Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Commit f850f12

Browse files
committed
Merge branch 'master' of github.com:EFForg/https-everywhere into HEAD
2 parents e03b0d8 + 508163c commit f850f12

File tree

11 files changed

+521
-297
lines changed

11 files changed

+521
-297
lines changed

CONTRIBUTING.md

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
- [HTTPS Everywhere Source Code Layout](#https-everywhere-source-code-layout)
66
- [Install Dependencies and Test Build](#install-dependencies-and-test-build)
77
- [Precommit Testing](#precommit-testing)
8+
- [Testing](#testing)
9+
- [Quickly Testing a Ruleset](#quickly-testing-a-ruleset)
10+
- [Coverage](#coverage)
811
- [Submitting Changes](#submitting-changes)
912
- [Contributing Rulesets](#contributing-rulesets)
1013
- [General Info](#general-info)
1114
- [New Rulesets](#new-rulesets)
1215
- [Minimum Requirements for a Ruleset PR](#minimum-requirements-for-a-ruleset-pr)
13-
- [Testing](#testing)
1416
- [Ruleset Style Guide](#ruleset-style-guide)
1517
- [Motivation](#motivation)
1618
- [Indentation & Misc Stylistic Conventions](#indentation--misc-stylistic-conventions)
@@ -118,6 +120,18 @@ hook provided with:
118120

119121
ln -s ../../hooks/precommit .git/hooks/pre-commit
120122

123+
## Testing
124+
125+
### Quickly Testing a Ruleset
126+
127+
1. Open a version of the Firefox or Chrome browser without HTTPS Everywhere loaded to the HTTP endpoint
128+
129+
2. From your working ruleset branch, test with running `bash test/firefox.sh --justrun` or `bash test/chromium.sh --justrun` to open a fresh profile with the extension loaded and click around and compare the look and functionality of both sites. If something fails to load or looks strange, you may be able to debug the problem by opening the network tab of your browser debugging tool. Modify the `ruleset` until you get it in a good state - you'll have to re-run the HTTPS Everywhere-equipped browser upon each change.
130+
131+
### Coverage
132+
133+
Please reference [HTTPS Ruleset Checker](https://github.com/EFForg/https-everywhere/blob/master/test/rules/README.md) to properly test rulesets against our tests before sending a pull request.
134+
121135
## Submitting Changes
122136

123137
To submit changes, open a pull request from our [GitHub repository](https://github.com/efforg/https-everywhere).
@@ -175,12 +189,6 @@ In the back-and-forth process of getting the `ruleset` in good shape, there may
175189

176190
We prefer small, granular changes to the rulesets. Not only are these easier to test and review, this results in cleaner commits.
177191

178-
## Testing
179-
180-
A general workflow for testing sites that provide both HTTP and HTTPS follows. Open a version of the browser of your choice without HTTPS Everywhere loaded to the HTTP endpoint, alongside the browser with the latest code and rulesets for HTTPS Everywhere loaded to the HTTPS endpoint (as described in [README.md](README.md).) Click around and compare the look and functionality of both sites.
181-
182-
If something fails to load or looks strange, you may be able to debug the problem by opening the network tab of your browser debugging tool. Modify the `ruleset` until you get it in a good state - you'll have to re-run the HTTPS Everywhere-equipped browser upon each change.
183-
184192
## Ruleset Style Guide
185193

186194
### Motivation

chromium/external/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This directory contains files that are external dependencies for HTTPS Everywher
44

55
## CodeMirror 5.31.0
66

7-
```
7+
```bash
88
$ npm install [email protected]
99
$ npm install [email protected]
1010
$ curl -o codemirror.zip https://codemirror.net/codemirror-5.31.0.zip
@@ -40,14 +40,15 @@ uglifycss \
4040
--output codemirror-5.31.0.min.css \
4141
codemirror-5.31.0/lib/codemirror.css
4242
```
43+
4344
## Pako 1.0.5
4445

45-
```
46-
$ npm install [email protected]
47-
```
46+
`$ npm install [email protected]`
4847

4948
### pako_inflate.min.js
5049

51-
```
50+
```bash
51+
5252
$ cp node_modules/pako/dist/pako_inflate.js pako-1.0.5/pako_inflate.min.js
53-
```
53+
54+
```

0 commit comments

Comments
 (0)