Skip to content

Commit 31b83bf

Browse files
authored
correcting tests for new spatial values (#108)
1 parent 4b9346b commit 31b83bf

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

emva1288/unittests/test_data.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ def test_data(self):
5858
photons = round(self.dataset.cam.get_photons(radiance), 3)
5959
self.assertEqual(data['spatial']['u_p'], photons)
6060
# spatial data are images
61-
for typ in ('avg', 'avg_dark', 'pvar', 'pvar_dark', 'sum',
62-
'sum_dark', 'var', 'var_dark'):
61+
for typ in ('sum_dark', 'sum'):
6362
self.assertTrue(typ in data['spatial'].keys())
6463
self.assertEqual(data['spatial'][typ].shape, (self._height,
6564
self._width))

emva1288/unittests/test_results.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,8 @@ def test_results_exposure_variation(self):
200200
self.assertAlmostEqual(self.results.PRNU1288,
201201
np.sqrt(self.results.s_2_y -
202202
self.results.s_2_y_dark) * 100 /
203-
(np.mean(self.data.data['spatial']['avg']) -
204-
np.mean(self.data.data['spatial']['avg_'
205-
'dark'])))
203+
(self.data.data['spatial']['avg_mean'] -
204+
self.data.data['spatial']['avg_mean_dark']))
206205

207206
# Test that histograms contains relevant keys and are numpy arrays
208207
hists = ('histogram_PRNU', 'histogram_PRNU_accumulated',
@@ -293,8 +292,8 @@ def test_nans(self):
293292
self.assertIs(r.u_I_var, np.nan)
294293

295294
# Test that a negative s2y_dark will yield a Nan for DSNU1288
296-
data['spatial'] = {'avg_dark': [0, 0, 0],
297-
'var_dark': [1, 1, 1],
295+
data['spatial'] = {'avg_var_dark': 0.,
296+
'var_mean_dark': 1.,
298297
'L_dark': 3}
299298
r = Results1288(data)
300299
self.assertIs(r.DSNU1288, np.nan)

0 commit comments

Comments
 (0)