Removed obsolete code and applied necessary fixes

Author: JessTello

Assets/Scripts/EOSPeer2PeerManager.cs

@@ -99,6 +99,10 @@ private enum PeerConnectionAppState
 
         private Dictionary<ProductUserId, PeerConnectionAppState> connectionStates = new();
 
+    private string Request = "hreq";
+    private string Acknowledgement = "hack";
+     private string Ping = "ping";
+
 #if UNITY_EDITOR
         void OnPlayModeChanged(UnityEditor.PlayModeStateChange modeChange)
         {
@@ -360,14 +364,14 @@ public ProductUserId HandleReceivedMessages()
 
                 string message = System.Text.Encoding.UTF8.GetString(data);
                 // --- Handshake protocol ---
-                if (message == "hreq")
+                if (message == Request)
                 {
                     SendHandshakeAck(peerId);
                     connectionStates[peerId] = PeerConnectionAppState.FullyConnected;
                     Debug.Log($"Received handshake request from {peerId}. Sending ack and setting FullyConnected.");
                     return null;
                 }
-                else if (message == "hack")
+                else if (message == Acknowledgement)
                 {
                     connectionStates[peerId] = PeerConnectionAppState.FullyConnected;
                     Debug.Log($"Received handshake ack from {peerId}. Connection is now FullyConnected.");
@@ -415,7 +419,7 @@ public ProductUserId HandleReceivedMessages()
 
                     return peerId;
                 }
-                else if (message == "ping")
+                else if (message == Ping)
                 {
                     Debug.Log($"EOS P2PNAT HandleReceivedMessages: received ping from {peerId}, ignoring.");
                     return null;

com.playeveryware.eos/Runtime/EOS_SDK/Core/CallbackHelper.cs

@@ -122,12 +122,12 @@ internal static bool TryGetAndRemoveCallback<TCallbackInfoInternal, TCallback, T
 			if (callback != null)
 			{
 				// If this delegate was added with an AddNotify, we should only ever remove it on RemoveNotify.
-				if (notificationId.HasValue)
-				{
-				}
+				// if (notificationId.HasValue)
+				// {
+				// }
 
 				// If the operation is complete, it's safe to remove.
-				else if (callbackInfo.GetResultCode().HasValue && Common.IsOperationComplete(callbackInfo.GetResultCode().Value))
+				 if (callbackInfo.GetResultCode().HasValue && Common.IsOperationComplete(callbackInfo.GetResultCode().Value))
 				{
 					RemoveCallback(clientDataPointer);
 				}

com.playeveryware.eos/Runtime/EOS_SDK/Core/ConvertHelper.cs

@@ -127,10 +127,6 @@ private static void Convert<TArray>(ArraySegment<TArray> from, out int to)
 			to = from.Count;
 		}
 
-        //internal static void Set<T1, T2>(ref T1? value, ref IntPtr m_OverrideThreadAffinity)
-        //{
-        //    throw new NotImplementedException();
-        //}
 
         /// <summary>
         /// Converts from an <see cref="ArraySegment{T}" /> to an <see cref="uint" />.