Merge pull request #1084 from PlayEveryWare/fix/command-line-substringfix

WispyMouse · web-flow · commit a0748c7ff612 · 2025-01-16T12:20:50.000-08:00
fix: Substring Command Line Parameters
diff --git a/Assets/Plugins/Windows/x64/DynamicLibraryLoaderHelper-x64.dll b/Assets/Plugins/Windows/x64/DynamicLibraryLoaderHelper-x64.dll
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:969153308fe56d512c998509226a5a84918b8624c4691f06345a434396d136a7
+oid sha256:4ece6c096c42b55cbefacb01a86ce4d8f2d24b4313195f631ed514931d37636f
 size 122880
diff --git a/Assets/Plugins/Windows/x64/GfxPluginNativeRender-x64.dll b/Assets/Plugins/Windows/x64/GfxPluginNativeRender-x64.dll
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fcd9618285bb1bf56c72f46f64e228cda95aa27e64ea2a0199d649dbfebd8c10
+oid sha256:e7220e703348c312cf834d028c6e9a653b28430c77427b5d21b510683108dd4b
 size 604672
diff --git a/Assets/Plugins/Windows/x86/DynamicLibraryLoaderHelper-x86.dll b/Assets/Plugins/Windows/x86/DynamicLibraryLoaderHelper-x86.dll
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cf018202e613caa46f9f32301f728a6386cfb9b3c036b0f4b300725336f4e5e1
+oid sha256:68a9238433740a835c434ccdd05e58ed6f23950a6aaac4a1caa0899452d4c808
 size 87040
diff --git a/Assets/Plugins/Windows/x86/GfxPluginNativeRender-x86.dll b/Assets/Plugins/Windows/x86/GfxPluginNativeRender-x86.dll
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:361b0b0201d2b0afbf8f982cd529faa6cf148aeb7e9d303df7dff7854b61414f
+oid sha256:5e396a9b292db1e24741a5c9973e26c13336007795a0d2597cc948ac8cb9e39c
 size 467968
diff --git a/lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/io_helpers.h b/lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/io_helpers.h
@@ -125,8 +125,10 @@ namespace pew::eos::io_helpers
             if (match != nullptr)
             {
                 // extract the value.
+                // The argument should have started with "-" and continued with "=",
+                // so it needs to be substringed the length of the match plus these two characters
                 std::string arg_value;
-                arg_value = argument.substr(match->length());
+                arg_value = argument.substr(match->length() + 2);
 
                 if (!arg_value.empty())
                 {

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,10 @@ namespace pew::eos::io_helpers`
`125`	`125`	`if (match != nullptr)`
`126`	`126`	`{`
`127`	`127`	`// extract the value.`
	`128`	`+ // The argument should have started with "-" and continued with "=",`
	`129`	`+ // so it needs to be substringed the length of the match plus these two characters`
`128`	`130`	`std::string arg_value;`
`129`		`- arg_value = argument.substr(match->length());`
	`131`	`+ arg_value = argument.substr(match->length() + 2);`
`130`	`132`
`131`	`133`	`if (!arg_value.empty())`
`132`	`134`	`{`