Skip to content

Commit 6a56e0f

Browse files
authored
Merge pull request #17 from EOS-uiux-Solutions/class
Fix: className prop causing non treeshaking effect
2 parents 6188e84 + 5a71d01 commit 6a56e0f

File tree

5 files changed

+5
-12
lines changed

5 files changed

+5
-12
lines changed

package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,5 @@
101101
"files": [
102102
"es",
103103
"lib"
104-
],
105-
"dependencies": {
106-
"classnames": "^2.3.1"
107-
}
104+
]
108105
}

scripts/iconCommonScript.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ async function generateIconCommonComponents ({ type, from }: IconGenerateScript)
3030
}
3131

3232
// eslint-disable-next-line no-template-curly-in-string
33-
const propString = 'svg className={classString} data-testid="eos-svg-component" transform={`rotate(${rotate}) translate(${translateX}, ${translateY}) scale(${scaleX}, ${scaleY})`} fill={color} width={size} height={size}'
33+
const propString = 'svg className={className} data-testid="eos-svg-component" transform={`rotate(${rotate}) translate(${translateX}, ${translateY}) scale(${scaleX}, ${scaleY})`} fill={color} width={size} height={size}'
3434
filled = filled.replace('svg', propString)
3535
outlined = outlined.replace('svg', propString)
3636

scripts/iconScript.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ async function generateIconComponents ({ type, from }: IconGenerateScript) {
2727
}
2828

2929
// eslint-disable-next-line no-template-curly-in-string
30-
const propString = 'svg className={classString} data-testid="eos-svg-component" transform={`rotate(${rotate}) translate(${translateX}, ${translateY}) scale(${scaleX}, ${scaleY})`} fill={color} width={size} height={size}'
30+
const propString = 'svg className={className} data-testid="eos-svg-component" transform={`rotate(${rotate}) translate(${translateX}, ${translateY}) scale(${scaleX}, ${scaleY})`} fill={color} width={size} height={size}'
3131
data = data.replace('svg', propString)
3232

3333
const render = componentTemplate({ fileName, data })

template/iconCommonComponent.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,13 @@ function componentCommonTemplate ({ fileName, filled, outlined }:CommonTemplateP
99
import * as React from 'react';
1010
import { IconCommonProps, valuesMap } from '../helper';
1111
import { flipFunction } from '../flipFunction';
12-
import classNames from 'classnames';
1312
14-
function EOS_${fileName}({size = "${iconData.iconDefault.size}", color = "${iconData.iconDefault.color}", rotate = ${iconData.iconDefault.rotate}, horizontalFlip = ${iconData.iconDefault.horizontalFlip}, verticalFlip = ${iconData.iconDefault.verticalFlip}, theme = "${iconData.iconDefault.theme}", className}: IconCommonProps) {
13+
function EOS_${fileName}({size = "${iconData.iconDefault.size}", color = "${iconData.iconDefault.color}", rotate = ${iconData.iconDefault.rotate}, horizontalFlip = ${iconData.iconDefault.horizontalFlip}, verticalFlip = ${iconData.iconDefault.verticalFlip}, theme = "${iconData.iconDefault.theme}", className = ""}: IconCommonProps) {
1514
const sizeString: string = size.toString()
1615
if(Object.keys(valuesMap).includes(sizeString)) {
1716
size = valuesMap[size]
1817
}
1918
const { scaleX, scaleY, translateX, translateY } = flipFunction({horizontalFlip,verticalFlip})
20-
const classString = classNames(className);
2119
return (
2220
<>
2321
{

template/iconComponent.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,13 @@ function componentTemplate ({ fileName, data }:TemplateProps) {
88
import * as React from 'react';
99
import { IconProps, valuesMap } from '../helper';
1010
import { flipFunction } from '../flipFunction';
11-
import classNames from 'classnames';
1211
13-
function EOS_${fileName}({size = "${iconData.iconDefault.size}", color = "${iconData.iconDefault.color}", rotate = ${iconData.iconDefault.rotate}, horizontalFlip = ${iconData.iconDefault.horizontalFlip}, verticalFlip = ${iconData.iconDefault.verticalFlip}, className}: IconProps) {
12+
function EOS_${fileName}({size = "${iconData.iconDefault.size}", color = "${iconData.iconDefault.color}", rotate = ${iconData.iconDefault.rotate}, horizontalFlip = ${iconData.iconDefault.horizontalFlip}, verticalFlip = ${iconData.iconDefault.verticalFlip}, className = ""}: IconProps) {
1413
const sizeString: string = size.toString()
1514
if(Object.keys(valuesMap).includes(sizeString)) {
1615
size = valuesMap[size]
1716
}
1817
const { scaleX, scaleY, translateX, translateY } = flipFunction({horizontalFlip,verticalFlip})
19-
const classString = classNames(className);
2018
return (
2119
${data}
2220
);

0 commit comments

Comments
 (0)