Refactored attach files

Author: SundeepChand

src/components/Comments.js

@@ -6,6 +6,14 @@ import CommentForm from './CommentForm'
 import Context from '../modules/Context'
 import userStory from '../services/user_story'
 
+const attachFiles = (formData, attachments) => {
+  if (attachments.length) {
+    attachments.forEach((file) => {
+      formData.append('files.attachment', file)
+    })
+  }
+}
+
 const toggleReplyForm = (repliesToggled, setRepliesToggled, key) => {
   repliesToggled === key + 1
     ? setRepliesToggled(null)
@@ -58,15 +66,9 @@ const Comments = (props) => {
   useEffect(
     () => () => {
       attachments.forEach((file) => URL.revokeObjectURL(file.preview))
-    },
-    [attachments]
-  )
-
-  useEffect(
-    () => () => {
       replyAttachments.forEach((file) => URL.revokeObjectURL(file.preview))
     },
-    [replyAttachments]
+    [attachments, replyAttachments]
   )
 
   const addComment = async (data) => {
@@ -75,11 +77,7 @@ const Comments = (props) => {
     data.user_story = storyId
     formData.append('data', JSON.stringify(data))
 
-    if (attachments.length) {
-      attachments.forEach((file) => {
-        formData.append('files.attachment', file)
-      })
-    }
+    attachFiles(formData, attachments)
 
     await userStory.postComment(formData)
     setComment('')
@@ -94,11 +92,7 @@ const Comments = (props) => {
     data.user_story_comment = commentId
     formData.append('data', JSON.stringify(data))
 
-    if (replyAttachments.length) {
-      replyAttachments.forEach((file) => {
-        formData.append('files.attachment', file)
-      })
-    }
+    attachFiles(formData, replyAttachments)
 
     await userStory.postCommentReply(formData)
     setCommentReply('')