Skip to content

Commit 3f315a9

Browse files
authored
Merge pull request #123 from kailash360/build-fail-120
Fixed build fail due to warnings
2 parents 7cddd9b + ae7fcb1 commit 3f315a9

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

.eslintrc.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ env:
88
root: true
99
plugins:
1010
- react
11+
- react-hooks
1112
rules:
1213
arrow-spacing: 'error'
1314
no-const-assign: 'error'
@@ -16,3 +17,5 @@ rules:
1617
prefer-template: 'error'
1718
prefer-destructuring: ['error', { 'object': true, 'array': false }]
1819
object-curly-spacing: [2, 'always']
20+
react-hooks/rules-of-hooks: 'error'
21+
react-hooks/exhaustive-deps: 'warn'

src/components/Footer.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react'
22

3-
export default () => {
3+
function Footer() {
44
return (
55
<div className='footer-main'>
66
<a className='link link-default' href='/policies'>
@@ -11,3 +11,5 @@ export default () => {
1111
</div>
1212
)
1313
}
14+
15+
export default Footer

src/components/Stories.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useState, useEffect, useRef, useCallback } from 'react'
1+
import React, { useState, useEffect, useRef, useCallback, useMemo } from 'react'
22
import { trackPromise, usePromiseTracker } from 'react-promise-tracker'
33

44
import Button from './Button'
@@ -16,7 +16,7 @@ const Stories = ({ authorId, followerId }) => {
1616

1717
const [page, setPage] = useState(1)
1818

19-
const statusOptions = []
19+
const statusOptions = useMemo(() => [], [])
2020

2121
const [status, setStatus] = useState('Under consideration')
2222

src/modules/TitleSearch.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import React, { useState, useEffect, useCallback } from 'react'
2-
import { debounce } from 'lodash'
1+
import React, { useState, useEffect } from 'react'
32
import userStory from '../services/user_story'
43
import { strip } from '../utils/filterText'
54
import { EOS_ARROW_FORWARD, EOS_THUMB_UP } from 'eos-icons-react'
@@ -9,20 +8,14 @@ const Search = (props) => {
98

109
const [searchResults, setSearchResults] = useState([])
1110

12-
const handleTitleChange = useCallback(
13-
debounce(async (title) => {
11+
useEffect(() => {
12+
if (!title) return
13+
14+
setTimeout(async () => {
1415
const response = await userStory.getStoriesByTitle(title)
1516
setSearchResults(response.data.data.userStories)
16-
}, 600),
17-
[]
18-
)
19-
20-
useEffect(() => {
21-
if (!title) {
22-
return
23-
}
24-
handleTitleChange(title)
25-
}, [title, handleTitleChange])
17+
}, 600)
18+
}, [title])
2619

2720
if (!title) {
2821
return ''

0 commit comments

Comments
 (0)