Fixed bug in Highs::getColOrRowName

Author: jajhall

check/TestCAPI.c

@@ -662,7 +662,8 @@ void testNames() {
       printf("Row    %" HIGHSINT_FORMAT " has name %s\n", iRow, name_p);
   }
 
-  // Check extraction of names for the presolved LP
+  // Check extraction of names for the presolved LP, in which the
+  // first row is removed
   Highs_presolve(highs);
   if (dev_run) Highs_writePresolvedModel(highs, "");
 
@@ -671,25 +672,23 @@ void testNames() {
   assert(presolved_num_col == num_col);
   assert(presolved_num_row == num_row-1);
   for (HighsInt iCol = 0; iCol < presolved_num_col; iCol++) {
-    char name[5];
-    char* name_p = name;
-    return_status = Highs_getPresolvedColName(highs, iCol, name_p);
+    char presolved_name[5];
+    char* presolved_name_p = presolved_name;
+    return_status = Highs_getPresolvedColName(highs, iCol, presolved_name_p);
     assert(return_status == kHighsStatusOk);
     if (dev_run)
-      printf("Presolved column %" HIGHSINT_FORMAT " has name %s\n", iCol, name_p);
+      printf("Presolved column %" HIGHSINT_FORMAT " has name %s\n", iCol, presolved_name_p);
   }
 
   for (HighsInt iRow = 0; iRow < presolved_num_row; iRow++) {
-    char name[5];
-    char* name_p = name;
-    return_status = Highs_getPresolvedRowName(highs, iRow, name_p);
+    char presolved_name[5];
+    char* presolved_name_p = presolved_name;
+    return_status = Highs_getPresolvedRowName(highs, iRow, presolved_name_p);
     assert(return_status == kHighsStatusOk);
     if (dev_run)
-      printf("Presolved row    %" HIGHSINT_FORMAT " has name %s\n", iRow, name_p);
+      printf("Presolved row    %" HIGHSINT_FORMAT " has name %s\n", iRow, presolved_name_p);
   }
 
- 
-
   Highs_destroy(highs);
 }
 

highs/lp_data/Highs.cpp

@@ -2415,8 +2415,8 @@ HighsStatus Highs::getColOrRowName(const HighsLp& lp, const bool is_col,
                  int(num_index));
     return HighsStatus::kError;
   }
-  const HighsInt num_index_name = is_col ? this->model_.lp_.col_names_.size()
-                                         : this->model_.lp_.row_names_.size();
+  const HighsInt num_index_name =
+      is_col ? lp.col_names_.size() : lp.row_names_.size();
   if (index >= num_index_name) {
     highsLogUser(options_.log_options, HighsLogType::kError,
                  "Index %d for %s name is outside the range [0, "
@@ -2425,8 +2425,7 @@ HighsStatus Highs::getColOrRowName(const HighsLp& lp, const bool is_col,
                  int(num_index_name));
     return HighsStatus::kError;
   }
-  name = is_col ? this->model_.lp_.col_names_[index]
-                : this->model_.lp_.row_names_[index];
+  name = is_col ? lp.col_names_[index] : lp.row_names_[index];
   return HighsStatus::kOk;
 }