Merge pull request #1435 from ERGO-Code/fix-1434

Fixed error in Highs::callRunPostsolve

Author: jajhall

src/lp_data/Highs.cpp

@@ -3253,7 +3253,7 @@ HighsStatus Highs::callSolveQp() {
   highsLogUser(options_.log_options, HighsLogType::kInfo,
                "Iteration, Runtime, ObjVal, NullspaceDim\n");
 
-  QpModelStatus qp_model_status;
+  QpModelStatus qp_model_status = QpModelStatus::INDETERMINED;
 
   QpSolution qp_solution(instance);
 
@@ -3468,8 +3468,9 @@ HighsStatus Highs::callRunPostsolve(const HighsSolution& solution,
   const HighsLp& presolved_lp = presolve_.getReducedProblem();
 
   if (this->model_.isMip() && !basis.valid) {
-    // Postsolving a MIP without a valid basis - which would imply
-    // that the relaxation was being solved
+    // Postsolving a MIP without a valid basis - which, if valid,
+    // would imply that the relaxation had been solved, a case handled
+    // below
     presolve_.data_.recovered_solution_ = solution;
     if (HighsInt(presolve_.data_.recovered_solution_.col_value.size()) <
         presolved_lp.num_col_) {
@@ -3494,9 +3495,9 @@ HighsStatus Highs::callRunPostsolve(const HighsSolution& solution,
                      this->basis_, this->info_);
       double& max_integrality_violation = this->info_.max_integrality_violation;
       max_integrality_violation = 0;
-      for (HighsInt iCol = 0; iCol != lp.num_col_; iCol++) {
+      for (HighsInt iCol = 0; iCol < lp.num_col_; iCol++) {
         if (lp.integrality_[iCol] == HighsVarType::kInteger) {
-          const double value = solution.col_value[iCol];
+          const double value = this->solution_.col_value[iCol];
           double intval = std::floor(value + 0.5);
           max_integrality_violation =
               std::max(fabs(intval - value), max_integrality_violation);