Skip to content

Commit 3888612

Browse files
committed
Fix vb validity check
1 parent a5dc18a commit 3888612

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

highs/mip/HighsTransformedLp.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ bool HighsTransformedLp::transformSNFRelaxation(
673673
double val;
674674

675675
if (isVub) {
676-
val = sign * (coef * vbcoef + (sign >= 0 ? std::min(0.0, complorigbincoef) : std::max(0.0, complorigbincoef)));
676+
val = sign * (coef * vbcoef + complorigbincoef);
677677
if (val > kHighsInf) return false;
678678
if (val < 0) {
679679
val = sign * (coef * vbcoef);
@@ -694,7 +694,7 @@ bool HighsTransformedLp::transformSNFRelaxation(
694694
if (val < 0) return false;
695695
}
696696
} else {
697-
val = sign * (coef * vbcoef + (sign >= 0 ? std::max(0.0, complorigbincoef) : std::min(0.0, complorigbincoef)));
697+
val = sign * (coef * vbcoef + complorigbincoef);
698698
if (-val > kHighsInf) return false;
699699
if (val > 0) {
700700
val = sign * (coef * vbcoef);
@@ -981,6 +981,7 @@ bool HighsTransformedLp::transformSNFRelaxation(
981981
-vals[i], complementvub);
982982
}
983983
if (inclbincolvub) vectorsum.values[vbcol] = 0;
984+
// TODO: CHECK IF THE RHS CHANGE SHOULD MATCH THE AGGRCONSTANT
984985
tmpSnfrRhs -= aggrconstant;
985986
break;
986987
}

0 commit comments

Comments
 (0)