Identified use of highs_debug_level as cause of error - due to info_ not being defined when using IPM/PDLP before the call to debugHighsLpSolution in HighsSolve.cpp

Author: jajhall

check/TestLpSolvers.cpp

@@ -500,3 +500,22 @@ TEST_CASE("highs-files-mip", "[highs_lp_solver]") {
 
   h.resetGlobalScheduler(true);
 }
+
+/*
+TEST_CASE("highs-debug-level", "[highs_lp_solver]") {
+  Highs h;
+  h.setOptionValue("output_flag", dev_run);
+  std::string model_file =
+      std::string(HIGHS_DIR) + "/check/instances/avgas.mps";
+
+  h.readModel(model_file);
+  h.setOptionValue("solver", kIpmString);
+  h.setOptionValue("highs_debug_level",  1);
+  h.run();
+  h.setOptionValue("highs_debug_level",  2);
+  h.run();
+  h.setOptionValue("highs_debug_level",  3);
+  h.run();
+  h.resetGlobalScheduler(true);
+}
+*/

highs/io/FilereaderEms.cpp

@@ -195,13 +195,6 @@ FilereaderRetcode FilereaderEms::readModelFromFile(const HighsOptions& options,
         std::getline(f, line);
         lp.row_names_[i] = trim(line);
       }
-    } else {
-      // OK if file just ends after the integer_columns section without
-      // end_linear
-      if (!f) lp.ensureColwise();
-      highsLogUser(options.log_options, HighsLogType::kError,
-                   "names not found in EMS file\n");
-      return FilereaderRetcode::kParserError;
     }
     f.close();
   } else {

highs/lp_data/Highs.cpp

@@ -4417,11 +4417,11 @@ HighsStatus Highs::returnFromOptimizeModel(const HighsStatus run_return_status,
   assert(!called_return_from_optimize_model);
   HighsStatus return_status = highsStatusFromHighsModelStatus(model_status_);
   if (return_status != run_return_status) {
-    printf(
-        "Highs::returnFromOptimizeModel: return_status = %d != %d = "
-        "run_return_status "
-        "For model_status_ = %s\n",
-        int(return_status), int(run_return_status),
+    highsLogDev(
+        options_.log_options, HighsLogType::kError,
+        "Highs::returnFromOptimizeModel: run_return_status = %d != %d = "
+        "return_status = highsStatusFromHighsModelStatus(model_status_ = %s)\n",
+        int(run_return_status), int(return_status),
         modelStatusToString(model_status_).c_str());
   }
   assert(return_status == run_return_status);

highs/lp_data/HighsSolution.cpp

@@ -478,41 +478,46 @@ void getKktFailures(const HighsOptions& options, const bool is_qp,
   }
 
   if (printf_kkt || options.log_dev_level > 0) {
-    printf("getKktFailures:: cost norm = %8.3g; bound norm = %8.3g\n",
-           highs_norm_costs, highs_norm_bounds);
-    printf(
-        "getKktFailures:                      LP  (abs / rel)    "
-        "     Col (abs / rel)         Row (abs / rel)\n");
-
-    printf(
+    highsLogDev(options.log_options, HighsLogType::kInfo,
+                "getKktFailures:: cost norm = %8.3g; bound norm = %8.3g\n",
+                highs_norm_costs, highs_norm_bounds);
+    highsLogDev(options.log_options, HighsLogType::kInfo,
+                "getKktFailures:                      LP  (abs / rel)    "
+                "     Col (abs / rel)         Row (abs / rel)\n");
+
+    highsLogDev(
+        options.log_options, HighsLogType::kInfo,
         "getKktFailures: primal infeasibility %8.3g / %8.3g     %8.3g / "
         "%8.3g     %8.3g / %8.3g\n",
         highs_info.max_primal_infeasibility,
         highs_info.max_relative_primal_infeasibility,
         max_col_primal_infeasibility, max_relative_col_primal_infeasibility,
         max_row_primal_infeasibility, max_relative_row_primal_infeasibility);
     if (have_dual_solution)
-      printf(
+      highsLogDev(
+          options.log_options, HighsLogType::kInfo,
           "getKktFailures:   dual infeasibility %8.3g / %8.3g     %8.3g / "
           "%8.3g     %8.3g / %8.3g\n",
           highs_info.max_dual_infeasibility,
           highs_info.max_relative_dual_infeasibility,
           max_col_dual_infeasibility, max_relative_col_dual_infeasibility,
           max_row_dual_infeasibility, max_relative_row_dual_infeasibility);
     if (get_residuals) {
-      printf("getKktFailures: primal residual      %8.3g / %8.3g\n",
-             highs_info.max_primal_residual_error,
-             highs_info.max_relative_primal_residual_error);
+      highsLogDev(options.log_options, HighsLogType::kInfo,
+                  "getKktFailures: primal residual      %8.3g / %8.3g\n",
+                  highs_info.max_primal_residual_error,
+                  highs_info.max_relative_primal_residual_error);
       if (have_dual_solution)
-        printf("getKktFailures:   dual residual      %8.3g / %8.3g\n",
-               highs_info.max_dual_residual_error,
-               highs_info.max_relative_dual_residual_error);
+        highsLogDev(options.log_options, HighsLogType::kInfo,
+                    "getKktFailures:   dual residual      %8.3g / %8.3g\n",
+                    highs_info.max_dual_residual_error,
+                    highs_info.max_relative_dual_residual_error);
     }
     if (!is_qp && have_dual_solution)
-      printf("getKktFailures: objective gap        %8.3g\n",
-             highs_info.primal_dual_objective_error);
+      highsLogDev(options.log_options, HighsLogType::kInfo,
+                  "getKktFailures: objective gap        %8.3g\n",
+                  highs_info.primal_dual_objective_error);
   }
-
   // Assign primal (and possibly dual) solution status according to
   // existence of primal and dual feasibilities
   //