Matrix structure created only once

Author: filikat

highs/ipm/hipo/factorhighs/FactorHiGHS.h

@@ -91,9 +91,7 @@ class FHsolver {
               const std::string& ordering = "metis");
 
   // Perform factorise phase of matrix given by rows, ptr, vals, and store
-  // numerical factorisation in object N. Matrix is moved into the object, so
-  // rows, ptr, vals are invalid afterwards.
-  // See ReturnValues.h for errors.
+  // numerical factorisation in object N. See ReturnValues.h for errors.
   Int factorise(const Symbolic& S, const std::vector<Int>& rows,
                 const std::vector<Int>& ptr, const std::vector<double>& vals);
 

highs/ipm/hipo/factorhighs/Factorise.cpp

@@ -29,8 +29,6 @@ Factorise::Factorise(const Symbolic& S, const std::vector<Int>& rowsA,
   // Input the symmetric matrix to be factorised in CSC format and the symbolic
   // factorisation coming from Analyse.
   // Only the lower triangular part of the matrix is used.
-  // The Factorise object takes ownership of the matrix; rowsA, ptrA and valA
-  // are not valid anymore.
 
   n_ = ptrA.size() - 1;
 
@@ -42,10 +40,10 @@ Factorise::Factorise(const Symbolic& S, const std::vector<Int>& rowsA,
     return;
   }
 
-  // take ownership of the matrix
-  rowsA_ = std::move(rowsA);
-  valA_ = std::move(valA);
-  ptrA_ = std::move(ptrA);
+  // Make a copy of the matrix to be factorised
+  rowsA_ = rowsA;
+  valA_ = valA;
+  ptrA_ = ptrA;
 
   // Permute the matrix.
   // This also removes any entry not in the lower triangle.