Move logger entirely within PDLPSolver

Author: jajhall

highs/pdlp/HiPdlpWrapper.cpp

@@ -30,11 +30,6 @@ HighsStatus solveLpHiPdlp(const HighsOptions& options, HighsTimer& timer,
   // Indicate that no imprecise solution has (yet) been found
   resetModelStatusAndHighsInfo(model_status, highs_info);
 
-  Logger logger;
-  logger.setLevel(options.log_dev_level);
-  logger.passHighsLogOptions(options.log_options);
-  logger.print_header();
-
   /*** Order of operations
    * Preprocess with HiPdlp
    * Scale with HiPdlp
@@ -43,7 +38,7 @@ HighsStatus solveLpHiPdlp(const HighsOptions& options, HighsTimer& timer,
    * Postprocess with HiPDLP
    * ***/
   // 2. Preprocess with HiPdlp
-  PDLPSolver pdlp(logger);
+  PDLPSolver pdlp;
   pdlp.setParams(options, timer);
   HighsLp preprocessed_lp;
   pdlp.passLp(&lp);

highs/pdlp/hipdlp/pdhg.cc

@@ -268,8 +268,6 @@ void PDLPSolver::postprocess(HighsSolution& solution) {
   logger_.info("Post-solve complete.");
 }
 
-PDLPSolver::PDLPSolver(Logger& logger) : logger_(logger) {}
-
 void PDLPSolver::solve(std::vector<double>& x, std::vector<double>& y) {
   Timer solver_timer;
 
@@ -887,6 +885,10 @@ HighsStatus PDLPSolver::PowerMethod(double& op_norm_sq) {
 }
 
 void PDLPSolver::setParams(const HighsOptions& options, HighsTimer& timer) {
+  logger_.setLevel(options.log_dev_level);
+  logger_.passHighsLogOptions(options.log_options);
+  logger_.print_header();
+
   params_.initialise();
   //  params.eta = 0; Not set in parse_options_file
   //  params.omega = 0; Not set in parse_options_file

highs/pdlp/hipdlp/pdhg.hpp

@@ -35,7 +35,6 @@
 // --- Classes ---
 class PDLPSolver {
  public:
-  PDLPSolver(Logger& logger);
   void setParams(const HighsOptions& options, HighsTimer& timer);
   void preprocessLp();
   void scaleProblem();
@@ -57,7 +56,7 @@ class PDLPSolver {
   HighsLp lp_;                  // The problem to solve
   const HighsLp* original_lp_;  // The original problem (for postsolve)
   PrimalDualParams params_;
-  Logger& logger_;
+  Logger logger_;
 
   int final_iter_count_ = 0;
   int original_num_col_;