Cleared out some redundant and debugging code

Author: jajhall

highs/lp_data/Highs.cpp

@@ -3983,7 +3983,6 @@ HighsStatus Highs::callSolveLp(HighsLp& lp, const string message) {
   assert(model_.lp_.a_matrix_.isColwise());
 
   // Solve the LP
-  HighsInt simplex_strategy = options_.simplex_strategy;
   return_status = solveLp(solver_object, message);
   // Extract the model status
   model_status_ = solver_object.model_status_;

highs/lp_data/HighsInterface.cpp

@@ -2896,17 +2896,6 @@ HighsStatus Highs::lpKktCheck(const HighsLp& lp, const std::string& message) {
             int(info.num_relative_dual_residual_errors),
             info.max_relative_dual_residual_error, dual_residual_tolerance);
       }
-      if (info.num_complementarity_violations) {
-        if (!this->options_.output_flag) {
-          printf(
-              "Highs::lpKktCheck With basis num_complementarity_violations = "
-              "%d\n",
-              int(info.num_complementarity_violations));
-          this->options_.output_flag = true;
-          this->writeSolution("", 1);
-          this->lpKktCheck(lp, message);
-        }
-      }
       assert(info.num_complementarity_violations == 0);
       assert(info.primal_dual_objective_error <= optimality_tolerance);
       if (have_residual_errors) {

highs/lp_data/HighsSolution.cpp

@@ -64,7 +64,7 @@ void getLpKktFailures(const HighsOptions& options, const HighsLp& lp,
                       HighsPrimalDualErrors& primal_dual_errors,
                       const bool get_residuals) {
   getKktFailures(options, false, lp, lp.col_cost_, solution, highs_info,
-                 get_residuals, basis.valid);
+                 get_residuals);
   getPrimalDualBasisErrors(options, lp, solution, basis, primal_dual_errors);
   getPrimalDualGlpsolErrors(options, lp, lp.col_cost_, solution,
                             primal_dual_errors);
@@ -73,7 +73,7 @@ void getLpKktFailures(const HighsOptions& options, const HighsLp& lp,
 void getKktFailures(const HighsOptions& options, const bool is_qp,
                     const HighsLp& lp, const std::vector<double>& gradient,
                     const HighsSolution& solution, HighsInfo& highs_info,
-                    const bool get_residuals, const bool basic_solution) {
+                    const bool get_residuals) {
   double primal_feasibility_tolerance = options.primal_feasibility_tolerance;
   double dual_feasibility_tolerance = options.dual_feasibility_tolerance;
   double primal_residual_tolerance = options.primal_residual_tolerance;
@@ -444,7 +444,7 @@ void getKktFailures(const HighsOptions& options, const bool is_qp,
     // Determine the sum of complementarity violations
     const bool have_values = getComplementarityViolations(
         lp, solution, optimality_tolerance, num_complementarity_violation,
-        max_complementarity_violation, basic_solution);
+        max_complementarity_violation);
     assert(have_values);
   }
 
@@ -955,8 +955,7 @@ bool getComplementarityViolations(const HighsLp& lp,
                                   const HighsSolution& solution,
                                   const double optimality_tolerance,
                                   HighsInt& num_complementarity_violation,
-                                  double& max_complementarity_violation,
-                                  const bool basic_solution) {
+                                  double& max_complementarity_violation) {
   num_complementarity_violation = kHighsIllegalComplementarityCount;
   max_complementarity_violation = kHighsIllegalComplementarityViolation;
   if (!solution.dual_valid) return false;

highs/lp_data/HighsSolution.h

@@ -82,8 +82,7 @@ void getLpKktFailures(const HighsOptions& options, const HighsLp& lp,
 void getKktFailures(const HighsOptions& options, const bool is_qp,
                     const HighsLp& lp, const std::vector<double>& gradient,
                     const HighsSolution& solution, HighsInfo& highs_info,
-                    const bool get_residuals,  // = false,
-                    const bool basic_solution = false);
+                    const bool get_residuals = false);
 
 void getVariableKktFailures(const double primal_feasibility_tolerance,
                             const double dual_feasibility_tolerance,
@@ -108,8 +107,7 @@ bool getComplementarityViolations(const HighsLp& lp,
                                   const HighsSolution& solution,
                                   const double optimality_tolerance,
                                   HighsInt& num_complementarity_violations,
-                                  double& max_complementarity_violation,
-                                  const bool basic_solution = false);
+                                  double& max_complementarity_violation);
 
 bool computeDualObjectiveValue(const HighsModel& model,
                                const HighsSolution& solution,