Skip to content

Commit f0f95a5

Browse files
committed
remove 1.11 ortools patch
1 parent b161f68 commit f0f95a5

File tree

2 files changed

+27
-24
lines changed

2 files changed

+27
-24
lines changed

CMakeLists.txt

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ endif()
5757
# message("CMAKE_CXX_COMPILER_ID is ${CMAKE_CXX_COMPILER_ID}")
5858
if (CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
5959
message(STATUS "Compiler is IntelLLVM")
60-
if (CMAKE_HOST_WIN32 AND CMAKE_VERSION VERSION_LESS "3.23.0")
60+
if (CMAKE_HOST_WIN32 AND CMAKE_VERSION VERSION_LESS "3.23.0")
6161
message(FATAL_ERROR "Need at least CMake 3.23 for IntelLLVM support of IntelDPCPP package on Windows")
6262
elseif(CMAKE_VERSION VERSION_LESS "3.23.0")
6363
message(FATAL_ERROR "CMake 3.20.5 is the minimum recommended for IntelLLVM on Linux")
@@ -121,9 +121,9 @@ endif()
121121

122122
option(HIGHS_COVERAGE "Activate the code coverage compilation" OFF)
123123

124-
# Address | Thread | Leak
124+
# Address | Thread | Leak
125125
# Linux atm
126-
# Only Debug is theted atm
126+
# Only Debug atm
127127
# See below for RelWithDeb info, todo test wip
128128
set(DEBUG_MEMORY "Off" CACHE STRING "Sanitizers")
129129

@@ -137,7 +137,7 @@ message(STATUS "Build pdlp with GPU: ${CUPDLP_GPU}")
137137
option(CUPDLP_FIND_CUDA "Build pdlp with GPU" OFF)
138138
message(STATUS "Use FindCUDAConf: ${CUPDLP_FIND_CUDA}")
139139

140-
if(CUPDLP_GPU AND CMAKE_VERSION VERSION_LESS "3.25.0")
140+
if(CUPDLP_GPU AND CMAKE_VERSION VERSION_LESS "3.25.0")
141141
message("CUPDLP FindCUDAConf requires CMake version minumum 3.24. Please use a higher version of CMake.")
142142
endif()
143143

@@ -158,11 +158,11 @@ if (CUPDLP_GPU)
158158
# With FindCUDAConf.cmake
159159
# Need to have the CUDA_HOME environment variable set.
160160
include(FindCUDAConf)
161-
else()
161+
else()
162162
# Without FindCUDAConf.cmake
163163
enable_language(CUDA)
164164
find_package(CUDAToolkit REQUIRED)
165-
165+
166166
set(CUDA_LIBRARY-NOTFOUND, OFF)
167167
set(CUDA_LIBRARY CUDA::cudart CUDA::cublas CUDA::cusparse)
168168
endif()
@@ -205,7 +205,7 @@ if (BUILD_CXX)
205205
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR})
206206
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR})
207207
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR})
208-
# for multi-config build system (e.g. xcode)
208+
# for multi-config build system (e.g. xcode)
209209
foreach(OutputConfig IN LISTS CMAKE_CONFIGURATION_TYPES)
210210
string(TOUPPER ${OutputConfig} OUTPUTCONFIG)
211211
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_BINARY_DIR}/${OutputConfig}/${CMAKE_INSTALL_LIBDIR})
@@ -244,14 +244,14 @@ if (BUILD_CXX)
244244
option(STDCALL "Build highs with the __stdcall convention" OFF)
245245
endif()
246246

247-
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR
248-
CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR
249-
CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
247+
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR
248+
CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR
249+
CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
250250
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
251-
# elseif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
251+
# elseif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
252252
# not recognised by cl
253-
# set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /std:c++11")
254-
endif()
253+
# set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /std:c++11")
254+
endif()
255255

256256
# Basic type
257257
include(CMakePushCheckState)
@@ -275,7 +275,7 @@ if (BUILD_CXX)
275275
check_type_size("int *" SIZEOF_INT_P LANGUAGE CXX)
276276
message(STATUS "Found int * size: ${SIZEOF_INT_P}")
277277
cmake_pop_check_state()
278-
278+
279279
# Use current CMAKE_C_FLAGS and CMAKE_CXX_FLAGS when checking for IPO support,
280280
# instead of defaults: https://cmake.org/cmake/help/latest/policy/CMP0138.html
281281
if(MSVC AND BUILD_SHARED_LIBS)
@@ -293,7 +293,7 @@ if (BUILD_CXX)
293293
set(ipo_supported NO)
294294
message(STATUS "IPO / LTO not currently supported building HiGHS on MinGW")
295295
else()
296-
if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
296+
if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
297297
cmake_policy(SET CMP0138 NEW)
298298
endif()
299299

@@ -371,7 +371,7 @@ else()
371371
HIGHS_HAVE_BUILTIN_CLZ)
372372
endif()
373373

374-
set(CMAKE_MACOSX_RPATH ON)
374+
set(CMAKE_MACOSX_RPATH TRUE)
375375

376376
if (BUILD_DOTNET)
377377
set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
@@ -428,7 +428,7 @@ endif()
428428

429429
# For debug of cuda locally
430430

431-
# does not work with older CMake
431+
# does not work with older CMake
432432
# add_compile_options("$<$<AND:$<CONFIG:Debug,RelWithDebInfo>,$<COMPILE_LANGUAGE:CUDA>>:-G>")
433433

434434
# add_compile_options("$<$<COMPILE_LANGUAGE:CUDA>:-G>")
@@ -453,7 +453,7 @@ if(MSVC)
453453
add_compile_options("$<$<COMPILE_LANGUAGE:C,CXX>:-D_CRT_SECURE_NO_WARNINGS>")
454454
add_compile_options("$<$<COMPILE_LANGUAGE:C,CXX>:/MP>")
455455

456-
# Try to split large pdb files into objects.
456+
# Try to split large pdb files into objects.
457457
# https://github.com/tensorflow/tensorflow/issues/31610
458458
# add_compile_options("/Z7")
459459
# add_link_options("/DEBUG:FASTLINK")
@@ -614,11 +614,11 @@ if(FAST_BUILD AND HIGHS_COVERAGE)
614614
message(STATUS "Building in coverage mode")
615615

616616
# Enable coverage flags
617-
add_compile_options(-O0)
618-
add_compile_options(--coverage)
619-
add_compile_options(-fprofile-update=atomic)
617+
add_compile_options(-O0)
618+
add_compile_options(--coverage)
619+
add_compile_options(-fprofile-update=atomic)
620620

621-
add_link_options(-O0)
621+
add_link_options(-O0)
622622
add_link_options(--coverage) # Ensure coverage data is linked correctly
623623

624624
find_program(GCOV_PATH gcov)

highs/CMakeLists.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,11 @@ if(NOT FAST_BUILD)
5151
endif()
5252

5353
# set the install rpath to the installed destination
54-
set_target_properties(libhighs PROPERTIES INSTALL_RPATH
55-
"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}")
54+
if(APPLE)
55+
set_target_properties(libhighs PROPERTIES INSTALL_RPATH "@loader_path")
56+
elseif (UNIX)
57+
set_target_properties(libhighs PROPERTIES INSTALL_RPATH "$ORIGIN")
58+
endif()
5659

5760
# install the header files of highs
5861
foreach(file ${headers})

0 commit comments

Comments
 (0)