feat: updated error handling for tiles endpoint

Author: JanssenBrm

app/middleware/error_handling.py

@@ -1,3 +1,4 @@
+from typing import Any
 from fastapi import Request, status
 from fastapi.exceptions import RequestValidationError
 from fastapi.responses import JSONResponse
@@ -40,15 +41,24 @@ async def generic_exception_handler(request: Request, exc: Exception):
     )
 
 
+def _parse_validation_error(err: Any):
+    if "ctx" in err:
+        del err["ctx"]
+    return err
+
+
 async def validation_exception_handler(request: Request, exc: RequestValidationError):
 
+    logger.error(f"Request validation error: {exc.__class__.__name__}: {exc}")
     content = ErrorResponse(
         error_code="VALIDATION_ERROR",
         message="Request validation failed.",
-        details={"errors": exc.errors()},
+        details={"errors": [_parse_validation_error(error) for error in exc.errors()]},
         request_id=correlation_id_ctx.get(),
     )
 
+    logger.error(content.dict())
+
     return JSONResponse(
         status_code=status.HTTP_422_UNPROCESSABLE_ENTITY, content=content.dict()
     )

app/routers/tiles.py

@@ -3,6 +3,8 @@
 from geojson_pydantic import GeometryCollection, Polygon
 from loguru import logger
 
+from app.error import DispatcherException, ErrorResponse, InternalException
+from app.middleware.error_handling import get_dispatcher_error_response
 from app.schemas.tiles import GridTypeEnum, TileRequest
 from app.services.tiles.base import split_polygon_by_grid
 
@@ -54,7 +56,18 @@
                     }
                 }
             },
-        }
+        },
+        InternalException.http_status: {
+            "description": "Internal server error",
+            "model": ErrorResponse,
+            "content": {
+                "application/json": {
+                    "example": get_dispatcher_error_response(
+                        InternalException(), "request-id"
+                    )
+                }
+            },
+        },
     },
 )
 def split_in_tiles(
@@ -90,11 +103,12 @@ def split_in_tiles(
     try:
         logger.debug(f"Splitting tiles in a {payload.grid} formation")
         return split_polygon_by_grid(payload.aoi, payload.grid)
+    except DispatcherException as de:
+        raise de
     except Exception as e:
-        logger.exception(
-            f"An error occurred while calculating tiles for {payload.grid}"
+        logger.error(
+            f"An error occurred while calculating tiles for {payload.grid}: {e}"
         )
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"An error occurred while calculating tiles for {payload.grid}: {e}",
+        raise InternalException(
+            message=f"An error occurred while calculating tiles for {payload.grid}"
         )