Remove references to WAF aliases. Feature not fullyed developed. Issue identifed by LGTM. Checked with Arshan and he confirmed it should be removed.

kwwall · kwwall · commit 120ff02fe530 · 2020-06-07T13:27:52.000-04:00
diff --git a/configuration/esapi/waf-policy.xsd b/configuration/esapi/waf-policy.xsd
diff --git a/src/main/java/org/owasp/esapi/waf/configuration/AppGuardianConfiguration.java b/src/main/java/org/owasp/esapi/waf/configuration/AppGuardianConfiguration.java
@@ -77,11 +77,6 @@ public class AppGuardianConfiguration {
 	public static final String JAVASCRIPT_TARGET_TOKEN = "##1##";
 	public static final String JAVASCRIPT_REDIRECT = "<html><body><script>document.location='" + JAVASCRIPT_TARGET_TOKEN + "';</script></body></html>";
 
-	/*
-	 * The aliases declared in the beginning of the config file.
-	 */
-	private HashMap<String,Object> aliases;
-
 	/*
 	 * Fail response settings.
 	 */
@@ -114,8 +109,6 @@ public AppGuardianConfiguration() {
 		afterBodyRules = new ArrayList<Rule>();
 		beforeResponseRules = new ArrayList<Rule>();
 		cookieRules = new ArrayList<Rule>();
-
-		aliases = new HashMap<String,Object>();
 	}
 
 	/*
@@ -160,9 +153,6 @@ public void setDefaultResponseCode(int defaultResponseCode) {
 		this.defaultResponseCode = defaultResponseCode;
 	}
 
-	public void addAlias(String key, Object obj) {
-		aliases.put(key, obj);
-	}
 
 	public List<Rule> getBeforeBodyRules() {
 		return beforeBodyRules;
diff --git a/src/main/java/org/owasp/esapi/waf/configuration/ConfigurationParser.java b/src/main/java/org/owasp/esapi/waf/configuration/ConfigurationParser.java
@@ -94,7 +94,6 @@ public static AppGuardianConfiguration readConfigurationFile(InputStream stream,
 			doc = parser.build(stream);
 			root = doc.getRootElement();
 
-			Element aliasesRoot = root.getFirstChildElement("aliases");
 			Element settingsRoot = root.getFirstChildElement("settings");
 			Element authNRoot = root.getFirstChildElement("authentication-rules");
 			Element authZRoot = root.getFirstChildElement("authorization-rules");
@@ -106,30 +105,11 @@ public static AppGuardianConfiguration readConfigurationFile(InputStream stream,
 			Element beanShellRoot = root.getFirstChildElement("bean-shell-rules");
 			
 			
-			/**
-			 * Parse the 'aliases' section.
-			 */
-			if ( aliasesRoot != null ) {
-				Elements aliases = aliasesRoot.getChildElements("alias");
-	
-				for(int i=0;i<aliases.size();i++) {
-					Element e = aliases.get(i);
-					String name = e.getAttributeValue("name");
-					String type = e.getAttributeValue("type");
-					String value = e.getValue();
-					if ( REGEX.equals(type) ) {
-						config.addAlias(name, Pattern.compile(value));
-					} else {
-						config.addAlias(name, value);
-					}
-				}
-			}
-			
 			/**
 			 * Parse the 'settings' section.
 			 */
 			if ( settingsRoot == null ) {
-				throw new ConfigurationException("", "The <settings> section is required");
+                throw new ConfigurationException("", "The <settings> section is required");
 			} else if ( settingsRoot != null ) {
 				
 				
