Skip to content

Commit 23608fc

Browse files
committed
Converted String array explicity to string, which is probably what was intended in exception messages. Otherwise end up with something that looks like '[Ljava.lang.String;@7825ed4c' which is not very helpful.
1 parent 9be40d4 commit 23608fc

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/main/java/org/owasp/esapi/reference/accesscontrol/DelegatingACR.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import java.lang.reflect.Modifier;
55
import java.util.Iterator;
66
import java.util.Vector;
7+
import java.util.Arrays;
78

89
import org.apache.commons.collections4.iterators.ArrayListIterator;
910

@@ -25,12 +26,12 @@ public void setPolicyParameters(DynaBeanACRParameter policyParameter) {
2526
} catch (SecurityException e) {
2627
throw new IllegalArgumentException(e.getMessage() +
2728
" delegateClass.delegateMethod(parameterClasses): \"" +
28-
delegateClassName + "." + methodName + "(" + parameterClassNames +
29+
delegateClassName + "." + methodName + "(" + Arrays.toString(parameterClassNames) +
2930
")\" must be public.", e);
3031
} catch (NoSuchMethodException e) {
3132
throw new IllegalArgumentException(e.getMessage() +
3233
" delegateClass.delegateMethod(parameterClasses): \"" +
33-
delegateClassName + "." + methodName + "(" + parameterClassNames +
34+
delegateClassName + "." + methodName + "(" + Arrays.toString(parameterClassNames) +
3435
")\" does not exist.", e);
3536
}
3637

@@ -42,14 +43,14 @@ public void setPolicyParameters(DynaBeanACRParameter policyParameter) {
4243
throw new IllegalArgumentException(
4344
" Delegate class \"" + delegateClassName +
4445
"\" must be concrete, because method " +
45-
delegateClassName + "." + methodName + "(" + parameterClassNames +
46+
delegateClassName + "." + methodName + "(" + Arrays.toString(parameterClassNames) +
4647
") is not static.", ex);
4748
} catch (IllegalAccessException ex) {
4849
new IllegalArgumentException(
4950
" Delegate class \"" + delegateClassName +
5051
"\" must must have a zero-argument constructor, because " +
5152
"method delegateClass.delegateMethod(parameterClasses): \"" +
52-
delegateClassName + "." + methodName + "(" + parameterClassNames +
53+
delegateClassName + "." + methodName + "(" + Arrays.toString(parameterClassNames) +
5354
")\" is not static.", ex);
5455
}
5556
} else {

0 commit comments

Comments
 (0)