Skip to content

Commit 82aaa7f

Browse files
committed
Fix minor typos, provide CVE IDs, and other minor corrections.
1 parent 87df07b commit 82aaa7f

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed
19 Bytes
Binary file not shown.
-9 Bytes
Binary file not shown.

documentation/esapi4java-core-2.3.0.0-release-notes.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Issue # GitHub Issue Title
7070

7171
-----------------------------------------------------------------------------
7272

73-
1) This likely will be the LAST ESAPI release supporting Java 7. There are just some vulnerabilities (notably a DoS one in Neko HtmlUnit that does not yet have an assigned CVE) that because they are transitive dependencies, that we simply cannot remediate without at least moving on to Java 8 as the minimally supported JDK. Please plan accordingly.
73+
1) This likely will be the LAST ESAPI release supporting Java 7. There are just some vulnerabilities (notably a DoS one in Neko HtmlUnit that was assigned CVE-2022-28366 after the ESAPI 2.3.0.0 release) that because they are transitive dependencies, that we simply cannot remediate without at least moving on to Java 8 as the minimally supported JDK. Please plan accordingly.
7474

7575
2) If you are not upgrading to ESAPI release 2.3.0.0 from 2.2.3.1 (the previous release), then you NEED to read at least the release notes in 2.2.3.1 and ideally, all the ones in all the previous ESAPI release notes from where you are updating to 2.3.0.0. In particular, if you were using ESAPI 2.2.1.0 or earlier, you need to see those ESAPI release notes in regards to changes in the ESAPI.Logger property.
7676

@@ -82,8 +82,9 @@ Issue # GitHub Issue Title
8282

8383
5) A vulnerability found by GitHub Security Lab that is an example of CWE-22 [Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')], was discovered by GHSL security researcher Jaroslav Lobačevski. You can find details of it under "documentation/GHSL-2022-008_The_OWASP_Enterprise_Security_API.md" or "documentation/GHSL-2022-008_The_OWASP_Enterprise_Security_API.pdf" on ESAPI's GitHub repo or from the ESAPI source zip or tarball files associated with this (or later) release. This currently does not have a CVE associated with it. We likely will leave it to GHSL to determine if they want to file a CVE for it or not.
8484

85-
6) There remains one known unpatched, potentially exploitable vulnerability (a DoS vulnerability in the transitive dependency Neko HtmlUnit) in ESAPI 2.3.0.0. To our knowledge, that vulnerability has not yet been assigned a CVE, but it is fixed in certain versions of Neko HtmlUnit after release 2.24.0. However, release 2.24.0 is the last Neko HtmlUnit release that supports Java 7 and thus is the latest one that we can use. That vulnerability is patched only fixed in a version of Neko HtmlUnit that was compiled with Java 8. Since ESAPI (as of release 2.3.0.0) only supports Java 7, we are currently unable to patch to remediate this DoS vulnerability. (This is why we are currently committed for this 2.3.0.0 release to be last release at least to support Java 7). The ESAPI team plans to release a 2.4.0.0 release that will require Java 8 or later as the minimal JDK, and with that release, we will update to AntiSamy 1.7.0 (which requires Java 8) and which uses Neko HtmlUnit 2.60.0 (which also requires Java 8 or later) and that addresses the DoS vulnerability. For further information, see the JUnit test testNekoDOSWithAnHTMLComment in "src/test/java/org/owasp/esapi/reference/validation/HTMLValidationRuleCleanTest.java". (Note that currently, this JUnit test is annotated as '@Ignore' since it would not pass under Java 7 and using Neko HtmlUnit 2.24.0.)
85+
6) There remains one known unpatched, potentially exploitable vulnerability (a DoS vulnerability in the transitive dependency Neko HtmlUnit) in ESAPI 2.3.0.0. That vulnerability was later assigned CVE-20222-28366, but it is fixed in certain versions of Neko HtmlUnit after release 2.24.0. However, release 2.24.0 is the last Neko HtmlUnit release that supports Java 7 and thus is the latest one that we can use. That vulnerability is patched only fixed in a version of Neko HtmlUnit that was compiled with Java 8. Since ESAPI (as of release 2.3.0.0) only supports Java 7, we are currently unable to patch to remediate this DoS vulnerability. (This is why we are currently committed for this 2.3.0.0 release to be last release at least to support Java 7). The ESAPI team plans to release a 2.4.0.0 release that will require Java 8 or later as the minimal JDK, and with that release, we will update to AntiSamy 1.7.0 (which requires Java 8) and which uses Neko HtmlUnit 2.60.0 (which also requires Java 8 or later) and that addresses the DoS vulnerability. For further information, see the JUnit test testNekoDOSWithAnHTMLComment in "src/test/java/org/owasp/esapi/reference/validation/HTMLValidationRuleCleanTest.java". (Note that currently, this JUnit test is annotated as '@Ignore' since it would not pass under Java 7 and using Neko HtmlUnit 2.24.0.)
8686

87+
7) *NEW* It later came to our attention that there was a unknown XSS vulnerability in AntiSamy [later identified as CVE-2022-29577] that was patched in AntiSamy 1.6.8, which was not available at the time of the ESAPI 2.3.0.0 release. (Someone on the AntiSamy team probably told me about this, but I just forgot. Sorry ESAPI folks!)
8788

8889
NOTE: We plan on issuing an updated README.md and updated security bulletins on #3 and #4 soon, but we wanted to focus on getting the patches out rather than getting the documentation out. This probably will not be in a separate release, but we will announce in on the ESAPI Users and ESAPI Dev Google lists once we drop them on our GitHub repo under the "documentation" folder.
8990

documentation/esapi4java-core-2.4.0.0-release-notes.txt

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Release notes for ESAPI 2.4.0.0
44
-Kevin W. Wall <[email protected]>
55
-Matt Seil <[email protected]>
66

7-
Previous release: ESAPI 2.3.0.0, 2022-04-18
7+
Previous release: ESAPI 2.3.0.0, 2022-04-17
88

99
Important Announcement
1010
----------------------
@@ -13,7 +13,7 @@ Do NOT: Do NOT use GitHub Issues to ask questions about this of future releases
1313

1414
Executive Summary: Important Things to Note for this Release
1515
------------------------------------------------------------
16-
This is a very important ESAPI release as it is the first release to be FULLY INCOMPATIBLE WITH JAVA 1.7! This was expedited in response to some dependencies to resolve prior CVEs (see release notes in 2.3.0.0) that could not be updated as those versions required a JDK > 1.7 which we were forced to. The slightly premature update to java 1.8 is done to address CVE-2022-28366 that had to be fixed with a version of the transitive depenedency via AntiSamy of NekoHTML that was java 1.8+ only. (Wrapped into issue #682) It is important to note that the solution to fix CVE-2022-28366 does not exist in ESAPI 2.3.0.0 and there is no intention to fix it for Java 1.7.
16+
This is a very important ESAPI release as it is the first release to be FULLY INCOMPATIBLE WITH JAVA 1.7! This was expedited in response to some dependencies to resolve prior CVEs (see release notes in 2.3.0.0) that could not be updated as those versions required a JDK > 1.7 which we were forced to. The slightly premature update to Java 1.8 is done to address CVE-2022-28366 that had to be fixed with a version of the transitive depenedency via AntiSamy of NekoHTML that was Java 1.8+ only. (Wrapped into issue #682) It is important to note that the solution to fix CVE-2022-28366 does not exist in ESAPI 2.3.0.0 and there is no intention to fix it for Java 1.7.
1717

1818
=================================================================================================================
1919

@@ -26,37 +26,37 @@ ESAPI 2.3.0.0 release (previous release):
2626

2727
ESAPI 2.4.0.0 release (current / new release):
2828
212 Java source files
29-
4325 JUnit tests in 136 Java source files (1 test ignored)
29+
4326 JUnit tests in 136 Java source files
3030

3131
3 GitHub Issues closed in this release, including those we've decided not to fix (marked 'wontfix' and 'falsepositive').
32-
[Reference: https://github.com/ESAPI/esapi-java-legacy/issues?q=is%3Aissue+state%3Aclosed+updated%3A%3E%3D2021-05-07]
32+
[Reference: https://github.com/ESAPI/esapi-java-legacy/issues?q=is%3Aissue+state%3Aclosed+updated%3A%3E%3D2022-04-17]
3333

3434
Issue # GitHub Issue Title
3535
----------------------------------------------------------------------------------------------
36-
682 Update baseline to java 1.8
37-
679 Completely remove support for fixed IVs and throw a ConfigurationException if encountered.
38-
672 (wontfix) HTMLEntityCodec Bug Decoding "Left Angular Bracket" Symbol
3936
644 Do not include a logging implementation as a dependency slf4j-simple
40-
41-
37+
672 (wontfix) HTMLEntityCodec Bug Decoding "Left Angular Bracket" Symbol
38+
679 Completely remove support for fixed IVs and throw a ConfigurationException if encountered.
39+
682 Update baseline to Java 1.8
4240

4341
-----------------------------------------------------------------------------
4442

4543
Changes Requiring Special Attention
4644

4745
-----------------------------------------------------------------------------
4846

49-
1) This is the first ESAPI release that does not support java 1.7. This library will no longer work if youre application is that old.
47+
1) This is the first ESAPI release that does not support Java 1.7. This library will no longer work if your application is that old.
5048

5149
!!!!! VULNERABILITY ALERTS !!!!!
5250

53-
2) This release closes our implementation of fixes outlined in CVE-2022-28366 from AntiSamy. This was a DoS vulnerability discovered in HtmlUnit-Neko affecting all versions up to 2.26. Details from MITRE are here: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2022-28366
51+
2) This release fixes the known vulnerability ESAPI 2.3.0.0 that had to wait until we supported Java 8 to be patched. The patch was in Neko-HtmlUntil and was fixed in version 2.27, which required Java 8 or later. It was a transitive dependency via AntiSamy and we picked it up by updating to AntiSamy 1.6.8. This was a DoS vulnerability discovered in HtmlUnit-Neko affecting all versions up to 2.26. Full details from MITRE are here: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2022-28366
52+
53+
3) This release also patches the (known, but forgotten?) XSS vulnerability ESAPI 2.3.0.0 in AntiSamy 1.6.7 but was fixed in 1.6.8. (The 2.3.0.0 release notes have been updated to mention this.) Full details from MITRE are here: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2022-29577
5454

5555
-----------------------------------------------------------------------------
5656

5757
Developer Activity Report (Changes between release 2.3.0.0 and 2.4.0.0, i.e., between 2022-04-17 and 2022-04-24)
5858

59-
Special thanks to Dave Wichers and Sebastian Pessaro from AntiSamy for their work to close CVE-2022-28366.
59+
Special thanks to Dave Wichers and Sebastian Pessaro from AntiSamy for their work to provide version 1.6.8 which patched 2 CVEs.
6060
Special thanks to Jeremiah J. Stacey for his work to update and prep the library to support java 1.8. (He literally created the PR the day after 2.3.0.0's release.)
6161
Special thanks to Kevin Wall for support in pushing out this release.
6262

@@ -65,7 +65,7 @@ Special thanks to Kevin Wall for support in pushing out this release.
6565

6666
CHANGELOG: Create your own. May we suggest:
6767

68-
git log --stat --since=2021-05-07 --reverse --pretty=medium
68+
git log --stat --since=2022-04-17 --reverse --pretty=medium
6969

7070
or clone the ESAPI/esapi-java-legacy repo and then run
7171

@@ -138,11 +138,10 @@ Direct and Transitive Runtime and Test Dependencies:
138138
-----------------------------------------------------------------------------
139139

140140
Acknowledgments:
141-
* A special shout out to Jaroslav Lobačevski, a security researcher at GitHub Security Labs, who notified the ESAPI team via responsible disclosure and allowed us sufficient time to address GHSL-2022-008.
142-
* A huge hat-tip to Dave Wichers and Sebastian Passaro for promptly addressing vulnerabilities in AntiSamy, many of which were caused by poorly maintained dependencies of AntiSamy.
143-
* A special thanks to Matt Seil, Jeremiah Stacey, and all the ESAPI contributors whom I've undoubtedly forgotten.
141+
* A huge hat-tip to Dave Wichers and Sebastian Passaro for promptly releasing AntiSamy 1.6.8 which simplified this releaese
142+
* A special thanks to Jeremiah Stacey to wrote the PR #683, that addressed the updates for Java 8.
144143
* Finally, to all the ESAPI users who make our efforts worthwhile. This is for you.
145144

146145
A special thanks to the ESAPI community from the ESAPI project co-leaders:
147146
Kevin W. Wall (kwwall) <== The irresponsible party for these release notes!
148-
Matt Seil (xeno6696)
147+
Matt Seil (xeno6696) <== (Him too, this time! :)

0 commit comments

Comments
 (0)