Waf Action Tests

Adding tests for the current behavior of the WAF Action classes.

Author: jeremiahjstacey

src/test/java/org/owasp/esapi/waf/actions/ActionTest.java

@@ -0,0 +1,25 @@
+package org.owasp.esapi.waf.actions;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class ActionTest {
+
+    @Test
+    public void assertDefaultState() {
+        Action uit = new Action() {};
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+    }
+    
+    @Test
+    public void assertSettersGetters() {
+        Action uit = new Action() {};
+        uit.setActionNecessary(false);
+        uit.setFailed(false);
+        assertFalse(uit.failedRule());
+        assertFalse(uit.isActionNecessary());
+    }
+}

src/test/java/org/owasp/esapi/waf/actions/BlockActionTest.java

@@ -0,0 +1,26 @@
+package org.owasp.esapi.waf.actions;
+
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class BlockActionTest {
+
+    @Test
+    public void assertDefaultState() {
+        BlockAction uit = new BlockAction();
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+    }
+    
+    @Test
+    public void assertSettersGetters_DO_NOTHING() {
+        BlockAction uit = new BlockAction();
+        uit.setActionNecessary(false);
+        uit.setFailed(false);
+        
+        //Beautiful....
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+    }
+}

src/test/java/org/owasp/esapi/waf/actions/DefaultActionTest.java

@@ -0,0 +1,26 @@
+package org.owasp.esapi.waf.actions;
+
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class DefaultActionTest {
+
+    @Test
+    public void assertDefaultState() {
+        DefaultAction uit = new DefaultAction();
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+    }
+    
+    @Test
+    public void assertSettersGetters_DO_NOTHING() {
+        DefaultAction uit = new DefaultAction();
+        uit.setActionNecessary(false);
+        uit.setFailed(false);
+        
+        //Beautiful....
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+    }
+}

src/test/java/org/owasp/esapi/waf/actions/DoNothingActionTest.java

@@ -0,0 +1,32 @@
+package org.owasp.esapi.waf.actions;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class DoNothingActionTest {
+
+    @Test
+    public void assertDefaultState() {
+        DoNothingAction uit = new DoNothingAction();
+        assertTrue(uit.failedRule());
+        assertFalse(uit.isActionNecessary());
+    }
+    
+    @Test
+    public void assertSetGetFailed() {
+        DoNothingAction uit = new DoNothingAction();
+        uit.setFailed(false);
+        assertFalse(uit.failedRule());
+    }
+    
+    @Test
+    public void assertSetGetActionNecessary_DOES_NOTHING() {
+        DoNothingAction uit = new DoNothingAction();
+        uit.setActionNecessary(true);
+        
+        // Room for improvement.
+        assertFalse(uit.isActionNecessary());
+    }
+}

src/test/java/org/owasp/esapi/waf/actions/RedirectActionTest.java

@@ -0,0 +1,30 @@
+package org.owasp.esapi.waf.actions;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class RedirectActionTest {
+
+    @Test
+    public void assertDefaultState() {
+        RedirectAction uit = new RedirectAction();
+        assertTrue(uit.failedRule());
+        assertTrue(uit.isActionNecessary());
+        assertNull(uit.getRedirectURL());
+    }
+    
+    @Test
+    public void assertSettersGetters() {
+        RedirectAction uit = new RedirectAction();
+        uit.setActionNecessary(false);
+        uit.setFailed(false);
+        uit.setRedirectURL("http://going_nowhere.com");
+        assertFalse(uit.failedRule());
+        assertFalse(uit.isActionNecessary());
+        assertEquals("http://going_nowhere.com", uit.getRedirectURL());
+    }
+}