JavaLogFactory Failed Configuration Load Test

Updating the JavaLogFactory to have a delegate static method for loading
the configuration.  Allowing the LogManager to be provided as an argument
to avoid the need for verbose mocking and setup in the test scope.

Adding a test that asserts that Standard Error stream is provided the
expected error content if the configuration cannot be resolved.

Author: jeremiahjstacey

src/main/java/org/owasp/esapi/logging/java/JavaLogFactory.java

@@ -71,12 +71,20 @@ public class JavaLogFactory implements LogFactory {
 
         LOG_BRIDGE = new JavaLogBridgeImpl(JAVA_LOG_APPENDER, JAVA_LOG_SCRUBBER, levelLookup);
 
-        /*
+        readLoggerConfiguration(LogManager.getLogManager());
+    }
+    
+    /**
+     * Attempts to load the expected property file path into the provided LogManager reference.
+     * @param logManager LogManager which is being configured.
+     */
+    /*package*/ static void readLoggerConfiguration(LogManager logManager) {
+    	/*
          * This will load the logging properties file to control the format of the output for Java logs.
          */
         try (InputStream stream = JavaLogFactory.class.getClassLoader().
         		getResourceAsStream("esapi-java-logging.properties")) {
-        	LogManager.getLogManager().readConfiguration(stream);
+        	logManager.readConfiguration(stream);
         } catch (IOException ioe) {
         	System.err.print(new IOException("Failed to load esapi-java-logging.properties.", ioe));        	
         }

src/test/java/org/owasp/esapi/logging/java/JavaLogFactoryTest.java

@@ -18,18 +18,19 @@
 import static org.junit.Assert.assertTrue;
 
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.PrintStream;
 import java.util.List;
-import java.util.concurrent.atomic.AtomicReference;
+import java.util.logging.LogManager;
 
 import org.junit.Assert;
-import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TestName;
 import org.junit.runner.RunWith;
 import org.mockito.ArgumentCaptor;
+import org.mockito.Mockito;
 import org.owasp.esapi.Logger;
 import org.owasp.esapi.logging.appender.LogAppender;
 import org.owasp.esapi.logging.appender.LogPrefixAppender;
@@ -46,30 +47,42 @@
 public class JavaLogFactoryTest {
 	@Rule
     public TestName testName = new TestName();
-	
+
 	@Test
-	@Ignore("Work In Progress")
 	public void testIOExceptionOnMissingConfiguration() throws Exception {
-		org.junit.Assert.fail("Unimplemented!");
-		
-		IOException originException = new IOException(testName.getMethodName());
-		final AtomicReference<IOException> stdErrOut = new AtomicReference<IOException>();
+		final IOException originException = new IOException(testName.getMethodName());
 
-		//FIXME Mock static so that java.util.logging.LogManager.readConfiguration(any(java.io.InputStream.class) throws IOException
-		
+		LogManager testLogManager = new LogManager() {
+			@Override
+			public void readConfiguration(InputStream ins) throws IOException, SecurityException {
+				throw originException;
+			}
+		};
+
+		OutputStream nullOutputStream = new OutputStream() {
+			@Override
+			public void write(int b) throws IOException {
+				//No Op
+			}
+		};
 
-		System.setErr(new PrintStream(new OutputStream() {
-            public void write(int b) {
-                //FIXME:  How do I capture the object here?
-            }
-        }));
+		ArgumentCaptor<Object> stdErrOut = ArgumentCaptor.forClass(Object.class);
 
-		IOException actual = stdErrOut.get();
-		assertTrue(actual != null);
-		assertTrue(originException.equals(actual.getCause()));
-		assertEquals("Failed to load esapi-java-logging.properties.", actual.getMessage());
+		try (PrintStream errPrinter = new PrintStream(nullOutputStream)) {
+			PrintStream spyPrinter = PowerMockito.spy(errPrinter);
+			Mockito.doCallRealMethod().when(spyPrinter).print(stdErrOut.capture());
+			System.setErr(spyPrinter);
+
+			JavaLogFactory.readLoggerConfiguration(testLogManager);
+
+			Object writeData = stdErrOut.getValue();
+			assertTrue(writeData instanceof IOException);
+			IOException actual = (IOException) writeData;
+			assertEquals(originException, actual.getCause());
+			assertEquals("Failed to load esapi-java-logging.properties.", actual.getMessage());
+		}
 	}
-	
+
     @Test
     public void testCreateLoggerByString() {
         Logger logger = new JavaLogFactory().getLogger("test");