Skip to content

Commit 7bbbd1a

Browse files
authored
Merge pull request #1372 from peverwhee/rrtmgp-sw
cam6_4_119: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces
2 parents 3a7a24d + d92e3e4 commit 7bbbd1a

File tree

8 files changed

+176
-712
lines changed

8 files changed

+176
-712
lines changed

.gitmodules

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
[submodule "atmos_phys"]
3030
path = src/atmos_phys
3131
url = https://github.com/ESCOMP/atmospheric_physics
32-
fxtag = atmos_phys0_17_002
32+
fxtag = atmos_phys0_17_003
3333
fxrequired = AlwaysRequired
3434
fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
3535

@@ -76,13 +76,6 @@
7676
fxrequired = AlwaysRequired
7777
fxDONOTUSEurl = https://github.com/ESCOMP/HEMCO_CESM.git
7878

79-
[submodule "rte-rrtmgp"]
80-
path = src/physics/rrtmgp/ext
81-
url = https://github.com/earth-system-radiation/rte-rrtmgp.git
82-
fxrequired = AlwaysRequired
83-
fxtag = v1.9.2
84-
fxDONOTUSEurl = https://github.com/earth-system-radiation/rte-rrtmgp.git
85-
8679
[submodule "rrtmgp-data"]
8780
path = src/physics/rrtmgp/data
8881
url = https://github.com/earth-system-radiation/rrtmgp-data.git

bld/configure

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2138,16 +2138,16 @@ sub write_filepath
21382138
}
21392139
elsif ($rad eq 'rrtmgp') {
21402140
print $fh "$camsrcdir/src/physics/rrtmgp\n";
2141-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/extensions\n";
2142-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/gas-optics\n";
2143-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rrtmgp-frontend\n";
2144-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rte-frontend\n";
2141+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/extensions\n";
2142+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/gas-optics\n";
2143+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rrtmgp-frontend\n";
2144+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rte-frontend\n";
21452145
if ($use_rrtmgp_gpu) {
2146-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rrtmgp-kernels/accel\n";
2147-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rte-kernels/accel\n";
2146+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rrtmgp-kernels/accel\n";
2147+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rte-kernels/accel\n";
21482148
}
2149-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rrtmgp-kernels\n";
2150-
print $fh "$camsrcdir/src/physics/rrtmgp/ext/rte-kernels\n";
2149+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rrtmgp-kernels\n";
2150+
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/ext/rte-kernels\n";
21512151
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp\n";
21522152
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/objects\n";
21532153
}

doc/ChangeLog

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,64 @@
1+
===============================================================
2+
3+
Tag name: cam6_4_119
4+
Originator: peverwhee
5+
Date: 26 September, 2025
6+
One-line Summary: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces
7+
Github PR URL: https://github.com/ESCOMP/CAM/pull/1372
8+
9+
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
10+
Part of "Conversion of RRTMGP to CCPP" (#1192)
11+
- Modifies the interfaces in radiation.F90
12+
- Moves rrtmgp external to atmospheric_physics (schemes/rrtmgp/ext)
13+
14+
Describe any changes made to build system:
15+
16+
M bld/configure
17+
- update paths to RRTMGP external
18+
19+
Describe any changes made to the namelist: N/A
20+
21+
List any changes to the defaults for the boundary datasets: N/A
22+
23+
Describe any substantial timing or memory changes: N/A
24+
25+
Code reviewed by: nusbaume
26+
27+
List all files eliminated:
28+
29+
D src/physics/rrtmgp/ext
30+
- move submodule to atmospheric_physics
31+
32+
D src/physics/rrtmgp/rad_solar_var.F90
33+
- ccppized and moved to schemes/rrtmgp/rrtmgp_sw_solar_var.F90
34+
35+
List all files added and what they do: N/A
36+
37+
List all existing files that have been modified, and describe the changes:
38+
39+
M src/atmos_phys
40+
- updated submodule
41+
42+
M src/physics/rrtmgp/radiation.F90
43+
- update interface to use CCPPized schemes
44+
45+
M src/physics/rrtmgp/rrtmgp_inputs_cam.F90
46+
- ccppize and move sw gas optics and cloud optics
47+
48+
If there were any failures reported from running test_driver.sh on any test
49+
platform, and checkin with these failures has been OK'd by the gatekeeper,
50+
then copy the lines from the td.*.status files for the failed tests to the
51+
appropriate machine below. All failed tests must be justified.
52+
53+
derecho/intel/aux_cam: all BFB
54+
55+
derecho/nvhpc/aux_cam:
56+
ERS_Ln9.ne30pg3_ne30pg3_mt232.FHISTC_LTso.derecho_nvhpc.cam-outfrq9s_gpu_default
57+
- pre-existing failure- See issue: https://github.com/ESCOMP/CAM/issues/1383
58+
59+
izumi/nag/aux_cam: all BFB
60+
61+
izumi/gnu/aux_cam: all BFB
162

263
===============================================================
364

src/physics/rrtmgp/ext

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/physics/rrtmgp/rad_solar_var.F90

Lines changed: 0 additions & 156 deletions
This file was deleted.

0 commit comments

Comments
 (0)