Skip to content

Comments

Fix 3 paths in stream_definition_datm.xml#331

Merged
jedwards4b merged 2 commits intoESCOMP:mainfrom
samsrabin:fix-crujra20241231-paths
Mar 31, 2025
Merged

Fix 3 paths in stream_definition_datm.xml#331
jedwards4b merged 2 commits intoESCOMP:mainfrom
samsrabin:fix-crujra20241231-paths

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Mar 28, 2025

Description of changes

Three paths in stream_definition_datm.xml need to be changed from $DIN_LOC_ROOT_CLMFORC to $DIN_LOC_ROOT.

Specific notes

Contributors other than yourself, if any: None

CDEPS Issues Fixed (include github issue #):
Some work in #332

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): No

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

  • SMS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm60FatesCrujraRs.izumi_nag.clm-FatesCold
  • aux_cdeps: All pass except SMS_D_Ld3.f10_f10_ais8gris4_mg37.DATAMODELTEST.derecho_gnu, which fails in CREATE_NEWCASE

Hashes used for testing: 48691af

@samsrabin samsrabin marked this pull request as ready for review March 28, 2025 18:18
@ekluzek
Copy link
Collaborator

ekluzek commented Mar 28, 2025

We discussed this offline, and added a softlink to handle the issue for Izumi. This is great though because we want to long term remove DIN_LOC_ROOT_CLMFORC, and use softlinks instead on any machines that need multiple disks for inputdata as we needed to do here.

cime has an issue for this:

ESMCI/cime#3097

But, this also needs to be done in: ccs_config and cmeps. I've made issues there as well.

This is a nice usability improvement that would be good to have in the cesm3_0 release, because this variable adds confusion and doesn't play well with the auto download of data.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally needed because we didn't setup the needed softlink on Izumi. But it's still good as it does some work on #332. So good to bring in now.

@ekluzek ekluzek added enhancement New feature or request CESM Only Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group labels Mar 28, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Mar 28, 2025

@jedwards4b or @billsacks or @fischer-ncar could one of you approve this and merge it in?

Thanks

@jedwards4b jedwards4b merged commit 9e57b27 into ESCOMP:main Mar 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CESM Only enhancement New feature or request Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants